From patchwork Tue May 22 14:17:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Vorontsov X-Patchwork-Id: 8871 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 5B10723F0A for ; Tue, 22 May 2012 14:19:55 +0000 (UTC) Received: from mail-yw0-f52.google.com (mail-yw0-f52.google.com [209.85.213.52]) by fiordland.canonical.com (Postfix) with ESMTP id 2BA47A18B72 for ; Tue, 22 May 2012 14:19:55 +0000 (UTC) Received: by yhpp61 with SMTP id p61so6655450yhp.11 for ; Tue, 22 May 2012 07:19:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=0/VDJ8fDmyEjNlU9ijZNrg0A9cMVSUO3yCyIC1X3+ac=; b=Yx2C+BawlIIwVI+9DSyd0eYwkcWs5Fiu/CMct7bbWBlMHT4iX+OeIKhhp0dyRMfGeJ 7beLBDGYELagGd7vnZacVVTkflGwPEVLr80h7SelgHRKKF8NOFtMVObro/RsxZaIjuO/ SKkx1IEQ7DAw1gEoLraCHqzRS4eLJap48K1HPh94q/5qvY0kQfDWkeP69AxBBBDVFzBg BrEH6hAxakT2CAZetVysaghjJx8JBqItLfzT0vvlc/3BcaN+RL4fqZQcTqjZTHby37Gd yueUeG1cnyfvZcZPlLJEI5VJVKqHqeg1+biHi4le69fkMuSyUHYPeMrRt0LU3Iimh6QG hbrA== Received: by 10.50.154.169 with SMTP id vp9mr9591085igb.53.1337696394439; Tue, 22 May 2012 07:19:54 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.35.72 with SMTP id o8csp369471ibd; Tue, 22 May 2012 07:19:53 -0700 (PDT) Received: by 10.50.157.138 with SMTP id wm10mr9734223igb.65.1337696393331; Tue, 22 May 2012 07:19:53 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id u7si13297842igw.62.2012.05.22.07.19.53 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 22 May 2012 07:19:53 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) smtp.mail=anton.vorontsov@linaro.org Received: by pbbrr4 with SMTP id rr4so10070401pbb.37 for ; Tue, 22 May 2012 07:19:52 -0700 (PDT) Received: by 10.68.138.196 with SMTP id qs4mr14940007pbb.149.1337696392714; Tue, 22 May 2012 07:19:52 -0700 (PDT) Received: from localhost (c-71-204-165-222.hsd1.ca.comcast.net. [71.204.165.222]) by mx.google.com with ESMTPS id ub8sm26839138pbc.44.2012.05.22.07.19.50 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 22 May 2012 07:19:51 -0700 (PDT) From: Anton Vorontsov To: Greg Kroah-Hartman , Kees Cook , Colin Cross , Tony Luck Cc: Arnd Bergmann , John Stultz , Shuah Khan , arve@android.com, Rebecca Schultz Zavin , Jesper Juhl , Randy Dunlap , Stephen Boyd , Thomas Meyer , Andrew Morton , Marco Stornelli , WANG Cong , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com Subject: [PATCH 01/16] pstore/inode: Make pstore_fill_super() static Date: Tue, 22 May 2012 07:17:44 -0700 Message-Id: <1337696279-8994-1-git-send-email-anton.vorontsov@linaro.org> X-Mailer: git-send-email 1.7.9.2 In-Reply-To: <20120522141717.GA31574@lizard> References: <20120522141717.GA31574@lizard> X-Gm-Message-State: ALoCoQn6mFNvDlIbiXanQtZLqxZvmuJvQDgqvdCnWHfug0d4Ftc6XDvVaSODVQPEMTHBbB+6M7GK There's no reason to extern it. The patch fixes the annoying sparse warning: CHECK fs/pstore/inode.c fs/pstore/inode.c:264:5: warning: symbol 'pstore_fill_super' was not declared. Should it be static? Signed-off-by: Anton Vorontsov Acked-by: Kees Cook --- fs/pstore/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c index 1950788..49b40ea 100644 --- a/fs/pstore/inode.c +++ b/fs/pstore/inode.c @@ -258,7 +258,7 @@ fail: return rc; } -int pstore_fill_super(struct super_block *sb, void *data, int silent) +static int pstore_fill_super(struct super_block *sb, void *data, int silent) { struct inode *inode;