From patchwork Thu Apr 12 01:02:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Turquette X-Patchwork-Id: 7749 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id C808223E29 for ; Thu, 12 Apr 2012 01:07:47 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 8FADFA18142 for ; Thu, 12 Apr 2012 01:07:47 +0000 (UTC) Received: by mail-iy0-f180.google.com with SMTP id e36so2812921iag.11 for ; Wed, 11 Apr 2012 18:07:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :mime-version:content-type:x-gm-message-state; bh=X/TE6lYdfoPUvMKUiAS4XFqQr1MUfbf5yOylxTh3d2o=; b=aJQDFOuf6G7jFbl/GbIktL0H2m5BOwOJAJljBEBjSSYX3oQplOUc8/D3S7M6Xg79rD glRNQxQALYeOwo33NxSG8MyJbqF287s7xDDhRvSfeYLsNxZWSUP0jdjiF93owvszrQ1F BBBzORLpAXhPIhNXvKiifu0VkK4GWzY5f3Ydy95jMxxk5Kf4471w5UZ9/fceJlTe91lJ GgNQED/LQCh2bq2Dg6JQE/yqN8U58ebn0ieJ7n1nxRPLr/5h42BzJRkltZIDlqbGrHzw sI8jlMwfm5C4Rglf2/SJZMzYoH+cFBW5wDe1KyZhZb8XzsNEckI1geCAajfvJtSp66ka QA3g== Received: by 10.50.153.162 with SMTP id vh2mr1998031igb.38.1334192867344; Wed, 11 Apr 2012 18:07:47 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.164.217 with SMTP id f25csp161855iby; Wed, 11 Apr 2012 18:07:47 -0700 (PDT) Received: by 10.60.169.146 with SMTP id ae18mr661466oec.36.1334192866706; Wed, 11 Apr 2012 18:07:46 -0700 (PDT) Received: from bear.ext.ti.com (bear.ext.ti.com. [192.94.94.41]) by mx.google.com with ESMTPS id v9si1762221obb.155.2012.04.11.18.07.46 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 11 Apr 2012 18:07:46 -0700 (PDT) Received-SPF: neutral (google.com: 192.94.94.41 is neither permitted nor denied by best guess record for domain of mturquette@linaro.org) client-ip=192.94.94.41; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.94.94.41 is neither permitted nor denied by best guess record for domain of mturquette@linaro.org) smtp.mail=mturquette@linaro.org Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id q3C17gZ3011259; Wed, 11 Apr 2012 20:07:43 -0500 Received: from DFLE70.ent.ti.com (dfle70.ent.ti.com [128.247.5.40]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id q3C17gaR002755; Wed, 11 Apr 2012 20:07:42 -0500 Received: from dlelxv22.itg.ti.com (172.17.1.197) by dfle70.ent.ti.com (128.247.5.40) with Microsoft SMTP Server id 14.1.323.3; Wed, 11 Apr 2012 20:07:42 -0500 Received: from nucleus.nsc.com (nucleus.nsc.com [10.188.36.112]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id q3C17PnA005839; Wed, 11 Apr 2012 20:07:41 -0500 From: Mike Turquette To: CC: , , , , Rajendra Nayak , Mike Turquette , Olof Johansson , Russell King , Sascha Hauer , Shawn Guo , Richard Zhao , Saravana Kannan , Mark Brown , Andrew Lunn , Viresh Kumar Subject: [PATCH 09/13] clk: Make clk_get_rate() return 0 on error Date: Wed, 11 Apr 2012 18:02:47 -0700 Message-ID: <1334192572-12499-10-git-send-email-mturquette@linaro.org> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1334192572-12499-1-git-send-email-mturquette@linaro.org> References: <1334192572-12499-1-git-send-email-mturquette@linaro.org> MIME-Version: 1.0 X-Gm-Message-State: ALoCoQmWTX5w7mLVX3nGq3vkcTRfQcMh847rkdBGhFklyhqKMAyfQ4I75uYEzVoLVteBSJC61tiC From: Rajendra Nayak Most users of clk_get_rate() actually assume a non zero return value as a valid rate returned. Returing -EINVAL might confuse such users, so make it instead return zero on error. Besides the return value of clk_get_rate seems to be 'unsigned long'. Signed-off-by: Rajendra nayak Signed-off-by: Mike Turquette Cc: Arnd Bergman Cc: Olof Johansson Cc: Russell King Cc: Sascha Hauer Cc: Shawn Guo Cc: Richard Zhao Cc: Saravana Kannan Cc: Mark Brown Cc: Andrew Lunn Cc: Viresh Kumar Reviewed-by: Viresh Kumar --- drivers/clk/clk.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 9924aec..a24b121 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -285,7 +285,7 @@ unsigned long __clk_get_rate(struct clk *clk) unsigned long ret; if (!clk) { - ret = -EINVAL; + ret = 0; goto out; } @@ -295,7 +295,7 @@ unsigned long __clk_get_rate(struct clk *clk) goto out; if (!clk->parent) - ret = -ENODEV; + ret = 0; out: return ret; @@ -560,7 +560,7 @@ EXPORT_SYMBOL_GPL(clk_enable); * @clk: the clk whose rate is being returned * * Simply returns the cached rate of the clk. Does not query the hardware. If - * clk is NULL then returns -EINVAL. + * clk is NULL then returns 0. */ unsigned long clk_get_rate(struct clk *clk) {