From patchwork Wed Aug 10 23:01:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 3384 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 5C66D241D9 for ; Wed, 10 Aug 2011 23:02:47 +0000 (UTC) Received: from mail-qy0-f180.google.com (mail-qy0-f180.google.com [209.85.216.180]) by fiordland.canonical.com (Postfix) with ESMTP id 2C581A18285 for ; Wed, 10 Aug 2011 23:02:47 +0000 (UTC) Received: by qyk31 with SMTP id 31so1104019qyk.11 for ; Wed, 10 Aug 2011 16:02:46 -0700 (PDT) Received: by 10.229.163.10 with SMTP id y10mr112616qcx.83.1313017366640; Wed, 10 Aug 2011 16:02:46 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.229.190.71 with SMTP id dh7cs96543qcb; Wed, 10 Aug 2011 16:02:46 -0700 (PDT) Received: from mr.google.com ([10.236.153.8]) by 10.236.153.8 with SMTP id e8mr13083771yhk.179.1313017366428 (num_hops = 1); Wed, 10 Aug 2011 16:02:46 -0700 (PDT) Received: by 10.236.153.8 with SMTP id e8mr9680950yhk.179.1313017366163; Wed, 10 Aug 2011 16:02:46 -0700 (PDT) Received: from e3.ny.us.ibm.com (e3.ny.us.ibm.com [32.97.182.143]) by mx.google.com with ESMTPS id w1si2953662wfe.68.2011.08.10.16.02.45 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 10 Aug 2011 16:02:46 -0700 (PDT) Received-SPF: pass (google.com: domain of jstultz@us.ibm.com designates 32.97.182.143 as permitted sender) client-ip=32.97.182.143; Authentication-Results: mx.google.com; spf=pass (google.com: domain of jstultz@us.ibm.com designates 32.97.182.143 as permitted sender) smtp.mail=jstultz@us.ibm.com Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e3.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p7AMcfS8017112; Wed, 10 Aug 2011 18:38:41 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p7AN2iYg225926; Wed, 10 Aug 2011 19:02:44 -0400 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7AN2hsH008400; Wed, 10 Aug 2011 17:02:43 -0600 Received: from kernel.beaverton.ibm.com ([9.47.67.96]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p7AN2gFu008336; Wed, 10 Aug 2011 17:02:42 -0600 Received: by kernel.beaverton.ibm.com (Postfix, from userid 1056) id 373281E750E; Wed, 10 Aug 2011 16:02:42 -0700 (PDT) From: John Stultz To: LKML Cc: Sebastian Reichel , Thomas Gleixner , John Stultz Subject: [PATCH 3/4] rtc: rtc-twl: Remove lockdep related local_irq_enable() Date: Wed, 10 Aug 2011 16:01:57 -0700 Message-Id: <1313017318-789-4-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.7.3.2.146.gca209 In-Reply-To: <1313017318-789-1-git-send-email-john.stultz@linaro.org> References: <1313017318-789-1-git-send-email-john.stultz@linaro.org> From: Sebastian Reichel Now that the irq is properly threaded (due to it needing i2c access) we should also remove the local_irq_enable() call in twl_rtc_interrupt. Testing this with Pandaboard, the RTC is still working. Cc: Thomas Gleixner [Reworked commit message -jstultz] Signed-off-by: John Stultz --- drivers/rtc/rtc-twl.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c index 1963cdd..9677bbc 100644 --- a/drivers/rtc/rtc-twl.c +++ b/drivers/rtc/rtc-twl.c @@ -362,14 +362,6 @@ static irqreturn_t twl_rtc_interrupt(int irq, void *rtc) int res; u8 rd_reg; -#ifdef CONFIG_LOCKDEP - /* WORKAROUND for lockdep forcing IRQF_DISABLED on us, which - * we don't want and can't tolerate. Although it might be - * friendlier not to borrow this thread context... - */ - local_irq_enable(); -#endif - res = twl_rtc_read_u8(&rd_reg, REG_RTC_STATUS_REG); if (res) goto out;