From patchwork Wed Aug 10 23:01:56 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 3383 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 34BFD241D9 for ; Wed, 10 Aug 2011 23:02:46 +0000 (UTC) Received: from mail-qy0-f173.google.com (mail-qy0-f173.google.com [209.85.216.173]) by fiordland.canonical.com (Postfix) with ESMTP id 03807A1844B for ; Wed, 10 Aug 2011 23:02:45 +0000 (UTC) Received: by mail-qy0-f173.google.com with SMTP id 31so3629561qyk.11 for ; Wed, 10 Aug 2011 16:02:45 -0700 (PDT) Received: by 10.229.44.195 with SMTP id b3mr7009178qcf.7.1313017365738; Wed, 10 Aug 2011 16:02:45 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.229.190.71 with SMTP id dh7cs96542qcb; Wed, 10 Aug 2011 16:02:45 -0700 (PDT) Received: from mr.google.com ([10.101.47.1]) by 10.101.47.1 with SMTP id z1mr10976751anj.135.1313017365474 (num_hops = 1); Wed, 10 Aug 2011 16:02:45 -0700 (PDT) Received: by 10.101.47.1 with SMTP id z1mr7737885anj.135.1313017365189; Wed, 10 Aug 2011 16:02:45 -0700 (PDT) Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) by mx.google.com with ESMTPS id p14si903956wfd.15.2011.08.10.16.02.44 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 10 Aug 2011 16:02:45 -0700 (PDT) Received-SPF: pass (google.com: domain of jstultz@us.ibm.com designates 32.97.110.151 as permitted sender) client-ip=32.97.110.151; Authentication-Results: mx.google.com; spf=pass (google.com: domain of jstultz@us.ibm.com designates 32.97.110.151 as permitted sender) smtp.mail=jstultz@us.ibm.com Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e33.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p7AMsmEg011364; Wed, 10 Aug 2011 16:54:48 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p7AN2dOj072594; Wed, 10 Aug 2011 17:02:39 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7AN2d7c008195; Wed, 10 Aug 2011 17:02:39 -0600 Received: from kernel.beaverton.ibm.com ([9.47.67.96]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p7AN2dw1008165; Wed, 10 Aug 2011 17:02:39 -0600 Received: by kernel.beaverton.ibm.com (Postfix, from userid 1056) id CB9141E750E; Wed, 10 Aug 2011 16:02:38 -0700 (PDT) From: John Stultz To: LKML Cc: Ilkka Koskinen , Thomas Gleixner , John Stultz Subject: [PATCH 2/4] rtc: rtc-twl: Switch to using threaded irq Date: Wed, 10 Aug 2011 16:01:56 -0700 Message-Id: <1313017318-789-3-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.7.3.2.146.gca209 In-Reply-To: <1313017318-789-1-git-send-email-john.stultz@linaro.org> References: <1313017318-789-1-git-send-email-john.stultz@linaro.org> From: Ilkka Koskinen The driver is accessing to i2c bus in interrupt handler. Therefore, it should use threaded irq. Cc: Thomas Gleixner Signed-off-by: Ilkka Koskinen Acked-by: Balaji T K Signed-off-by: John Stultz --- drivers/rtc/rtc-twl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c index 9a81f77..1963cdd 100644 --- a/drivers/rtc/rtc-twl.c +++ b/drivers/rtc/rtc-twl.c @@ -462,7 +462,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev) if (ret < 0) goto out1; - ret = request_irq(irq, twl_rtc_interrupt, + ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt, IRQF_TRIGGER_RISING, dev_name(&rtc->dev), rtc); if (ret < 0) {