From patchwork Wed May 18 01:41:04 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 1517 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:52:40 -0000 Delivered-To: patches@linaro.org Received: by 10.224.54.134 with SMTP id q6cs52501qag; Tue, 17 May 2011 18:41:24 -0700 (PDT) Received: by 10.236.176.168 with SMTP id b28mr1428580yhm.130.1305682883592; Tue, 17 May 2011 18:41:23 -0700 (PDT) Received: from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149]) by mx.google.com with ESMTPS id x50si2330108yhm.68.2011.05.17.18.41.22 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 17 May 2011 18:41:22 -0700 (PDT) Received-SPF: pass (google.com: domain of jstultz@us.ibm.com designates 32.97.110.149 as permitted sender) client-ip=32.97.110.149; Authentication-Results: mx.google.com; spf=pass (google.com: domain of jstultz@us.ibm.com designates 32.97.110.149 as permitted sender) smtp.mail=jstultz@us.ibm.com Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e31.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p4I1OvJc028619; Tue, 17 May 2011 19:24:57 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p4I1gXrh146390; Tue, 17 May 2011 19:42:33 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4HJelFo020054; Tue, 17 May 2011 13:40:48 -0600 Received: from kernel.beaverton.ibm.com (kernel.beaverton.ibm.com [9.47.67.96]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p4HJeluN020049; Tue, 17 May 2011 13:40:47 -0600 Received: by kernel.beaverton.ibm.com (Postfix, from userid 1056) id F29DF1E7511; Tue, 17 May 2011 18:41:13 -0700 (PDT) From: John Stultz To: LKML Cc: John Stultz , Joe Perches , Ingo Molnar , Michal Nazarewicz , Andy Whitcroft , Jiri Slaby , KOSAKI Motohiro , David Rientjes , Dave Hansen , Andrew Morton , linux-mm@kvack.org Subject: [PATCH 3/4] printk: Add %ptc to safely print a task's comm Date: Tue, 17 May 2011 18:41:04 -0700 Message-Id: <1305682865-27111-4-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.7.3.2.146.gca209 In-Reply-To: <1305682865-27111-1-git-send-email-john.stultz@linaro.org> References: <1305682865-27111-1-git-send-email-john.stultz@linaro.org> Accessing task->comm requires proper locking. However in the past access to current->comm could be done without locking. This is no longer the case, so all comm access needs to be done while holding the comm_lock. In my attempt to clean up unprotected comm access, I've noticed most comm access is done for printk output. To simplify correct locking in these cases, I've introduced a new %ptc format, which will print the corresponding task's comm. Example use: printk("%ptc: unaligned epc - sending SIGBUS.\n", current); CC: Joe Perches CC: Ingo Molnar CC: Michal Nazarewicz CC: Andy Whitcroft CC: Jiri Slaby CC: KOSAKI Motohiro CC: David Rientjes CC: Dave Hansen CC: Andrew Morton CC: linux-mm@kvack.org Reviewed-by: KOSAKI Motohiro Signed-off-by: John Stultz --- lib/vsprintf.c | 24 ++++++++++++++++++++++++ 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index bc0ac6b..b7a9953 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -797,6 +797,23 @@ char *uuid_string(char *buf, char *end, const u8 *addr, return string(buf, end, uuid, spec); } +static noinline_for_stack +char *task_comm_string(char *buf, char *end, void *addr, + struct printf_spec spec, const char *fmt) +{ + struct task_struct *tsk = addr; + char *ret; + unsigned long flags; + + spin_lock_irqsave(&tsk->comm_lock, flags); + ret = string(buf, end, tsk->comm, spec); + spin_unlock_irqrestore(&tsk->comm_lock, flags); + + return ret; +} + + + int kptr_restrict = 1; /* @@ -864,6 +881,12 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr, } switch (*fmt) { + case 't': + switch (fmt[1]) { + case 'c': + return task_comm_string(buf, end, ptr, spec, fmt); + } + break; case 'F': case 'f': ptr = dereference_function_descriptor(ptr); @@ -1151,6 +1174,7 @@ qualifier: * http://tools.ietf.org/html/draft-ietf-6man-text-addr-representation-00 * %pU[bBlL] print a UUID/GUID in big or little endian using lower or upper * case. + * %ptc outputs the task's comm name * %n is ignored * * The return value is the number of characters which would