From patchwork Mon Jan 25 08:34:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Long X-Patchwork-Id: 60276 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp1222810lbb; Mon, 25 Jan 2016 00:36:07 -0800 (PST) X-Received: by 10.98.42.81 with SMTP id q78mr23939711pfq.142.1453710967058; Mon, 25 Jan 2016 00:36:07 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r5si32179892pfr.2.2016.01.25.00.36.06; Mon, 25 Jan 2016 00:36:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=pass header.i=@linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932257AbcAYIgE (ORCPT + 30 others); Mon, 25 Jan 2016 03:36:04 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:33979 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932075AbcAYIf5 (ORCPT ); Mon, 25 Jan 2016 03:35:57 -0500 Received: by mail-pf0-f171.google.com with SMTP id q63so80781729pfb.1 for ; Mon, 25 Jan 2016 00:35:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=gQyNbtLiROo/XcjEvDA7ehymNrscvfnsgplHKrFhC38=; b=j8jRnNz7MO3Wog+QjgZGxHvEhOWKc1CMvNxruIo1c4xpWLhKTcPe13soZjH/M3Ru7y AnRIAxBYjesATqayf0wu6VAVxezuZLZelD6LnM1WK64X7Iey11OPQLNL/0fc/fpNxcB1 MjrCmB7R7Yi0sSTJ5JUdhGUGUQlASjZU68JGg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=gQyNbtLiROo/XcjEvDA7ehymNrscvfnsgplHKrFhC38=; b=nFNgBatOlYqbucxzxn0/uKX91hn16j//gbi7ml6+0uqzv/eEUoYLWqzqddKEfUUvf3 k1fmjhGgV+WTu0ZGD96pGCUzHZS62IuRsXu73k7Tc34emb/nI4qyHfSQlYfXWdzJaZ7n TEyRu+0VxqAUC98ajDERQtvyGJmdEJbaCygsu7eLVCGd4+4qF6BbmC+0uhoaYLCJnEIi RYUZ1GWgCiRFlV8qdm3gMO8bYbMuOp2neS1YoSv8IIiG9dLaNehblXz4/UuAfVKRwB9I +ZCm4DqZ3qCgCT6bEDNq6Lvp+zfyk5VGHp5VMhUp3Al0agxbuCTKRvpxiUacCa+fIwuQ SWIQ== X-Gm-Message-State: AG10YOTGlFpkJFASfVTzupIOVghpWUU6w+WNCnKEzjm8s2ZIpt3nN55eSuBbtT6hesTHUIt2 X-Received: by 10.98.64.27 with SMTP id n27mr24319828pfa.58.1453710956856; Mon, 25 Jan 2016 00:35:56 -0800 (PST) Received: from ericlongubtpc.spreadtrum.com ([175.111.195.49]) by smtp.gmail.com with ESMTPSA id ah10sm26609838pad.23.2016.01.25.00.35.54 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 25 Jan 2016 00:35:56 -0800 (PST) From: Eric Long To: mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: baolin.wang@linaro.org, zhang.chunyan@linaro.org, eric.long@linaro.org Subject: [PATCH v2 2/2] coresight: etm4x: Check every parameter used by dma_xx_coherent. Date: Mon, 25 Jan 2016 16:34:56 +0800 Message-Id: <00fb1f689658102676c338a2c4fd95046346f588.1453708131.git.eric.long@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The dma_alloc_coherent return an "void *" not an "void __iomen *". It uses the wrong parameters when calls dma_free_coherent function. The sparse tool output logs as the following: coresight-tmc.c:199:23: expected void * coresight-tmc.c:199:23: got void [noderef] *vaddr coresight-tmc.c:336:30: warning: incorrect type in assignment (different address spaces) coresight-tmc.c:336:30: expected char *buf coresight-tmc.c:336:30: got void [noderef] * coresight-tmc.c:769:50: warning: incorrect type in argument 4 (different base types) coresight-tmc.c:769:50: expected unsigned long long [unsigned] [usertype] dma_handle coresight-tmc.c:769:50: got restricted gfp_t Signed-off-by: Eric Long --- drivers/hwtracing/coresight/coresight-tmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.7.9.5 diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c index a57c7ec..5b052d1 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.c +++ b/drivers/hwtracing/coresight/coresight-tmc.c @@ -124,7 +124,7 @@ struct tmc_drvdata { bool reading; char *buf; dma_addr_t paddr; - void __iomem *vaddr; + void *vaddr; u32 size; bool enable; enum tmc_config_type config_type; @@ -766,7 +766,7 @@ err_misc_register: err_devm_kzalloc: if (drvdata->config_type == TMC_CONFIG_TYPE_ETR) dma_free_coherent(dev, drvdata->size, - &drvdata->paddr, GFP_KERNEL); + drvdata->vaddr, drvdata->paddr); return ret; } @@ -778,7 +778,7 @@ static int tmc_remove(struct amba_device *adev) coresight_unregister(drvdata->csdev); if (drvdata->config_type == TMC_CONFIG_TYPE_ETR) dma_free_coherent(drvdata->dev, drvdata->size, - &drvdata->paddr, GFP_KERNEL); + drvdata->vaddr, drvdata->paddr); return 0; }