From patchwork Thu Jul 22 12:17:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Wiklander X-Patchwork-Id: 483895 Delivered-To: patches@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp307126jao; Thu, 22 Jul 2021 05:18:07 -0700 (PDT) X-Received: by 2002:ac2:5225:: with SMTP id i5mr30574446lfl.510.1626956286843; Thu, 22 Jul 2021 05:18:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626956286; cv=none; d=google.com; s=arc-20160816; b=rdPbk8Wv7k8NILg8VoPBzAmGFQiyRo4aTMw9l+g34FVsU70JwjTDd1RxvI2/afoat2 r7sqbVQ1bL7/5TKjArUNGQbAKbQ0X1NQg/uBDBKW3ip2mAbW8lY7NII7iLCllIjQ/WZt bHsZuQhSJY3QJSULGdlJW15vRC1gzL2kAzNfB725EzVkusEUK8VujSfjvW2scz/jc6nx quZCpTWx4VJKi/TqcgNEAo7wzKIsYXZGQ+rxwjxuK5hVdPBqEBDvUzty3dnilNHQ+PNy mw6NDK1Gubz2D+ggdidCdHT/V7oRGsb2ZbhmPkzJyjU8EpKPtyIMgMWiXXrPt7pooLpi EmYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=UtOWa2lL7DU7+uz9y77s+2dIz9u9H/PKNPEgTCXPwT4=; b=Ttu36Xq+wHaSwXbAd1cCSvT5HiF37OWtuhQDynBXuabgoo98TXQeGZnUdVQPMmgvWr iVvu++GE8h/VqNC9rsJii4mBRkQJpfCGzK/53CrbAoZQw9CPJx8cGpWj0b6qtg/AaYHB 06eMUnUv2vHC8NbiMn9KvDjq5FhBszSvIWU4VDc3fGnSwp3+hbJl3RaarrJz4BhEwKPk 9lci0FOFjQ53+Re70Jdl5D/iEDi9Hq2o3MfwSyiask762racxmno3EMOO9p+iv9JBXGh VK1p+6eeKXiAMY1Ee2Q4ZWx22FU4hR5xACFha7iVVOTNcjTDLebqBThCPF+3cnnE5VR2 xbHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FuFu3y+C; spf=pass (google.com: domain of jens.wiklander@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id p9sor1346158lfk.133.2021.07.22.05.18.06 for (Google Transport Security); Thu, 22 Jul 2021 05:18:06 -0700 (PDT) Received-SPF: pass (google.com: domain of jens.wiklander@linaro.org designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FuFu3y+C; spf=pass (google.com: domain of jens.wiklander@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UtOWa2lL7DU7+uz9y77s+2dIz9u9H/PKNPEgTCXPwT4=; b=FuFu3y+Cme1GCFNZiFBIv37H2HS/O/Cy1DUZmxv7gbVtxUxjDIVAHbyZUdWm4qmiWY a0emq6HIL6CrntNYbiOhubaM/T+3zctQRWTKBz276xz6hlclOdYRulERamlH3wGIYFOY lrglYhNTBkPmRHtcn2vIVrukXodl83js8pujNoAXpV+xenJKtV63LAIQDn8cf0PCKJx/ KGEaIHnTo8+fL8MFOeJSQaO1Ril53ef3lKNzfQD0ClgT8DA9AwGcwvlJfBd75ckalTvV pDu40cG/hevkIRyfuzIUivgcmFne1zr7DU7rHx2LLQaCKMwT0i0GovgXAI97xBlJXd4C Wlvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UtOWa2lL7DU7+uz9y77s+2dIz9u9H/PKNPEgTCXPwT4=; b=ZZgobriVwYOksEaG4X28NvplwK6waVyWVQT9y6dk0NDQ2OkMoyuDeysOG9z3SKmRp+ 538OOMwRoqITCC4YNw/PdFoYHx2ncL/0JPvCjWYN0FVfExSDSTh2JD/EzT6myg0N8Gsz PHS8zgM/enBpPN8v4ftAqqD98ouHOO9VvcyBRUz4lgocnoemV3u4G+Ern+KvmimkeSf2 86yY/H8+QpSxiiXz5vr+AZjL5YGAdAxUKV7nw3wOFxuiZk8PrsPmPY+4XettMgkWZcFm ksxjGr7drGKEbYuRWpIJ9Wm3dI8kLGBc7GxRxeehxgB4oPAN+0jRTMpCJbg2lY6kGtba /23A== X-Gm-Message-State: AOAM530NSSX82esGksUf04gq17b354Vba65fg9zgJ0fgxBkZwP8FitPx 1NX2smiuwr9GicXackOmZsI//TrX X-Google-Smtp-Source: ABdhPJzAuK8mnM/roxQJVP/OoPkjfnPfIN0iaMP4V5osxSOh0fVjK8sVGS6gosrD0e44IU/RBlyigQ== X-Received: by 2002:a19:a403:: with SMTP id q3mr29802876lfc.287.1626956286415; Thu, 22 Jul 2021 05:18:06 -0700 (PDT) Return-Path: Received: from jade.urgonet (h-94-254-48-165.A175.priv.bahnhof.se. [94.254.48.165]) by smtp.gmail.com with ESMTPSA id b41sm845090ljr.67.2021.07.22.05.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jul 2021 05:18:06 -0700 (PDT) From: Jens Wiklander To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org Cc: Sumit Garg , Sudeep Holla , Marc Bonnici , Jerome Forissier , sughosh.ganu@linaro.org, Jens Wiklander Subject: [PATCH v3 0/5] Add FF-A support in OP-TEE driver Date: Thu, 22 Jul 2021 14:17:52 +0200 Message-Id: <20210722121757.1944658-1-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Hi all, This adds supports for the OP-TEE driver to communicate with secure world using FF-A [1] as transport. There is one change to the TEE subsystem with "tee: add sec_world_id to struct tee_shm" to add support for holding globally unique handle assigned by the FF-A. This is a field that I believe could useful for the AMDTEE driver too. For communication the OP-TEE message protocol is still used, but with a new type of memory reference, struct optee_msg_param_fmem, to carry the information needed by FF-A. The OP-TEE driver is refactored internally with to sets of callbacks, one for the old SMC based communication and another set with FF-A as transport. The functions relating to the SMC based ABI are moved to smc_abi.c while the FF-A based ABI is added in a ffa_abi.c. There is also a difference in how the drivers are instantiated. With the SMC based transport we have a platform driver, module_platform_driver(), today which we're keeping as is for this configuration. In a FF-A system we have a FF-A driver, module_ffa_driver(), instead. The OP-TEE driver can be compiled for both targets at the same time and it's up to runtime configuration (device tree or ACPI) to decide how it's initialized. Note that it's only the old SMC based driver instance that need device tree or ACPI to initialize. The FF-A based driver relies on the FF-A bus instead. This can be tested QEMU The repo for SPMC at S-EL1 retrieved by repo init -u https://github.com/jenswi-linaro/manifest.git -m qemu_v8.xml -b ffav4_spmc repo sync # Then checkout the branch optee_ffa_v3 from # git://git.linaro.org/people/jens.wiklander/linux-tee.git # in the linux directory To build do: cd build make toolchains make all To boot: make run-only Test with xtest, perhaps only with the command "xtest 1004" in case you're not interested in too many tests. Thanks, Jens [1] https://developer.arm.com/documentation/den0077/latest v2->v3: - Rebased on 5.14-rc2 which now have the FF-A patches merged - Fixed a couple bugs in optee_shm_register() and optee_shm_unregister() which where introduced in "optee: refactor driver with internal callbacks" in previous the version. - Separated SMC ABI specifics into smc_abi.c to keep it separated from the FF-A ABI functions as requested by Sumit. - Added the FF-A specifics in ffa_abi.c - Provided an implementation for optee_ffa_remove() v1->v2: - Rebased to the FF-A v7 patch - Fixed a couple of reports from kernel test robot Jens Wiklander (5): tee: add sec_world_id to struct tee_shm optee: simplify optee_release() optee: refactor driver with internal callbacks optee: isolate smc abi optee: add FF-A support drivers/tee/optee/Makefile | 7 +- drivers/tee/optee/call.c | 415 ++------- drivers/tee/optee/core.c | 673 ++------------- drivers/tee/optee/ffa_abi.c | 910 ++++++++++++++++++++ drivers/tee/optee/optee_ffa.h | 153 ++++ drivers/tee/optee/optee_msg.h | 27 +- drivers/tee/optee/optee_private.h | 155 +++- drivers/tee/optee/rpc.c | 270 +----- drivers/tee/optee/shm_pool.c | 89 -- drivers/tee/optee/shm_pool.h | 14 - drivers/tee/optee/smc_abi.c | 1301 +++++++++++++++++++++++++++++ include/linux/tee_drv.h | 7 +- 12 files changed, 2650 insertions(+), 1371 deletions(-) create mode 100644 drivers/tee/optee/ffa_abi.c create mode 100644 drivers/tee/optee/optee_ffa.h delete mode 100644 drivers/tee/optee/shm_pool.c delete mode 100644 drivers/tee/optee/shm_pool.h create mode 100644 drivers/tee/optee/smc_abi.c -- 2.31.1