From patchwork Wed Jun 30 01:34:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 468673 Delivered-To: patches@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp5477361jao; Tue, 29 Jun 2021 18:34:30 -0700 (PDT) X-Received: by 2002:a65:4109:: with SMTP id w9mr30671212pgp.24.1625016870610; Tue, 29 Jun 2021 18:34:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625016870; cv=none; d=google.com; s=arc-20160816; b=wuhGWOGlEto4lFzzJqHq69p5cehaILrQaQtcro9mtMVdbhFPQ0gGdh80wK1jLSFxAE VPeuSY6qnNuI6Ug3GQ4edmdysGN4/Kt3hwcZx8mpHVbYWtOIfs/k5Dyi2CHusV5Zrgfh mP9mrNbQUg8RTUDEx3a0mLu4paeX3DaHCO8vNp54ph8IPflDJcfwlMI17JCP5siCKbvp tBw0uphURs5BZvp9lPVwaxf8dRcR278nbM63q6iuzfWqhr2HcdtsbZ5OFPK2BfcFvSjd eBqYQ09V+lDcK45aVeRsvhunELF2p8qeQ+vb/C/ZCuxfcmiljyRkF7RyhZdUuy6SHEiK h6ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=FBEInOJoYqxwrlE52K6MZcC340XktufPlx9tQHJv3jk=; b=SMoosUKEKMffzj/HBSVx82VfKA97DhEC8FynVpJB2rH7dKHEDMOIBluCS3WnTYxEIw FPNMxkcD/nrLC6Db7vRQA4g/HQVC6P7w/7VdNVmC5n4kdyt36rkU1d2hGwC0MfvvCNrY qrXjJc9+b4I5VTy0+qlVr3RwdF941zZdU8Z8KKXfYAEzo/ZDJfG3q+qlzpLDq003HqtS w08cG8nLPpKC7cAxYKwWjPAlJBmiV2PwxVH5RCKFgVJbH1X7SxZPklV/mZdnJlKpD/5n GVvQxk6YNAOMWBbmsQG99fqfcFTyuUYJmOkahMtQtrCL6wmLn/tMaCA5mxL07c4uHuRY 46cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fpOTxwV4; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id a18sor8720659pgm.64.2021.06.29.18.34.30 for (Google Transport Security); Tue, 29 Jun 2021 18:34:30 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fpOTxwV4; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FBEInOJoYqxwrlE52K6MZcC340XktufPlx9tQHJv3jk=; b=fpOTxwV4zxW4Q0vXTnzAdyWRKSNOkJ6Yt5nUdEs8+fAMn3XqRToSnVNet0pTIFnaQR cCMSSrzMa51N8/Ca9p8l+jqocYP7FxLde/JNiiOXRZpFjYvUZvmjGetBCLP3kAsvmSTu vPYFOQyaPT9Nc9Ch2RPF7gKN/31atj/e33ZaTm42GJBlu+dsply2TCWz1h9jDasglrK2 lxd+aDaz4eznt1K2MTO1ZUdHwqjfof/Z0YadmFAefD1MZJ0VnjY/1G99vVC7naW8Orzn AsBMrloc8ZhRKOkpgR1aURI0ECgbQu8TPF0eYWu1KJ4Sq+UEo+4orwgB5DI31WQzdTTg N9xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FBEInOJoYqxwrlE52K6MZcC340XktufPlx9tQHJv3jk=; b=bkthiDI2v7TflRvA8ihKSftCbh6oF1lnmFIthHf6WfKh9a8n7KnXuBf0DkOPQaV5pN jnf8y7nzSodlYUpCZBnzZgUZO6STUzkC/YRp9/+KHgYUitQpp7VEGxmgfWDzKmwI2Tz1 7Y1NVlLA+DqqNJ3hmV9MDNQUhlMuFUHwTKeTRUJT7IKLmWarTy+3jX9E8VCVVtQqwqQv hTXsuM8ae+rHeY6mLE+yey1TrMkzOHZzdE84xvHkWRA8xSchK3ms4i5JwMUvPZu7DNX6 4gSn+FKPM/rG5k11TmZDqfY5F3qLY3auzZcEKK0ulQhlg9uZRMgC+K+DyLi+pndFIcn4 fwsw== X-Gm-Message-State: AOAM531wOZMDIeI0IpLuWS8EPF2NRyhtP49dW028i8RDu4x0XcD6wQmJ ZbP3xfnTj9u4Uubkw1sPTA+gCx2d X-Google-Smtp-Source: ABdhPJzSoY1EJeRDCOfTvywVVy/GFDhxptRl0SIl647lxALfT485QBgs8oQza+YKOuAOTR5gyn9Lag== X-Received: by 2002:a63:5966:: with SMTP id j38mr30913446pgm.451.1625016870033; Tue, 29 Jun 2021 18:34:30 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id g8sm20252901pja.14.2021.06.29.18.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 18:34:29 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Daniel Vetter , Christian Koenig , Sumit Semwal , Liam Mark , Chris Goldsworthy , Laura Abbott , Brian Starkey , Hridya Valsaraju , Suren Baghdasaryan , Sandeep Patil , Daniel Mentz , =?utf-8?q?=C3=98rjan_Eide?= , Robin Murphy , Ezequiel Garcia , Simon Ser , James Jones , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v9 0/5] Generic page pool & deferred freeing for system dmabuf hea Date: Wed, 30 Jun 2021 01:34:16 +0000 Message-Id: <20210630013421.735092-1-john.stultz@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 After an unfortunately long pause (covid work-schedule burnout), I wanted to revive and resubmit this series. As before, the point of this series is trying to add both a page pool as well as deferred-freeingto the DMA-BUF system heap to improve allocation performance (so that it can match or beat the old ION system heaps performance). The combination of the page pool along with deferred freeing allows us to offload page-zeroing out of the allocation hot path. This was done originally with ION and this patch series allows the DMA-BUF system heap to match ION's system heap allocation performance in a simple microbenchmark [1] (ION re-added to the kernel for comparision, running on an x86 vm image): ./dmabuf-heap-bench -i 0 1 system Testing dmabuf system vs ion heaptype 0 (flags: 0x1) --------------------------------------------- dmabuf heap: alloc 4096 bytes 5000 times in 79314244 ns 15862 ns/call ion heap: alloc 4096 bytes 5000 times in 107390769 ns 21478 ns/call dmabuf heap: alloc 1048576 bytes 5000 times in 259083419 ns 51816 ns/call ion heap: alloc 1048576 bytes 5000 times in 340497344 ns 68099 ns/call dmabuf heap: alloc 8388608 bytes 5000 times in 2603105563 ns 520621 ns/call ion heap: alloc 8388608 bytes 5000 times in 3613592860 ns 722718 ns/call dmabuf heap: alloc 33554432 bytes 5000 times in 12212492979 ns 2442498 ns/call ion heap: alloc 33554432 bytes 5000 times in 14584157792 ns 2916831 ns/call Daniel didn't like earlier attempts to re-use the network page-pool code to achieve this, and suggested the ttm_pool be used instead, so this series pulls the page pool functionality out of the ttm_pool logic and creates a generic page pool that can be shared. New in v9: * Tried to address Christian König's feedback on the page pool changes (Kerneldoc, static functions, locking issues, duplicative order tracking) * Fix up Kconfig dependency issue as Reported-by: kernel test robot * Fix compiler warning Reported-by: kernel test robot I know Christian had some less specific feedback on the deferred free work that I'd like to revisit, but I wanted to restart the discussion with this new series, rather then trying to dregdge up and reply to a ~4mo old thread. Input would be greatly appreciated. Testing as well, as I don't have any development hardware that utilizes the ttm pool. Thanks -john [1] https://android.googlesource.com/platform/system/memory/libdmabufheap/+/refs/heads/master/tests/dmabuf_heap_bench.c Cc: Daniel Vetter Cc: Christian Koenig Cc: Sumit Semwal Cc: Liam Mark Cc: Chris Goldsworthy Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Daniel Mentz Cc: Ørjan Eide Cc: Robin Murphy Cc: Ezequiel Garcia Cc: Simon Ser Cc: James Jones Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org John Stultz (5): drm: Add a sharable drm page-pool implementation drm: ttm_pool: Rework ttm_pool to use drm_page_pool dma-buf: system_heap: Add drm pagepool support to system heap dma-buf: heaps: Add deferred-free-helper library code dma-buf: system_heap: Add deferred freeing to the system heap drivers/dma-buf/heaps/Kconfig | 5 + drivers/dma-buf/heaps/Makefile | 1 + drivers/dma-buf/heaps/deferred-free-helper.c | 138 +++++++++ drivers/dma-buf/heaps/deferred-free-helper.h | 55 ++++ drivers/dma-buf/heaps/system_heap.c | 46 ++- drivers/gpu/drm/Kconfig | 4 + drivers/gpu/drm/Makefile | 2 + drivers/gpu/drm/page_pool.c | 297 +++++++++++++++++++ drivers/gpu/drm/ttm/ttm_pool.c | 167 ++--------- include/drm/page_pool.h | 68 +++++ include/drm/ttm/ttm_pool.h | 14 +- 11 files changed, 643 insertions(+), 154 deletions(-) create mode 100644 drivers/dma-buf/heaps/deferred-free-helper.c create mode 100644 drivers/dma-buf/heaps/deferred-free-helper.h create mode 100644 drivers/gpu/drm/page_pool.c create mode 100644 include/drm/page_pool.h -- 2.25.1