From patchwork Tue Nov 10 03:49:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 320999 Delivered-To: patches@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp2273716ilc; Mon, 9 Nov 2020 19:49:38 -0800 (PST) X-Received: by 2002:a17:90a:ea92:: with SMTP id h18mr2743220pjz.125.1604980178734; Mon, 09 Nov 2020 19:49:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604980178; cv=none; d=google.com; s=arc-20160816; b=HXAswksibFeU8jkOS/mgwQBlpqLM/XETaYnwjofJUcs4VrC0FYAgFNUhT8KpJ/6uiH WwYj+YZSBX/NF3BQy5lzCowSrRO2rvSSp+/MkfSS6rWYPza4My7anqdMzPmfSfU/1kzW G1G++ORLjwXw8D9VLfhSnECXF9krnkK8HUCUclRxGjTHGA2KsKN3VRDxy+nNn8xSq/QG RNZd2bFTmLC2ycbSJeIJqHQT524QMuNTbB2NvBZgbZ0UPrjfOLw/OQHXXlAhhnIcu+oS b/2T1yWUFPEwsOn/Mc5Xq9iWBnq+ctd6njaWrv/Uj6tT4HXb5DWGkUheSFjFnfhphS1w 8WEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=sDoxEoYXzOGDTRqKHmsK1PmkQ+v+kjtjORMumiaAdaY=; b=t+NpB+UWvUoMT7dAjfC6xmonEh/4E7ctY3z2np3nD0i3OfG4adZPXtS0TvcKJFKs/c x3+aU/5Bnm5buppqnZQOilQQP0CcgswMw1+HXeUw6PaF4vZlB+6NIS5ozXSiy/k+eBiP 6vdzkKUcRyDfOayfEyLoy9elF76PyLdh9liTyECDo+dq1HwGgeb1H+6kz33lyUQ9SaWQ 1hE21vBFKJVgLwHSZ0bEMRi2C6Ly0ZJvQZSWzrpC10AThdwDf/ayiISOhLODi9ajxh3I NoMdaXGKYVK2TFhvMBGvvpgm6gi3Z3085gfVpJQY6yMo8+BKsOqaaVDn7INjbHMLIHdD hvGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VRHtKHrH; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id b3sor1107636pjp.18.2020.11.09.19.49.38 for (Google Transport Security); Mon, 09 Nov 2020 19:49:38 -0800 (PST) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VRHtKHrH; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sDoxEoYXzOGDTRqKHmsK1PmkQ+v+kjtjORMumiaAdaY=; b=VRHtKHrHp+YYnxmp5gRTU5t79Mq1+WJABfC0oh+1Cza26fX35vqeIx0L7pTcKEGdU6 oE7L7TMvPdmMiAWjDBxnEqqH6vZuu7nkQdgMtO4ya0zUSdp7zFPLHG3cAA/4+I6iJTSv Dfl+SskuSqxVcP06diQkjLgkoaYUzFobZyNAuAzBxuDJ8rW3bYmniabBkXEE0iYn6lKD 2Offn4yIOhOBLAHNJbPGPN85qS+phnyo+6ye4t7WOzp8VkUz/Fdu0eGL1ZJ/ssKFriBO NlMBufWsCcZcYF5pfeFv30h41qabhd8gLf3ysS0yokatYdlM5+pOlK+I6mntknRC7TcX En8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sDoxEoYXzOGDTRqKHmsK1PmkQ+v+kjtjORMumiaAdaY=; b=Nm7BjZmHL3R4z5t322U84lWNAu4QqB8WvfZSsm4jxIbh+cvYbUleXoisix3NxRKzWQ tlwr0EN8Br884fui3cn9uWR6W6a0H1QUSTXCPtPgA/JcYAkrGfDK+6W4pZ8wo8Zew6Na v0I+SIKZ7vKn+XuEnbZPlQb+N7pNmku/TemWzQEB3HAlXzvfRc6j7jKpAUtgxC8SzZXx ouEZVov6gdZlqssu0Fn2Bc2FnpI1A+aCCnhxOL8IeUWyUwJH/JprNUZ8XpjyVYPwoaLe NnCcpVHlG/CYuz3tIGDMh7pSN8tPYCmqgV2cGhAb52owyHzJiOk1+0VC6q0qAS3gFsD8 /aEg== X-Gm-Message-State: AOAM533Q5iU5UcraoDON1RVDcTlAaY0FMXjY0scPILo86N2swCl1vd0k LtVBPuVfBfNhDq8xiNfFxC6YvjZB X-Google-Smtp-Source: ABdhPJzH2pSKF1PV/0DDDEBwUaDZ0Qy7l115AmJfeyhAyHCxq657BbYMJVv7zdoWvPj0zHB54WdOCw== X-Received: by 2002:a17:90b:3708:: with SMTP id mg8mr2765897pjb.192.1604980178162; Mon, 09 Nov 2020 19:49:38 -0800 (PST) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id b4sm12380693pfi.208.2020.11.09.19.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 19:49:37 -0800 (PST) From: John Stultz To: lkml Cc: John Stultz , Sumit Semwal , Liam Mark , Laura Abbott , Brian Starkey , Hridya Valsaraju , Suren Baghdasaryan , Sandeep Patil , Daniel Mentz , Chris Goldsworthy , =?utf-8?q?=C3=98rjan_Eide?= , Robin Murphy , Ezequiel Garcia , Simon Ser , James Jones , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v5 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation Date: Tue, 10 Nov 2020 03:49:27 +0000 Message-Id: <20201110034934.70898-1-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Hey All, So just wanted to send my last revision of my patch series of performance optimizations to the dma-buf system heap. This series reworks the system heap to use sgtables, and then consolidates the pagelist method from the heap-helpers into the CMA heap. After which the heap-helpers logic is removed (as it is unused). I'd still like to find a better way to avoid some of the logic duplication in implementing the entire dma_buf_ops handlers per heap. But unfortunately that code is tied somewhat to how the buffer's memory is tracked. As more heaps show up I think we'll have a better idea how to best share code, so for now I think this is ok. After this, the series introduces an optimization that Ørjan Eide implemented for ION that avoids calling sync on attachments that don't have a mapping. Next, an optimization to use larger order pages for the system heap. This change brings us closer to the current performance of the ION allocation code (though there still is a gap due to ION using a mix of deferred-freeing and page pools, I'll be looking at integrating those eventually). Finally, a reworked version of my uncached system heap implementation I was submitting a few weeks back. Since it duplicated a lot of the now reworked system heap code, I realized it would be much simpler to add the functionality to the system_heap implementation itself. While not improving the core allocation performance, the uncached heap allocations do result in *much* improved performance on HiKey960 as it avoids a lot of flushing and invalidating buffers that the cpu doesn't touch often. Feedback on these would be great! thanks -john New in v5: * Added a comment explaining why the order sizes are chosen as they are Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Daniel Mentz Cc: Chris Goldsworthy Cc: Ørjan Eide Cc: Robin Murphy Cc: Ezequiel Garcia Cc: Simon Ser Cc: James Jones Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org John Stultz (7): dma-buf: system_heap: Rework system heap to use sgtables instead of pagelists dma-buf: heaps: Move heap-helper logic into the cma_heap implementation dma-buf: heaps: Remove heap-helpers code dma-buf: heaps: Skip sync if not mapped dma-buf: system_heap: Allocate higher order pages if available dma-buf: dma-heap: Keep track of the heap device struct dma-buf: system_heap: Add a system-uncached heap re-using the system heap drivers/dma-buf/dma-heap.c | 33 +- drivers/dma-buf/heaps/Makefile | 1 - drivers/dma-buf/heaps/cma_heap.c | 324 +++++++++++++++--- drivers/dma-buf/heaps/heap-helpers.c | 270 --------------- drivers/dma-buf/heaps/heap-helpers.h | 53 --- drivers/dma-buf/heaps/system_heap.c | 494 ++++++++++++++++++++++++--- include/linux/dma-heap.h | 9 + 7 files changed, 753 insertions(+), 431 deletions(-) delete mode 100644 drivers/dma-buf/heaps/heap-helpers.c delete mode 100644 drivers/dma-buf/heaps/heap-helpers.h -- 2.17.1