From patchwork Tue Oct 8 13:20:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 175493 Delivered-To: patches@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp5695203ill; Tue, 8 Oct 2019 06:20:58 -0700 (PDT) X-Received: by 2002:a1c:444:: with SMTP id 65mr3780781wme.73.1570540858365; Tue, 08 Oct 2019 06:20:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570540858; cv=none; d=google.com; s=arc-20160816; b=x2oDMJgDXuhEHaJALRag0QxRR7cWQz3ihQ0c93JGLRTnmTij718elFPoQ/2ATLRouc R90QEWOhA7YhnxTF4TdMBltF20b+iI6P2fGiv9O/SVvsj2lCZCb5a3/t4oBMBN/HMc2P AGK+Hj2YI6lanM/1HCpmUnxVbbfZw1tP7PW7IoSWXOtPWVFrTWKmq65dZ0s6WoO5+ot3 InoMSTlKx7sIhptml6jMCeaGk+HtpdvdbpvFHh5Zwy3xpQz5No2rQalY8C/fOjt1LYUZ oDxk1j/pkzH+psG+1WXpfG9oPG3W9rojtWTI2y5mCX2U2O8cWZZqLbGarGzgKGvKLUbo fZ3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=6RWTxHt7zKzXfYPhwl9vO4EuXYxc6AyULIB2uI0LmfM=; b=LlzqmMKLmRjigr1oUpCuhWFM7gPK/VE48fek/xmkWi0hRu2PfgzcyeIkmFavo+9+OK WENdkecKZykY+YgvLcvwwp+SuWrF7Vug0uLDne+X2E+klb7Oi2hUxM9bDUezjC9DJ+5z COBkXlShVVTCtz3fWgPO1EG1wY5oNRJHMwRB7x6tXPgMyssarE1mPGHlLm8UmStSohNl 2OSMPi9nLSO8zW1trvLi8J+T12mt1UAVtuly3RWZGOnsYOqZhtIIaa5iA7GTsqxysxrJ UUvA9v5V9sHXpFEM+dRN+FvqbgoQx/6pW8Ba+5xCp77sic8ojWBSBpc898MQXFrNTu2U dizg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cNq1Ed5G; spf=pass (google.com: domain of daniel.thompson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=daniel.thompson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id q8sor11152330wrv.54.2019.10.08.06.20.58 for (Google Transport Security); Tue, 08 Oct 2019 06:20:58 -0700 (PDT) Received-SPF: pass (google.com: domain of daniel.thompson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cNq1Ed5G; spf=pass (google.com: domain of daniel.thompson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=daniel.thompson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6RWTxHt7zKzXfYPhwl9vO4EuXYxc6AyULIB2uI0LmfM=; b=cNq1Ed5GzasuMH1y9ug9vDcF22n6vlCP/1FO1m7fvDDoOLyWcX78rM8DONBByZA2Zb Gskb17VHPu1a9HWj7EH6TUDdxGVoicMlQ8W4qJXy+KRz5k4fm4PhFv4GHsHPJIQZ0Jqv GP5fDn3k5yyZUj3xjRbO/gO9AhSkqWdcKF8oS8v1uoaZ/BGUMHbum5nXQMcC40RhxHlV w+ByZ3LHXh9535tKnWf0DaHjjJT+4kf2nE6JHLzzUkIjNOrTvmony6bF22PctzqqJVoh vD50IGmZjnoAJS+P767MtqDmVQhDU1LXnjxuuDiKemFKb5wqjt1PLxlzpNFpd6KwOSji f6TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6RWTxHt7zKzXfYPhwl9vO4EuXYxc6AyULIB2uI0LmfM=; b=r3WvweqTROtZKMZ48xXAyhRuN/o6CQ9/PmP4G2yPSC1kqa1uzH8PpDKaWBL3FKxiRR /A4UzKqBGOk0CZ58uCLNmDtaA0deAekCC3uw/vups+lG2UkXkO7rhcuqYW2KafV127V5 41MvaCnuLcHqynWGC03HdLvIjx871u4hGiGV3vIj6m9dsFf2fxW6lLnNAwJvEKlgl1cC jhflsTJx/LfRbIeSYQgNt+yvG3r7ocoKiv+iB3fzNvhydj8qapG27cb1u/AaHMGlVvqp UhBNkzi4nb28IBD8DIZElET1f62A3E6WnD7Gzv2iWusFMqo5CTHUQ0OCAd+7IixPcXE/ Hrfg== X-Gm-Message-State: APjAAAWMeq8wfJ7ga3GyFTFo1aXWp/dr+3Wbg7wk6snXYV67pG1fX6YA 465ZwoGNdw8deDyUWc+KjgCArDrmUybTIJnN X-Google-Smtp-Source: APXvYqyCXe2mCxlJgegBeQiMsMW/DceUIxnKsxEr5RLMHNcvj7L1A4ab4Pzav+WZ/SrQVlRdEVrk/g== X-Received: by 2002:a05:6000:1204:: with SMTP id e4mr20944912wrx.5.1570540857894; Tue, 08 Oct 2019 06:20:57 -0700 (PDT) Return-Path: Received: from wychelm.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id t8sm18237214wrx.76.2019.10.08.06.20.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 06:20:57 -0700 (PDT) From: Daniel Thompson To: Jason Wessel , Douglas Anderson Cc: Daniel Thompson , kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org, patches@linaro.org Subject: [PATCH v2 0/5] kdb: Cleanup code to read user input and handle escape sequences Date: Tue, 8 Oct 2019 14:20:38 +0100 Message-Id: <20191008132043.7966-1-daniel.thompson@linaro.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 I've been meaning to repost this for some time, and inspired by having someone keen to review it, I dug it out again! I split this as carefully as I could into small pieces but the original code was complex so even in small bits it doesn't make for light reading. Things do make more sense once you realize/remember that escape_delay is a count down timer that expires the escape sequences! Most of the patches are simple tidy ups although patches 4 and 5 introduce new behaviours. Patch 4 shouldn't be controversial but perhaps patch 5 is (although hopefully not ;-) ). Mostly this is auto tested, see here: https://github.com/daniel-thompson/kgdbtest/commit/c65e28d99357c2df6dac2cebe195574e634d04dc Changes in v2: - Improve comment in patch 4 to better describe what is happening - Rebase on v5.4-rc2 Daniel Thompson (5): kdb: Tidy up code to handle escape sequences kdb: Simplify code to fetch characters from console kdb: Remove special case logic from kdb_read() kdb: Improve handling of characters from different input sources kdb: Tweak escape handling for vi users kernel/debug/kdb/kdb_io.c | 222 ++++++++++++++++++-------------------- 1 file changed, 103 insertions(+), 119 deletions(-) -- 2.21.0