| Message ID | 20190814184702.54275-1-john.stultz@linaro.org |
|---|---|
| Headers | show |
| Series | drm: Kirin driver cleanups to prep for Kirin960 support | expand |
On 2019/8/15 3:45, Sam Ravnborg wrote: > Hi Xinliang, Rongrong, Xinwei, Chen > > On Wed, Aug 14, 2019 at 06:46:36PM +0000, John Stultz wrote: >> Just wanted to resend this patch set so I didn't have to >> continue carrying it forever to keep the HiKey960 board running. >> >> This patchset contains one fix (in the front, so its easier to >> eventually backport), and a series of changes from YiPing to >> refactor the kirin drm driver so that it can be used on both >> kirin620 based devices (like the original HiKey board) as well >> as kirin960 based devices (like the HiKey960 board). >> >> The full kirin960 drm support is still being refactored, but as >> this base kirin rework was getting to be substantial, I wanted >> to send out the first chunk, so that the review burden wasn't >> overwhelming. > As Maintainers can we please get some feedback from one of you. > Just an "OK to commit" would do it. > But preferably an ack or a review on the individual patches. Hi sam, So sorry for responding late. As I have done a pre-review and talked with the author before sending out the patches. So, for this serial patches, Acked-by: Xinliang Liu <z.liuxinliang@hisilicon.com> > > If the reality is that John is the Maintainer today, > then we should update MAINTAINERS to reflect this. I am assuming you are talking about the kirin[1] drm driver not the hibmc[2] one, right? I really appreciate John's awesome work at kirin drm driver all the way. Honestly, after my work change from mobile to server years ago, I am always waiting for some guy who is stably working at kirin drm driver to take the maintenance work. John, surely is a such guy. Please add up a patch to update the maintainer as John, if John agree so. Then John can push the patch set to drm maintainer himself. *Note* that the maintainer patch should break hisilicon drivers into kirin and hibmc two parts, like bellow: DRM DRIVERS FOR HISILICON HIBMC M: Xinliang Liu <z.liuxinliang@hisilicon.com> ... F: drivers/gpu/drm/hisilicon/hibmc ... DRM DRIVERS FOR HISILICON KIRIN M: John Stultz <john.stultz@linaro.org> ... F: drivers/gpu/drm/hisilicon/kirin ... [1] drivers/gpu/drm/hisilicon/kirin # for kirin mobile display driver [2] drivers/gpu/drm/hisilicon/hibmc # for server VGA driver Thanks, Xinliang > > Thanks! > > Sam > > . >
Hi Xinliang > > As Maintainers can we please get some feedback from one of you. > > Just an "OK to commit" would do it. > > But preferably an ack or a review on the individual patches. > > As I have done a pre-review and talked with the author before sending out > the patches. > So, for this serial patches, > Acked-by: Xinliang Liu <z.liuxinliang@hisilicon.com> Thanks! We all know how it is to be busy, especially when trying to keep up after role changes. Unless someone beats me, then I will apply tonight or tomorrow. > > If the reality is that John is the Maintainer today, > > then we should update MAINTAINERS to reflect this. > > I am assuming you are talking about the kirin[1] drm driver not the hibmc[2] > one, right? > I really appreciate John's awesome work at kirin drm driver all the way. > Honestly, after my work change from mobile to server years ago, I am always > waiting for some guy who is stably working at kirin drm driver to take the > maintenance work. > John, surely is a such guy. Please add up a patch to update the maintainer > as John, if John agree so. Then John can push the patch set to drm > maintainer himself. > *Note* that the maintainer patch should break hisilicon drivers into kirin > and hibmc two parts, like bellow: > > DRM DRIVERS FOR HISILICON HIBMC > M: Xinliang Liu <z.liuxinliang@hisilicon.com> > ... > F: drivers/gpu/drm/hisilicon/hibmc > ... > > DRM DRIVERS FOR HISILICON KIRIN > M: John Stultz <john.stultz@linaro.org> > ... > F: drivers/gpu/drm/hisilicon/kirin > ... > > [1] drivers/gpu/drm/hisilicon/kirin # for kirin mobile display driver > [2] drivers/gpu/drm/hisilicon/hibmc # for server VGA driver Hi John Up to the challenge? If yes then please consider to apply for commit rights to drm-misc-next. And read: https://drm.pages.freedesktop.org/maintainer-tools/index.html See this to get an account: https://www.freedesktop.org/wiki/AccountRequests/ You will need an ssh account for drm-misc-next as it is not (yet?) gitlab enabled. Sam
On Sun, Aug 18, 2019 at 9:40 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > > As Maintainers can we please get some feedback from one of you. > > > Just an "OK to commit" would do it. > > > But preferably an ack or a review on the individual patches. > > > > As I have done a pre-review and talked with the author before sending out > > the patches. > > So, for this serial patches, > > Acked-by: Xinliang Liu <z.liuxinliang@hisilicon.com> > > Thanks! > We all know how it is to be busy, especially when trying to keep up > after role changes. > Unless someone beats me, then I will apply tonight or tomorrow. > > > > If the reality is that John is the Maintainer today, > > > then we should update MAINTAINERS to reflect this. > > > > I am assuming you are talking about the kirin[1] drm driver not the hibmc[2] > > one, right? > > I really appreciate John's awesome work at kirin drm driver all the way. > > Honestly, after my work change from mobile to server years ago, I am always > > waiting for some guy who is stably working at kirin drm driver to take the > > maintenance work. > > John, surely is a such guy. Please add up a patch to update the maintainer > > as John, if John agree so. Then John can push the patch set to drm > > maintainer himself. > > *Note* that the maintainer patch should break hisilicon drivers into kirin > > and hibmc two parts, like bellow: > > > > DRM DRIVERS FOR HISILICON HIBMC > > M: Xinliang Liu <z.liuxinliang@hisilicon.com> > > ... > > F: drivers/gpu/drm/hisilicon/hibmc > > ... > > > > DRM DRIVERS FOR HISILICON KIRIN > > M: John Stultz <john.stultz@linaro.org> > > ... > > F: drivers/gpu/drm/hisilicon/kirin > > ... > > > > [1] drivers/gpu/drm/hisilicon/kirin # for kirin mobile display driver > > [2] drivers/gpu/drm/hisilicon/hibmc # for server VGA driver > > Hi John > > Up to the challenge? I guess if necessary, though I don't believe myself to be a great maintainer. Though I do have the hardware, am regularly are testing on it, and maintain a tree of patches to keep it working, so I can validate basic correctness and handle patch wrangling. > If yes then please consider to apply for commit rights to drm-misc-next. > > And read: > https://drm.pages.freedesktop.org/maintainer-tools/index.html > > See this to get an account: > https://www.freedesktop.org/wiki/AccountRequests/ > > You will need an ssh account for drm-misc-next as it is not (yet?) > gitlab enabled. I'll try to find some time to read through the above and apply. thanks -john
Just wanted to resend this patch set so I didn't have to continue carrying it forever to keep the HiKey960 board running. This patchset contains one fix (in the front, so its easier to eventually backport), and a series of changes from YiPing to refactor the kirin drm driver so that it can be used on both kirin620 based devices (like the original HiKey board) as well as kirin960 based devices (like the HiKey960 board). The full kirin960 drm support is still being refactored, but as this base kirin rework was getting to be substantial, I wanted to send out the first chunk, so that the review burden wasn't overwhelming. The full HiKey960 patch stack can be found here: https://git.linaro.org/people/john.stultz/android-dev.git/log/?h=dev/hikey960-mainline-WIP thanks -john Cc: Rongrong Zou <zourongrong@gmail.com> Cc: Xinliang Liu <z.liuxinliang@hisilicon.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel <dri-devel@lists.freedesktop.org> Cc: Sam Ravnborg <sam@ravnborg.org> Da Lv (1): drm: kirin: Fix for hikey620 display offset problem John Stultz (4): drm: kirin: Get rid of drmP.h includes drm: kirin: Remove HISI_KIRIN_DW_DSI config option drm: kirin: Remove unreachable return drm: kirin: Move workqueue to ade_hw_ctx structure Xu YiPing (21): drm: kirin: Remove uncessary parameter indirection drm: kirin: Remove out_format from ade_crtc drm: kirin: Rename ade_plane to kirin_plane drm: kirin: Rename ade_crtc to kirin_crtc drm: kirin: Dynamically allocate the hw_ctx drm: kirin: Move request irq handle in ade hw ctx alloc drm: kirin: Move kirin_crtc, kirin_plane, kirin_format to kirin_drm_drv.h drm: kirin: Reanme dc_ops to kirin_drm_data drm: kirin: Move ade crtc/plane help functions to driver_data drm: kirin: Move channel formats to driver data drm: kirin: Move mode config function to driver_data drm: kirin: Move plane number and primay plane in driver data drm: kirin: Move config max_width and max_height to driver data drm: kirin: Move drm driver to driver data drm: kirin: Add register connect helper functions in drm init drm: kirin: Rename plane_init and crtc_init drm: kirin: Fix dev->driver_data setting drm: kirin: Make driver_data variable non-global drm: kirin: Add alloc_hw_ctx/clean_hw_ctx ops in driver data drm: kirin: Pass driver data to crtc init and plane init drm: kirin: Move ade drm init to kirin drm drv drivers/gpu/drm/hisilicon/kirin/Kconfig | 10 +- drivers/gpu/drm/hisilicon/kirin/Makefile | 4 +- .../gpu/drm/hisilicon/kirin/kirin_ade_reg.h | 1 + .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 360 +++++++----------- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 257 +++++++++---- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.h | 48 ++- 6 files changed, 379 insertions(+), 301 deletions(-) -- 2.17.1