mbox series

[v2,0/5] usb: xhci: Add support for Renesas USB controllers

Message ID 20190621085913.8722-1-vkoul@kernel.org
Headers show
Series usb: xhci: Add support for Renesas USB controllers | expand

Message

Vinod Koul June 21, 2019, 8:59 a.m. UTC 
This series add support for Renesas USB controllers uPD720201 and uPD720202.
These require firmware to be loaded and in case devices have ROM those can
also be programmed if empty. If ROM is programmed, it runs from ROM as well.

This includes two patches from Christian which supported these controllers
w/o ROM and later my patches for ROM support and multiple firmware versions.

Changes in v2:
  used macros for timeout count and delay
  removed renesas_fw_alive_check
  cleaned renesas_fw_callback
  removed recurion for renesas_fw_download
  added MODULE_FIRMWARE
  added comment for multiple fw order

Christian Lamparter (2):
  usb: xhci: add firmware loader for uPD720201 and uPD720202 w/o ROM
  usb: xhci: handle uPD720201 and uPD720202 w/o ROM

Vinod Koul (3):
  usb: xhci: Use register defined and field names
  usb: xhci: Add ROM loader for uPD720201
  usb: xhci: allow multiple firmware versions

 drivers/usb/host/xhci-pci.c | 942 ++++++++++++++++++++++++++++++++++++
 1 file changed, 942 insertions(+)

-- 
2.20.1

Comments

Vinod Koul June 23, 2019, 4:33 p.m. UTC | #1 
On 21-06-19, 21:59, Christian Lamparter wrote:
> On Friday, June 21, 2019 10:59:09 AM CEST Vinod Koul wrote:

> > +	/*

> > +	 * The Firmware's Data Format is describe in

> > +	 * "6.3 Data Format" R19UH0078EJ0500 Rev.5.00 page 124

> > +	 */

> > +

> > +	/* "Each row is 8 bytes". => firmware size must be a multiple of 8. */

> > +	if (length % 8 != 0)

> > +		dev_warn(&dev->dev, "firmware size is not a multiple of 8.");

> 

> It doesn't look like this holds true for the newer K2026090.mem which

> arguably fixes a lot of bugs over K2013080.mem. I think we should remove

> this check and message.


The documentation still says so, that is why I changed error return and
this to warning. Yeah lets remove to not confuse folks :)

-- 
~Vinod