From patchwork Thu Jun 20 13:05:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 167325 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp2048517ilk; Thu, 20 Jun 2019 06:06:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqwr+EP8ftF4qgfdEu/FQq/GojidaKIfW1KkYwkmiigQMBYsA4FJNFh+5OK1KBqs5fmP3wxP X-Received: by 2002:a62:1c94:: with SMTP id c142mr1619928pfc.85.1561035986346; Thu, 20 Jun 2019 06:06:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561035986; cv=none; d=google.com; s=arc-20160816; b=HYl3Vj+CORB9dJxnqHnruePJsWk5d4ZCF7kTvUuHJE/cDrP/TRLGRaXc+S4mZwr0AW EWbs/mzvLaqLpc/GQK/QuXjaPV+++Io6G9f5aFy7ieONYXnK17qqs8dKqOm9l9kGDuPA 1Vjxyxp26MOHvkD8sFGN/qEwKpHTTOtnXy14AOPjT+b1W3FahSd5MoF3XIkRNTowbACF sJSrhsx1P0wypq1OVUU11k/ZADFgypK4eeq8YRc5OqechW8MBD9gwasRTmxg1laJMlHO bxgJb9EldEnRDE0GGAAVk+8sTF4W6w5YYoJ9GPVJoL2U0IRS1wJNqQE62RicTzM80+mk widA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=8M4TaFreZl33UH5LR3Pf5pkN6xLPBUe+fTDJQ8hntOw=; b=C09NfbfnWqgmY+tTk/X9BiLdSRlw+Oa+26gVdleNoDg2WGcqu4qz5vetEnfytTXMrs MU7/bfwU3clj4lKQZ4KZd748AqmNsHaxwO+zD4T/i7d69g8AmKBMm6ZhGS4lVt8xgT0C QWNQALbH0rmKG9PJ+eEynnf0RTu/8WD0+Rq4vYBSGRuzPG217CT8swFoOd56rWWMAJvS cB3JEdagz2DLx3LH5DnbLJxx8+ychFnmqBj5XB3AKYqttKkHrah+DeRIJMa8oTiigb/e k9I3mAibhhozl8UHotyMQleNq8KVYtNZEl6UUWlWFOCVbuHrLFGr3IvmcV316dyYsnSG nI5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f2si5770547pgk.92.2019.06.20.06.06.26; Thu, 20 Jun 2019 06:06:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731937AbfFTNGY (ORCPT + 30 others); Thu, 20 Jun 2019 09:06:24 -0400 Received: from foss.arm.com ([217.140.110.172]:36712 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731733AbfFTNGX (ORCPT ); Thu, 20 Jun 2019 09:06:23 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EC969360; Thu, 20 Jun 2019 06:06:22 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7BB733F718; Thu, 20 Jun 2019 06:06:21 -0700 (PDT) From: Julien Grall To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Cc: james.morse@arm.com, marc.zyngier@arm.com, julien.thierry@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, Julien Grall , Russell King Subject: [RFC v2 00/14] kvm/arm: Align the VMID allocation with the arm64 ASID one Date: Thu, 20 Jun 2019 14:05:54 +0100 Message-Id: <20190620130608.17230-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, This patch series is moving out the ASID allocator in a separate file in order to re-use it for the VMID. The benefits are: - CPUs are not forced to exit on a roll-over. - Context invalidation is now per-CPU rather than broadcasted. There are no performance regression on the fastpath for ASID allocation. Actually on the hackbench measurement (300 hackbench) it was .7% faster. The measurement was made on a Seattle based SoC (8 CPUs), with the number of VMID limited to 4-bit. The test involves running concurrently 40 guests with 2 vCPUs. Each guest will then execute hackbench 5 times before exiting. The performance difference (on 5.1-rc1) between the current algo and the new one are: - 2.5% less exit from the guest - 22.4% more flush, although they are now local rather than broadcasted - 0.11% faster (just for the record) The ASID allocator rework to make it generic has been divided in multiple patches to make the review easier. Compare to the first RFC, Arm is not duplicated most of the code anymore. Instead, Arm will build the version from Arm64. A branch with the patch based on 5.2-rc5 can be found: http://xenbits.xen.org/gitweb/?p=people/julieng/linux-arm.git;a=shortlog;h=refs/heads/vmid-rework/rfc-v2 Best regards, Cc: Russell King Julien Grall (14): arm64/mm: Introduce asid_info structure and move asid_generation/asid_map to it arm64/mm: Move active_asids and reserved_asids to asid_info arm64/mm: Move bits to asid_info arm64/mm: Move the variable lock and tlb_flush_pending to asid_info arm64/mm: Remove dependency on MM in new_context arm64/mm: Store the number of asid allocated per context arm64/mm: Introduce NUM_ASIDS arm64/mm: Split asid_inits in 2 parts arm64/mm: Split the function check_and_switch_context in 3 parts arm64/mm: Introduce a callback to flush the local context arm64: Move the ASID allocator code in a separate file arm64/lib: asid: Allow user to update the context under the lock arm/kvm: Introduce a new VMID allocator kvm/arm: Align the VMID allocation with the arm64 ASID one arch/arm/include/asm/kvm_asm.h | 2 +- arch/arm/include/asm/kvm_host.h | 5 +- arch/arm/include/asm/kvm_hyp.h | 1 + arch/arm/include/asm/lib_asid.h | 81 +++++++++++++++ arch/arm/kvm/Makefile | 1 + arch/arm/kvm/hyp/tlb.c | 8 +- arch/arm64/include/asm/kvm_asid.h | 8 ++ arch/arm64/include/asm/kvm_asm.h | 2 +- arch/arm64/include/asm/kvm_host.h | 5 +- arch/arm64/include/asm/lib_asid.h | 81 +++++++++++++++ arch/arm64/kvm/hyp/tlb.c | 10 +- arch/arm64/lib/Makefile | 2 + arch/arm64/lib/asid.c | 191 +++++++++++++++++++++++++++++++++++ arch/arm64/mm/context.c | 205 ++++++-------------------------------- virt/kvm/arm/arm.c | 112 +++++++-------------- 15 files changed, 447 insertions(+), 267 deletions(-) create mode 100644 arch/arm/include/asm/lib_asid.h create mode 100644 arch/arm64/include/asm/kvm_asid.h create mode 100644 arch/arm64/include/asm/lib_asid.h create mode 100644 arch/arm64/lib/asid.c -- 2.11.0