From patchwork Mon Apr 29 09:47:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 163011 Delivered-To: patch@linaro.org Received: by 2002:a92:7e86:0:0:0:0:0 with SMTP id q6csp1665614ill; Mon, 29 Apr 2019 02:48:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxCTRe/xUw7LtK3eOHPNbj+3VTFNNlLCrJ9NCTl97VFpZCLr/C9X0b7aZs3XaamcKsBydmW X-Received: by 2002:a17:902:43a4:: with SMTP id j33mr61360391pld.307.1556531282052; Mon, 29 Apr 2019 02:48:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556531282; cv=none; d=google.com; s=arc-20160816; b=UfRNdYXUXLH70aBAsKPAzkjVEsSmneJFcjFWQbDZB53rAzNIsWNPF2jTIlCpGrSsGV qFKafNVje1rj6gwawGHp/+BRsZZ601gDXZhs2KOnkB4otBs7g2D1fMD2OZrHREOtDPwG d45pLjtwqnNFilZClQX+ANaqDqXWFbuMV0Fvd01b4RZs08llRw5qZt9c2wY4qfVSxrnH 8Vv7IWUbUiI1NCGSX6ek5HGk0RXn6XxkQ1jw0rBYqpcgTUKI/fzsUaXejOjhMLdYPGZJ jzxlOXvBU8DOSOB7SRDlfW/qKd1jm99qoEiNPHfUfe6SGMfGQL9qQFAEHeHbSwkPcOcp CUDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LrkVzYO8i3GpLatsXL6FS/oqta3++wMs7+5LeRy4XK4=; b=MAd/6aD6jz3Peiz4qbJ/OeGIkGdyLlBxpdLsFEEC48YHtsyTAQ8FMQ8i2HcCRiJae9 +UfMsGZbxVKYSPU71eBXUBMHh/JL0CPTC06DTiM2RIjftJdN8Dxrre5FQVxpxz0w5zqd fhtnazcfeZRDWwt5SvmWuVc3HP7M6XWsF2HxVCx4FX5iBQ0k41lxcWo7R5Qymt9yyvIB kwfJaTkOcwbtefhBLx40CQNSAWz9x0FydR6QaQLfQXWRqT87uqSN5m7YsW9KQclaXO9m 0P7ikucAbb9Mmwnc4susUXeLi5lj7kqEQUrNAS18vkwzFXPlwzur3bWZBoRb7ySz7EMd vgWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=ukqWmx3w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n4si31693219plk.297.2019.04.29.02.48.01; Mon, 29 Apr 2019 02:48:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=ukqWmx3w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727724AbfD2JsA (ORCPT + 30 others); Mon, 29 Apr 2019 05:48:00 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:39930 "EHLO mail-wr1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727368AbfD2JsA (ORCPT ); Mon, 29 Apr 2019 05:48:00 -0400 Received: by mail-wr1-f54.google.com with SMTP id a9so15047157wrp.6 for ; Mon, 29 Apr 2019 02:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LrkVzYO8i3GpLatsXL6FS/oqta3++wMs7+5LeRy4XK4=; b=ukqWmx3wk3bwzUUQ1iO/jvjVvsc23IEqfUxqjqDjOfpR0kUF144ve+vgR3s5aGxeh3 k6uyPmHOLatnda/+LtcyvQ8Pr6jtdFGok9hsz9Y+OvxzTt4UejcZWTdPFr6e7/h085Ey Ob5UOdSyjGF2QlfDxl4ZOBTzxz6cwKw8GkH7j8JI7VIy7ZJhycPoMMMkgpM//FPZfnHv vx96uYQOwuO2dLziGjZJGTp3W3dxTeJIb1hiEmF0lPrJmLV9T3ofbq2Wc25CWmyvXoG/ SXBHID4/4JQSFL7qMQU9xOh9b9SmLNWtP/AInD0CHc8QWjJ9G+CtkMq43SPy1PHfNrSd ROfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LrkVzYO8i3GpLatsXL6FS/oqta3++wMs7+5LeRy4XK4=; b=JK35BvTO/YeKpkih5POXQgVS16goMMLB9VgvrXP2Z/+HykZwJ3GA/bvy8/re9ZQbPr 4SXxhC/mTFCzevm+R70RCD1/ybbgDlN/p8qPrloVLXsAYwEetToUkZX6RozJvKkIjiAR 8k+jwDi1lid3bGrNmuq38i2EM1UgYLarYmxBT7scEH9GsDxPlXvekaeoGvKgULivL1bd izwMf2SXJ8y1lT5O0T0ZRY2HffXNqi3aBk67BeLby0efDFvrBwO9KFRqBMhJk4lVRwkf Bkfjj4aHax+637BH0Cc7D1uvRtGNXlzpeCc5CWq71dCYpsEAi07kzTIYqz5x2I5a04xF c78A== X-Gm-Message-State: APjAAAUN5221m/Qi/v05D4zitEuMsQQm9tHQFnxnsfOFEsn1tyL+h9Bi 4qNOwkhsZlS5CMUe3Hz3PjA/Iw== X-Received: by 2002:adf:afd1:: with SMTP id y17mr7767686wrd.125.1556531278695; Mon, 29 Apr 2019 02:47:58 -0700 (PDT) Received: from boomer.local (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id 192sm47987465wme.13.2019.04.29.02.47.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Apr 2019 02:47:57 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood Cc: Jerome Brunet , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patchwork-bot+notify@kernel.org Subject: [PATCH 0/2] ASoC: fix hw_params/hw_free validity checks Date: Mon, 29 Apr 2019 11:47:48 +0200 Message-Id: <20190429094750.1857-1-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While working on a codec, I have found an odd situation. The hw_params callback which was provided by the codec dai was not called as expected. However, the hw_free callback was called, even if hw_params was skipped. After debugging, I found out that the dai was considered invalid because it did not specify any rates, only rate_min and rate_max. That's a first problem. If a codec dai is considered invalid, hw_free should probably not be called either, that's a 2nd issue. This patchset is meant to solve both issues. Jerome Brunet (2): ASoC: fix valid stream condition ASoC: skip hw_free on codec dai for which the stream is invalid sound/soc/soc-pcm.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) -- 2.20.1