From patchwork Thu Mar 21 16:36:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 160799 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp1001670jan; Thu, 21 Mar 2019 09:36:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqwBVcfHxOKduzJTzpmmHxFv11qraUH+ZdkfIevwyc6UbJB4zvZ9QP1ghVsSo21nHqML/M+o X-Received: by 2002:aa7:8d17:: with SMTP id j23mr4193929pfe.62.1553186204576; Thu, 21 Mar 2019 09:36:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553186204; cv=none; d=google.com; s=arc-20160816; b=o2kp2k3uMNhZ/sn0F2pLa3wwiO1DnBGEZilEjKhjgqumKbfrEx4wcfB/hxXDjbsrZW xjKkANhjsSGh4PdZt5zLOQdHi1gaKqX0FkEgPzs4S7Ope+BdzOmhlACzvKiVj0njPQse SQ8bamHVLWeMyn6oT0XYEtJK6M1JAejqCJ35d3J/rqHyWGQJHYme0bbI2iji62BunokS rPysXZlJYq2VbKImH4FGuVjO2jFsUQBNPysErIBhKfZd9Mh7pOStr3B8e+P8arhPeHGx 3E6TMqTa/KJ8LorOeCVOsxhoA/WLz9BAQCd5ICUYGm4bhUcnNo5BIci/ivCkB3p51njG xN1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=s7F38gNELeZQjRW36SYM0cWpVuK5549FrAltIC5kMFI=; b=IxOlYg/o3HaFD1IOZZua6suBZjsLlfj14kjdczxo2nh5/M883xW+YazHgGmAqKXbyu Nhqdp81ih4/hA1aNbWrj4ykOAM+cZjr9ONwAvRCmhniMJJPtdIzoThqFT2J4wRL8xXyG FCGNpjAtAjb9gIgH096FOlRWb1vAnOzVu6jaw3FbRflPZ3gl7Xr4reWLgK1SuxzLbX+R To4Q4vJLIZcvkJfEIdTsyvGYCXLtgqGkqdeB8kyGN5GG0g3BZBXg+Mn2oBxcj2sPkpn0 FKXtnfvKNn9K/vGSkeYoE8j12JUEmF7/jDdDjQZ/bQC0E78NyAMHZQm1RdwxXj3YZULU WbTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d3si4914086pla.399.2019.03.21.09.36.44; Thu, 21 Mar 2019 09:36:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728621AbfCUQgl (ORCPT + 31 others); Thu, 21 Mar 2019 12:36:41 -0400 Received: from foss.arm.com ([217.140.101.70]:59346 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728528AbfCUQgl (ORCPT ); Thu, 21 Mar 2019 12:36:41 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD5D2374; Thu, 21 Mar 2019 09:36:40 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB88D3F614; Thu, 21 Mar 2019 09:36:38 -0700 (PDT) From: Julien Grall To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Cc: christoffer.dall@arm.com, james.morse@arm.com, marc.zyngier@arm.com, julien.thierry@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, Julien Grall Subject: [PATCH RFC 00/14] kvm/arm: Align the VMID allocation with the arm64 ASID one Date: Thu, 21 Mar 2019 16:36:09 +0000 Message-Id: <20190321163623.20219-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series is moving out the ASID allocator in a separate file in order to re-use it for the VMID. The benefits are: - CPUs are not forced to exit a roll-over. - Context invalidation is now per-CPU rather than broadcasted. There are no performance regression on the fastpath for ASID allocation. Actually on the hackbench measurement (300 hackbench) it was .7% faster. The measurement was made on a Seattle based SoC (8 CPUs), with the number of VMID limited to 4-bit. The test involves running concurrently 40 guests with 2 vCPUs. Each guest will then execute hackbench 5 times before exiting. The performance difference between the current algo and the new one are: - 2.5% less exit from the guest - 22.4% more flush, although they are now local rather than broadcasted - 0.11% faster (just for the record) The ASID allocator rework to make it generic has been divided in multiple patches to make the review easier. A branch with the patch based on 5.1-rc1 can be found: http://xenbits.xen.org/gitweb/?p=people/julieng/linux-arm.git;a=shortlog;h=refs/heads/vmid-rework/rfc Cheers, Julien Grall (14): arm64/mm: Introduce asid_info structure and move asid_generation/asid_map to it arm64/mm: Move active_asids and reserved_asids to asid_info arm64/mm: Move bits to asid_info arm64/mm: Move the variable lock and tlb_flush_pending to asid_info arm64/mm: Remove dependency on MM in new_context arm64/mm: Store the number of asid allocated per context arm64/mm: Introduce NUM_ASIDS arm64/mm: Split asid_inits in 2 parts arm64/mm: Split the function check_and_switch_context in 3 parts arm64/mm: Introduce a callback to flush the local context arm64: Move the ASID allocator code in a separate file arm64/lib: asid: Allow user to update the context under the lock arm/kvm: Introduce a new VMID allocator kvm/arm: Align the VMID allocation with the arm64 ASID one arch/arm/include/asm/kvm_asid.h | 81 +++++++++++++++ arch/arm/include/asm/kvm_asm.h | 2 +- arch/arm/include/asm/kvm_host.h | 5 +- arch/arm/include/asm/kvm_hyp.h | 1 + arch/arm/kvm/Makefile | 1 + arch/arm/kvm/asid.c | 191 +++++++++++++++++++++++++++++++++++ arch/arm/kvm/hyp/tlb.c | 8 +- arch/arm64/include/asm/asid.h | 81 +++++++++++++++ arch/arm64/include/asm/kvm_asid.h | 8 ++ arch/arm64/include/asm/kvm_asm.h | 2 +- arch/arm64/include/asm/kvm_host.h | 5 +- arch/arm64/kvm/hyp/tlb.c | 10 +- arch/arm64/lib/Makefile | 2 + arch/arm64/lib/asid.c | 191 +++++++++++++++++++++++++++++++++++ arch/arm64/mm/context.c | 205 ++++++-------------------------------- virt/kvm/arm/arm.c | 112 +++++++-------------- 16 files changed, 638 insertions(+), 267 deletions(-) create mode 100644 arch/arm/include/asm/kvm_asid.h create mode 100644 arch/arm/kvm/asid.c create mode 100644 arch/arm64/include/asm/asid.h create mode 100644 arch/arm64/include/asm/kvm_asid.h create mode 100644 arch/arm64/lib/asid.c -- 2.11.0