From patchwork Fri Jan 18 11:52:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 155920 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3163565jaa; Fri, 18 Jan 2019 03:52:37 -0800 (PST) X-Google-Smtp-Source: ALg8bN76EtQ3sbwi/UoPN9wUCZNineH1Ktm5LQ77tx6PgiZ0myZh98qFC+QWlXeaS86tS+C4IfCm X-Received: by 2002:a63:e915:: with SMTP id i21mr17057923pgh.409.1547812357711; Fri, 18 Jan 2019 03:52:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547812357; cv=none; d=google.com; s=arc-20160816; b=c1klPanxlWdvOQsSjCQFXgLmiAwpWQlDTw36BHbkWoFOmpKBPHgf/7SHzGy2KUD0XE h3yF4hmBEXgjgPELg2oxVT0pPDF4kzOcwxH4f7D8TWguZP+q6zqKYxFT4qZQGkj+5v4e RMYdRm0cMKD0w6e88hh9aNYtSdrfoS7D45UyF78oyGO0t9oua+04ZLnxiRNzLJXVG8Zp JV+mX112ECDM/LeCjF+HBtTibmGDi2F1mPGbu0J+73VX/V1C6r51QBdGEnvIbJ0iyJD7 Ehd8si9AFMydsiBntujN8dTj64f9zJobPYEaGCiG+2DkW1cVUFqPNOOh/87F7jdvcjYo ufuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=AeMLuAiaL8DBaAYq8DMslzU3bn8IjC2Xka68ZCyd56E=; b=eRxyYUCqcLxdboUiIuthE1e48Xjtidm0M1PrIwSvQavhAoNR914z3jqYCNWIgSLGbC WYyclN/Ieg9vYmrPRKWnTV0Z0kHBVxIRo0hbbiTGb+KmHtNvqflq48m4EGAWnVfiXrhq HBc7w1OnqUR/B0awwWfW04z2XeyVgerkroyhWs+vUzu35ovDB9eaeMexv9cD6X5w80sp jAcka6hacp8Vk0fs8LRdwCFzGYwHjFY4JPCUbV5cDpiCBDXZ9GMk1v/8kdJQ9d4sA9Nu DXRPAH8/8zINxFLBpm+zAHP88Znp3AdUraT5aT+iFnsTfsY2hRUX3OkWjZsSXQnuE9tZ /1Tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ih8IquNq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y12si4270738plk.174.2019.01.18.03.52.37; Fri, 18 Jan 2019 03:52:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ih8IquNq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727404AbfARLwf (ORCPT + 13 others); Fri, 18 Jan 2019 06:52:35 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:55307 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727212AbfARLwe (ORCPT ); Fri, 18 Jan 2019 06:52:34 -0500 Received: by mail-wm1-f66.google.com with SMTP id y139so4202046wmc.5 for ; Fri, 18 Jan 2019 03:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AeMLuAiaL8DBaAYq8DMslzU3bn8IjC2Xka68ZCyd56E=; b=ih8IquNqAfrk14DWOz2OiY2RQ6AwwLSixsLYzimOXxuUU0W1g7BSZ46Fm0txNIdtjv tANtbBOF892wJwzfxNpkYPVQXKD1aRpsf16PMIWI7iCm8+8AsPDf5+Nd8SxkWb0HPDop 5niSZjviopzAJBGLVaYbMi4L43WNaHnrIIinM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AeMLuAiaL8DBaAYq8DMslzU3bn8IjC2Xka68ZCyd56E=; b=B26zw4jT06sneulZTLMnisVGGUAgb/WV6kNIEvbRBAzULWGc2S70ybKT2iXc0KMHiv ArkAxqskZxqek8n+o3dyM71LINemcxVafe459Vxod2K6A/TAvXdRDFWjHEhmX4AZvaeX G0EM3gZrcZIaSZk0L2nBz2MAO9r5JnknlJ7Faeo4Y6Yamx1cDwN4wx/EozdzjqGi9hHi x9uYrvOM/7181S1k1F16HhsVPPHtgi5fP1MOZhDIJN0KJnFJSV4haJ7Pkv+LpPZoE1LC KlYf1UD+DpWK5FjGBs7kAxwCJjbPqO89l4xIUexAeZAWUUPfj/jXNiX2AlXx4y6qfssr 8oMA== X-Gm-Message-State: AJcUukerrAqUETVty1lX92KLspiH6jFszovZlwiN4AvL5lmBXnRYMqVW R8guHH+zSMoKRsTlZr+tERDO/g== X-Received: by 2002:a1c:7616:: with SMTP id r22mr15426157wmc.35.1547812353086; Fri, 18 Jan 2019 03:52:33 -0800 (PST) Received: from localhost.localdomain (146-241-71-93.dyn.eolo.it. [146.241.71.93]) by smtp.gmail.com with ESMTPSA id i13sm75183049wrw.32.2019.01.18.03.52.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 03:52:32 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, broonie@kernel.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, hurikhan77+bko@gmail.com, Paolo Valente Subject: [PATCH BUGFIX RFC 0/2] reverting two commits causing freezes Date: Fri, 18 Jan 2019 12:52:17 +0100 Message-Id: <20190118115219.63576-1-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jens, a user reported a warning, followed by freezes, in case he increases nr_requests to more than 64 [1]. After reproducing the issues, I reverted the commit f0635b8a416e ("bfq: calculate shallow depths at init time"), plus the related commit bd7d4ef6a4c9 ("bfq-iosched: remove unused variable"). The problem went away. Maybe the assumption in commit f0635b8a416e ("bfq: calculate shallow depths at init time") does not hold true? Thanks, Paolo [1] https://bugzilla.kernel.org/show_bug.cgi?id=200813 Paolo Valente (2): Revert "bfq-iosched: remove unused variable" Revert "bfq: calculate shallow depths at init time" block/bfq-iosched.c | 116 ++++++++++++++++++++++---------------------- block/bfq-iosched.h | 6 +++ 2 files changed, 63 insertions(+), 59 deletions(-) -- 2.20.1