mbox series

[net-next,00/10] Cleanups, minor additions & fixes for HNS3 driver

Message ID 20180926182840.28392-1-salil.mehta@huawei.com
Headers show
Series Cleanups, minor additions & fixes for HNS3 driver | expand

Message

Salil Mehta Sept. 26, 2018, 6:28 p.m. UTC 
This patch-set contains cleans-ups, minor changes and fixes to the HNS3 driver.

Fuyun Liang (4):
  net: hns3: Set extra mac address of pause param for HW
  net: hns3: Rename loop mode
  net: hns3: Rename mac loopback to app loopback
  net: hns3: Add serdes parallel inner loopback support

Huazhong Tan (3):
  net: hns3: Change return type of hclge_tm_schd_info_update()
  net: hns3: Modify hns3_get_max_available_channels
  net: hns3: Fix loss of coal configuration while doing reset

Peng Li (1):
  net: hns3: Add support for sctp checksum offload

Yunsheng Lin (2):
  net: hns3: Fix for packet buffer setting bug
  net: hns3: Fix for netdev not up problem when setting mtu

 drivers/net/ethernet/hisilicon/hns3/hnae3.h        |  16 ++--
 drivers/net/ethernet/hisilicon/hns3/hns3_enet.c    | 101 ++++++++++-----------
 drivers/net/ethernet/hisilicon/hns3/hns3_enet.h    |   2 +
 drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c |  24 +++--
 .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h |   1 +
 .../net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c |   8 +-
 .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c    |  94 ++++++++++++-------
 .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c  |  10 +-
 .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.h  |   6 +-
 .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c  |   4 +-
 10 files changed, 157 insertions(+), 109 deletions(-)

-- 
2.7.4

Comments

David Miller Sept. 28, 2018, 5:38 p.m. UTC | #1 
From: Salil Mehta <salil.mehta@huawei.com>

Date: Wed, 26 Sep 2018 19:28:30 +0100

> This patch-set contains cleans-ups, minor changes and fixes to the HNS3 driver.


Series applied, thank you.
Eric Dumazet Sept. 28, 2018, 6:56 p.m. UTC | #2 
On 09/28/2018 10:38 AM, David Miller wrote:
> From: Salil Mehta <salil.mehta@huawei.com>

> Date: Wed, 26 Sep 2018 19:28:30 +0100

> 

>> This patch-set contains cleans-ups, minor changes and fixes to the HNS3 driver.

> 

> Series applied, thank you.

> 


Something seems wrong

# git grep -n HNS3_SELF_TEST_TYPE_NUM
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278: int st_param[HNS3_SELF_TEST_TYPE_NUM][2];
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:316: for (i = 0; i < HNS3_SELF_TEST_TYPE_NUM; i++) {

drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c: In function 'hns3_self_test':
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:15: error: 'HNS3_SELF_TEST_TYPE_NUM' undeclared (first use in this function)
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:15: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:6: error: unused variable 'st_param' [-Werror=unused-variable]
Salil Mehta Sept. 29, 2018, 3:09 p.m. UTC | #3 
Hi David/Eric,
I missed to include a patch during a patch-set submission which caused some build errors. 
I have fixed that in V2 version of this patch-set. 

The only change between V1-->V2 is in patch:
 "hns3: Add serdes parallel inner  loopback support"

This also fixes the spelling mistake identified by David and error shown
by Eric Dumazet.

Sorry for any in convenience caused.

Thanks & regards
Salil
> -----Original Message-----

> From: Eric Dumazet [mailto:eric.dumazet@gmail.com]

> Sent: Friday, September 28, 2018 7:56 PM

> To: David Miller <davem@davemloft.net>; Salil Mehta

> <salil.mehta@huawei.com>

> Cc: Zhuangyuzeng (Yisen) <yisen.zhuang@huawei.com>; lipeng (Y)

> <lipeng321@huawei.com>; mehta.salil@opnsrc.net; netdev@vger.kernel.org;

> linux-kernel@vger.kernel.org; Linuxarm <linuxarm@huawei.com>

> Subject: Re: [PATCH net-next 00/10] Cleanups, minor additions & fixes

> for HNS3 driver

> 

> 

> 

> On 09/28/2018 10:38 AM, David Miller wrote:

> > From: Salil Mehta <salil.mehta@huawei.com>

> > Date: Wed, 26 Sep 2018 19:28:30 +0100

> >

> >> This patch-set contains cleans-ups, minor changes and fixes to the

> HNS3 driver.

> >

> > Series applied, thank you.

> >

> 

> Something seems wrong

> 

> # git grep -n HNS3_SELF_TEST_TYPE_NUM

> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278: int

> st_param[HNS3_SELF_TEST_TYPE_NUM][2];

> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:316: for (i = 0; i <

> HNS3_SELF_TEST_TYPE_NUM; i++) {

> 

> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c: In function

> 'hns3_self_test':

> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:15: error:

> 'HNS3_SELF_TEST_TYPE_NUM' undeclared (first use in this function)

> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:15: note: each

> undeclared identifier is reported only once for each function it

> appears in

> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:6: error: unused

> variable 'st_param' [-Werror=unused-variable]