From patchwork Mon Jul 23 01:57:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AKASHI Takahiro X-Patchwork-Id: 142525 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp5522355ljj; Sun, 22 Jul 2018 18:59:04 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeugXD8CODC25fUvdp1z29S/nf1DrO/5SJSeZAxfWLaoEFqFDn05PWJhvIhbIFB6MqU7lhe X-Received: by 2002:a65:6292:: with SMTP id f18-v6mr10346520pgv.85.1532311144211; Sun, 22 Jul 2018 18:59:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532311144; cv=none; d=google.com; s=arc-20160816; b=eOIf/aoB6MVEfm6khM6FMuJp6DrGDUw4MyYP5ALGzSxo0itX9MJXod4Cn/FpVMSClM hsTQm78k7eBmGhmZ84b+2WBzGfbVdprdAy23kYfTngQ3zW2AF+PQPDSx8R4msODM6PJt rRBUk4SeyamH3qDBNVksR112GziIDbFEdCl/I6lnmPg8eQ1FzR/zawNeMfWMSQOpDKyO Y9kaoK+KstEEXp2ht4yj1KvB8BYFWilXfbXRtGtiIlqYXfYSWOu0oMYEo5XtH/bVjICV 2f01iuTj9/a6C5fjbtnPxUEUgdzmy6y8tWiUukU8KGiI68SN5HHWgjdR7XQ7iIXwphDP o/Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=aQ5nNiDR2NMeUvnpStbd7qXhG/8pAoljy1wl8r3yD+E=; b=pZvZG5I/ktrVvt2PawsK6o+oS2K8hyBgmvNk0FfPZGWgJIM0mKnIvbKrH6+wCQU9S9 Bu2ra0fOm2EDn7aHxf5lTwsmPIQ9THN162DJWnv7WQJJxH1Da2Ik+7armivnreBdA9fR /Xk4nQeAfeLw7Bul09epEj23jTQPDqEstBPai0foMdQ+/Pwm1iNTdyfbKt0rsBnF3bmO p+v+FCRnHSudGt+FTs9+MSGW1JiKaGGHvxszkq1jcGVI0ceOg/dU5IN93OKMmky2ylVT 0CqDXVm9can49925KNjKZSgnQpOCSrRQlURM3xBrWZXSrR6sAwHF0YYzKQKSRFGygY8T TDPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OmqliB2u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e14-v6si5826466pgj.413.2018.07.22.18.59.03; Sun, 22 Jul 2018 18:59:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OmqliB2u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731259AbeGWC5r (ORCPT + 31 others); Sun, 22 Jul 2018 22:57:47 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:36821 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731059AbeGWC5r (ORCPT ); Sun, 22 Jul 2018 22:57:47 -0400 Received: by mail-pg1-f194.google.com with SMTP id s7-v6so7621773pgv.3 for ; Sun, 22 Jul 2018 18:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=aQ5nNiDR2NMeUvnpStbd7qXhG/8pAoljy1wl8r3yD+E=; b=OmqliB2uDJ3jxMPiIEurbLWu+GE4eDctEuWfSDq21m8Bc++xSDvE/dIAgeQNh86ghF qDw8wG32XGYYbAR+uZWrkti9NvhDl9OLZ7lMy+lOHQhjYwYpO/Fi4Il7I9CAJXj05vG9 A3r57+0CMAO7mYKxx0TCINFxCdDIt96dv+OcI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aQ5nNiDR2NMeUvnpStbd7qXhG/8pAoljy1wl8r3yD+E=; b=Hof09nq1m/6UoxOzvhodTmITLBiRifwZdSF2obw074D53xFifY15w2i8qo+WVE08do XwVnralz9oHYqvwxeJ0Y4sVRNKb9H8zu876IY3oi2CsEJKrmOCemsE2dBEevOxcGVqXQ gpC+n+vYk10Sz1PBQhT2+z93P6oV/r0YWcUK+uhBRPZM3bNsc7yukcRJRESqQUeUijq/ RXE+5QIBXzDdJ6MINN/rmWRc1UOAbzMkJeB8YvkARCK3E1zP72HE0icDNLEk3tlV3aZQ qwkJv8DOKHL3AY+Ogdz/tvoQoul//AoN/b5bD7dXhZeXUD19hZRicjfCn5cmrxIYTvIg EDow== X-Gm-Message-State: AOUpUlGPpEP766fTwHqQ7KI8yaa4+7vngVqADE+qnHLy3/LmenZlbxi0 FQZGnHAbBI3hvgSn46c7Y9oLXA== X-Received: by 2002:a65:6411:: with SMTP id a17-v6mr10217732pgv.287.1532311140241; Sun, 22 Jul 2018 18:59:00 -0700 (PDT) Received: from linaro.org ([121.95.100.191]) by smtp.googlemail.com with ESMTPSA id q5-v6sm7962227pgv.61.2018.07.22.18.58.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Jul 2018 18:58:59 -0700 (PDT) From: AKASHI Takahiro To: catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, lenb@kernel.org, ard.biesheuvel@linaro.org Cc: tbaicar@codeaurora.org, bhsharma@redhat.com, dyoung@redhat.com, james.morse@arm.com, mark.rutland@arm.com, al.stone@linaro.org, graeme.gregory@linaro.org, hanjun.guo@linaro.org, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, AKASHI Takahiro Subject: [PATCH v4 0/5] arm64: kexec, kdump: fix boot failures on acpi-only system Date: Mon, 23 Jul 2018 10:57:27 +0900 Message-Id: <20180723015732.24252-1-takahiro.akashi@linaro.org> X-Mailer: git-send-email 2.18.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series is a set of bug fixes to address kexec/kdump failures which are sometimes observed on ACPI-only system and reported in LAK-ML before. In short, the phenomena are: 1. kexec'ed kernel can fail to boot because some ACPI table is corrupted by a new kernel (or other data) being loaded into System RAM. Currently kexec may possibly allocate space ignoring such "reserved" regions. We will see no messages after "Bye!" 2. crash dump (kdump) kernel can fail to boot and get into panic due to an alignment fault when accessing ACPI tables. This can happen because those tables are not always properly aligned while they are mapped non-cacheable (ioremap'ed) as they are not recognized as part of System RAM under the current implementation. After discussing several possibilities to address those issues, the agreed approach, in my understanding, is * to add resource entries for every "reserved", i.e. memblock_reserve(), regions to /proc/iomem. (NOMAP regions, also marked as "reserved," remains at top-level for backward compatibility. User-space can tell the difference between reserved-system-ram and reserved-address-space.) * For case (1), user space (kexec-tools) should rule out such regions in searching for free space for loaded data. * For case (2), the kernel should access ACPI tables by mapping them with appropriate memory attributes described in UEFI memory map. (This means that it doesn't require any changes in /proc/iomem, and hence user space.) Please find past discussions about /proc/iomem in [1]. --- more words from James --- Our attempts to fix this just in the kernel reached a dead end, because Kdump needs to include reserved-system-ram, whereas kexec has to avoid it. User-space needs to be able to tell reserved-system-ram and reserved-address-space apart. Hence we need to expose that information, and pick it up in user-space. Patched-kernel and unpatch-user-space will work the same way it does today, as the additional reserved regions are ignored by user-space. Unpatched-kernel and patched-user-space will also work the same way it does today as the additional reserved regions are missing. --->8--- Patch#1 addresses kexec case, for which you are also required to update user space. See necessary patches in [2]. If you want to review Patch#1, please also take a look at and review [2]. Patch#2, #3, #4 and #5 address the kdump case above. Changes in v4 (2018, July 23, 2018) * correct configuration dependency for ACPI (patch#2) Changes in v3.1 (2018, July 10, 2018) * add Ard's patch[4] to this patch set Changes in v3 (2018, July 9, 2018) * drop the v2's patch#3, preferring [4] Changes in v2 (2018, June 19, 2018) * re-organise v1's patch#2 and #3 into v2's #2, #3 and #4 not to break bisect [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-March/565980.html [2] https://git.linaro.org/people/takahiro.akashi/kexec-tools.git arm64/resv_mem [3] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-April/573655.html [4] https://marc.info/?l=linux-efi&m=152930773507524&w=2 AKASHI Takahiro (3): drivers: acpi: add dependency of EFI for arm64 efi/arm: map UEFI memory map even w/o runtime services enabled arm64: acpi: fix alignment fault in accessing ACPI Ard Biesheuvel (1): efi/arm: preserve early mapping of UEFI memory map longer for BGRT James Morse (1): arm64: export memblock_reserve()d regions via /proc/iomem arch/arm64/include/asm/acpi.h | 23 ++++++++++++------ arch/arm64/kernel/acpi.c | 11 +++------ arch/arm64/kernel/setup.c | 38 ++++++++++++++++++++++++++++++ drivers/acpi/Kconfig | 2 +- drivers/firmware/efi/arm-init.c | 1 - drivers/firmware/efi/arm-runtime.c | 16 +++++++------ 6 files changed, 67 insertions(+), 24 deletions(-) -- 2.18.0