From patchwork Mon Jun 25 19:55:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 139883 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp4377567lji; Mon, 25 Jun 2018 12:55:56 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJcskQy9tCCf6MdIx8Y0AHzGSR+OqP9/TZld5ecsGRrQ4rK2Z+7lYSA5/AOdR/jcQU3/2g5 X-Received: by 2002:a65:6103:: with SMTP id z3-v6mr11792322pgu.125.1529956556415; Mon, 25 Jun 2018 12:55:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529956556; cv=none; d=google.com; s=arc-20160816; b=fF8ZinLGC6MOqkaTawDffZl7tmAvUKLDhauTZFN0d30kCeOBVnR3xPvIz37HdHcaBb kvqmANBzxiQwEnhbxTtN0E11lSFN26pGrbotPgyoO+jJhdi8EUs8ofsoPEJ4rPqDzO2e ZmaYPKZMMI0pWurHZHrLNR7jy97Tw/XYgFyQPhCjsrvSN1SesZSw+d3OgR8cXImj+nn7 rTtZgShov5y1p6TEDOM9XOKIkE70H/AHos2F4dr316dP9csNwt2PN44dvhu9qENYPEl+ Pp+hTXOuOEcx8GGZM0CM4Woix2myzOmxOR6gKs3jTkiN3Ze/WHHsJLa3KX95xfPbk2UQ bnHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=8JsplwdCGInDqyNOJNSReCPhLS4ecB0lWAL0Ojz4pi4=; b=r6iC2HymIbuEAmWmf3lB4h8aYlNlzFL/Klf2aIPZCGh8HhHy3C0jr1YOW6NHlZqZn1 dvKngqUpKcMfCyZEKLg4KMO2D2z0vFQfFzI+bf+94IRT7Ix9+ibZLsuWeu385Ihx6ZVI 1SpnmymcOVbUfL+xtQKaeH7O7qqsQah5jyHwSnMtHsY3VO3MqnjxkG93opP4uovp/cIC zvVZUO0n2hv/lnctGfKV6m95AOcw8f9eTBfuZB8qaf6mEYxWtWi+muYrx9fzhKhV72HN 4GfuboPtM9dEtFG9lb8dZkpW5/f9yyHd9WqpXtMish7jQpgWsDG4iy9sY5XUosLY+BpT 6TDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JYhVklP7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2-v6si11962342pgt.611.2018.06.25.12.55.55; Mon, 25 Jun 2018 12:55:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JYhVklP7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965038AbeFYTzw (ORCPT + 31 others); Mon, 25 Jun 2018 15:55:52 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:43646 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964869AbeFYTzu (ORCPT ); Mon, 25 Jun 2018 15:55:50 -0400 Received: by mail-wr0-f193.google.com with SMTP id c5-v6so3704662wrs.10 for ; Mon, 25 Jun 2018 12:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=8JsplwdCGInDqyNOJNSReCPhLS4ecB0lWAL0Ojz4pi4=; b=JYhVklP7EAzrkDQemMxG0gXS97KTOMHqYUaY5kXWTO1MjUshOamsuhGbJn50wtITyZ kzsqSpNJFZsx5Ld1g8ley7HSC5e4QpR3Cat05YAEHmYPP8oACF/stpw7GCB6DIHazVn+ fbMdW8x5uWNo5sUxO9qNFIvhPnQrbB9l0X1r4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8JsplwdCGInDqyNOJNSReCPhLS4ecB0lWAL0Ojz4pi4=; b=SFB5WAa41LFv0X8lNvwaX7DNJ+02MxSybpkrAHv4xud8zRtPkQezoMt/PNH0FeYgtO 5V7alKqCgiKrYBteW/Mzw+wnM0jngMvcFb4PUSSlD0VOemULFXJBKK0tZTx15T0rfsJB ywYhTlrbm0chvnTM8q+reQkJL9GTaJm54Xhioe+yoZY85GSxgI9dDbSfFXLezYOVisio +OwyFuV7T9hHAHkXTT4y54u/uSWtR+a/IettvXl0izTF5azLXroic1ZHrcYWzE9SEJBp 5QiA34uIhPZjY3uUCuqP2DCt9ORRI5wOZy+tu4YKv8CH2+LTvaOu831vI6noBChF+3em 2QMA== X-Gm-Message-State: APt69E3eLu+FcG/X6+Ka5ulccu9/nA0gyk85m8UJX/0EzEMcwXGq7Fu2 5jB7S9Wo2aZ8SbdpcMSkDr+1c1E+EhM= X-Received: by 2002:a5d:4049:: with SMTP id w9-v6mr11475753wrp.96.1529956549549; Mon, 25 Jun 2018 12:55:49 -0700 (PDT) Received: from localhost.localdomain (146-241-36-97.dyn.eolo.it. [146.241.36.97]) by smtp.gmail.com with ESMTPSA id n18-v6sm29072897wrj.58.2018.06.25.12.55.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jun 2018 12:55:48 -0700 (PDT) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, Paolo Valente Subject: [PATCH BUGFIX RESEND 0/4] bfq: fix bugs breaking bandwidth guarantees occasionally Date: Mon, 25 Jun 2018 21:55:33 +0200 Message-Id: <20180625195537.7769-1-paolo.valente@linaro.org> X-Mailer: git-send-email 2.16.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, during some bandwidth tests, I found some occasional but severe malfunctions (losses of bandwidth control). The first three patches in this series fix the bugs that caused these malfunctions. The last patch is a fix/improvement of the name of one of the functions involved with these bugs. I guess these patches are appropriate for next kernel release. Thanks, Paolo Paolo Valente (4): block, bfq: add/remove entity weights correctly block, bfq: do not expire a queue that will deserve dispatch plugging block, bfq: fix service being wrongly set to zero in case of preemption block, bfq: give a better name to bfq_bfqq_may_idle block/bfq-iosched.c | 131 +++++++++++++++++++++++++++++++++++++++++++--------- block/bfq-iosched.h | 7 ++- block/bfq-wf2q.c | 30 ++++++------ 3 files changed, 128 insertions(+), 40 deletions(-) -- 2.16.1 Tested-by: Holger Hoffstätte Tested-by: Oleksandr Natalenko