From patchwork Mon Jun 25 19:48:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 139878 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp4372350lji; Mon, 25 Jun 2018 12:48:25 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL691M4j3Q32HQ3kFUK0teVDwlHW/9jENlHG9JdWZ1F8cD0g5i1puxOtTC6Rai5deXcmVR1 X-Received: by 2002:a62:aa18:: with SMTP id e24-v6mr14228960pff.72.1529956105444; Mon, 25 Jun 2018 12:48:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529956105; cv=none; d=google.com; s=arc-20160816; b=ueINzedh3wOL4SC7f1IulMd0OojrLxNR52Cg4Mxm9XRz99lGiK82+WuYhxc/w2SVwB O7iFpj2E4U4JmYc6OXP5GXDMAJ4xN8vtru9gEdYw4Uh6lVn+h/rn/dkASyU21Kdhr9uh fJF5abAB96BtSCQcxDG0aXe11NJsFnYg91G/85PUGYgWzPmfNxGDvRENZr9FxJf8BLa8 sGj8I1YCzqLNSZQ4A2p2IpZnReurSzCLGsKR4Y4xo4/qwHb7CHs3ZtsfsnmKXg6FXXfT WAcL877nhAXMvdlTecqe9lsvEETTEgd/vs5KHAOjyJOVQXl1JYztt57itgfuHFqMcTgJ Jp1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=gjlQ8+456ljOWKGroBtAa5LO0SGekXvVSi81l9uCRmc=; b=yb6A4uEm30LfAcY6WhKbqy2Dd6fbA8am3YyMFSch0RSzNfYFj/G/fxzd0ZQRNhwAF4 pTEfMrZ6R/KtlqbeKLnOP1K5ADc3HU3xxFJN7z3G6gyQdgxVGO4eSZPSBlx+8q4nZgzL XtQmOGGLUQw4YpnWsD+/lrEi9Kkd+JDTd2eikOiTxGzktcRx8c+9zDqyCf+Pc1kSmXco mIop/XtLXViMTvM/gdA5SNWdix64tgSptW11zB2OMxIUbykXTjKNhk3LeA2IAZ9eBlhc W+vT+5jmBqlmWxhZ21mLh/4FeHeJvUdyCrqp0o7cF97hRDQRgXIwGgX4vB96iatCX46V bhSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PWJdEMlx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x65-v6si2312364pff.196.2018.06.25.12.48.25; Mon, 25 Jun 2018 12:48:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PWJdEMlx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755677AbeFYTsW (ORCPT + 31 others); Mon, 25 Jun 2018 15:48:22 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:33320 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755600AbeFYTsU (ORCPT ); Mon, 25 Jun 2018 15:48:20 -0400 Received: by mail-ed1-f68.google.com with SMTP id l23-v6so3483556edq.0 for ; Mon, 25 Jun 2018 12:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=gjlQ8+456ljOWKGroBtAa5LO0SGekXvVSi81l9uCRmc=; b=PWJdEMlxf8dwDoF3pxCQbJ2CCLR9PGLJXykJ8SGV2sTzDdKDwy53hfK0zdAsAndtnF qBvcW76tt75p7LAJ9RC/aTQ10d2e3snVhJnpTZ6Awxr0qxaj9UM/LUWV/W2mODWjyA5j hmpNIN4c7sZg+CN4fCMeFGNsGzWtu3Wn+iL0w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gjlQ8+456ljOWKGroBtAa5LO0SGekXvVSi81l9uCRmc=; b=otL4YZO7qWt32DSaMl91FNeR0SvOrH3ufpcY9LtEdor5Ie6Uv1ugMPDY3HNN6yq5SZ i3BfQaJFCqJQVGgrbu/D0O9u3SK/DHEUr7ixeqSKJcLymJjEpCc+7+gxvzSULNGHduqR 2ei3LP9ZiZX29GEKCreVzZncDJQTToij0mTwTH2pv8wYFdMJx95jR7TsHOfctiExZClM 72xmS5gCv7V9WZAet2rj4ga4Ast0vMfH84w1nzagHR9PwZ4Qp3EBY5bfCWSFFflOO/oG wKHsinrfEPiBIbbrTzrp2xyE5M1gLabVe/mhoCaHFwG7m1oFF/DXdFbFGNv9jYzpCtfV OfLg== X-Gm-Message-State: APt69E3S0bkxspXz9RqNMcc1FnUsxIiQnPilBUriPwlhRoH3j0GsH1Ur sk9rAW+xohjYEPWvMvodRbuqvQ== X-Received: by 2002:a50:9286:: with SMTP id k6-v6mr5813882eda.66.1529956099749; Mon, 25 Jun 2018 12:48:19 -0700 (PDT) Received: from localhost.localdomain (146-241-36-97.dyn.eolo.it. [146.241.36.97]) by smtp.gmail.com with ESMTPSA id d11-v6sm17553edh.61.2018.06.25.12.48.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jun 2018 12:48:18 -0700 (PDT) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, Paolo Valente Subject: [PATCH BUGFIX 0/4] bfq: fix bugs breaking bandwidth guarantees occasionally Date: Mon, 25 Jun 2018 21:48:02 +0200 Message-Id: <20180625194806.7619-1-paolo.valente@linaro.org> X-Mailer: git-send-email 2.16.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, during some bandwidth tests, I found some occasional but severe malfunctions (losses of bandwidth control). The first three patches in this series fix the bugs that caused these malfunctions. The last patch is a fix/improvement of the name of one of the functions involved with these bugs. I guess these patches are appropriate for next kernel release. Thanks, Paolo Paolo Valente (4): block, bfq: add/remove entity weights correctly block, bfq: do not expire a queue that will deserve dispatch plugging block, bfq: fix service being wrongly set to zero in case of preemption block, bfq: fix service being wrongly set to zero in case of preemption block/bfq-iosched.c | 131 +++++++++++++++++++++++++++++++++++++++++++--------- block/bfq-iosched.h | 7 ++- block/bfq-wf2q.c | 30 ++++++------ 3 files changed, 128 insertions(+), 40 deletions(-) -- 2.16.1