From patchwork Thu May 31 13:23:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 137387 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp6599772lji; Thu, 31 May 2018 06:23:37 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIyv7Yg3ki1lj+/A50lgLkDszW9waBG3ZC+DBVDxA3yWYW65XyK3WQNptjn9JJBkeenl27r X-Received: by 2002:a65:578b:: with SMTP id b11-v6mr5662725pgr.57.1527773017088; Thu, 31 May 2018 06:23:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527773017; cv=none; d=google.com; s=arc-20160816; b=edtvkOI7Kvgh5AD/cwsqgn73imo1almpCTxNkAA64STzEHZ9msJcUC1iTqbitmMXRR QUrs+JyFaH81FwyrNZh9ckipJN697B6zqfeHVrn+dLlobWwTk+SAey0cWvzVgT9DRc7B AACXDecICwu5XIroZrFiwot/LzNdi05dbBPseDO2z4Cw5oOnC499eUI45/uqCKxPq8q+ s7ZE5s5mVPMefqIIiA0fzSCXl6hBzzYrRlGZv4f9ix6P9bT0/30BI3TIq7EWOa7uRyxz /gEly2nQbYbz8nmfNCkl2SHMzNWVyQSSHJIcPZxyQ/YKEJ84IaFCwt1ueDaws5Sv0cTT vuUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=N7IKv1gCn4du766vZS4MuoR1thnwWzzul1FFuKSU11k=; b=E2iMJAs8nHjf7ZtWIz5UhAeUswFsRADNo+BazagtEpbg2asPAjLTeHWw86Nul7bYWi 2Rj7F/CoKwPrh8oyWriqyM+dB/A9Ndpu4aA0dVPtgm1VOTf2mmAkS8B8UzeGk+DT3ZX9 58DKx2PF+LamazhydbGqqG4ODIMbxieT+tgY4OF957VuwaULhUHB++8GWnR5ZShGMnCP LILhrKV+dk2V7KJ5VuLE4sWnG7a9IkJeGf1c44qXVjb5rMKIa0qK5MucXpz6i0vJuVfn jxeseWp7FOdWr/SnW11M2goW9nkR+6ke244jIQ9P3MyUfZlpDKIVhC2O0dhHAqw3luAm mTwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=khDpMBHJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b17-v6si14210757pgw.440.2018.05.31.06.23.36; Thu, 31 May 2018 06:23:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=khDpMBHJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755264AbeEaNXe (ORCPT + 30 others); Thu, 31 May 2018 09:23:34 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36119 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755159AbeEaNXc (ORCPT ); Thu, 31 May 2018 09:23:32 -0400 Received: by mail-wm0-f65.google.com with SMTP id v131-v6so34719488wma.1 for ; Thu, 31 May 2018 06:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=N7IKv1gCn4du766vZS4MuoR1thnwWzzul1FFuKSU11k=; b=khDpMBHJ0RjCqxn6ia3lUYm0Sw/fNeIsWsUSCPJUKjIUa1aKujs115X6zKZYX+3Nxu 5aKkbfcZu14Ftx8l9+vwu3UoXuES0Cq8cYuZyiLNYNAzy6jPcRlUTfPC5pOmorfCxJRI 3D80I2GzXkMJ+IU+du6tr3+wtZ9ztasjAH5xc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=N7IKv1gCn4du766vZS4MuoR1thnwWzzul1FFuKSU11k=; b=jGL/OiHiPf1luQxj1XQMPw7v6CY9Au+2TiD85REnYylPA4285KKJiXozDZn2aI77zj 99bD3i8Il2G1rPpYHcAcvcteY+BrELHCNc2j2E+NZy+QDf6kudApVpf4Msv77MgIm61X vlF1p5woBSkpW6+KBfPy2KWdTMgvTTVj92Hlq0m8OhEZyjlWXkidpLZmPtu1OIWZ6tZ1 IR9RdnhV03oGeq+LSOv/VpyPdyhJw6gCWOcJ4mRPJxNI4tO5W3B0Bqq0J/daTaemAxP8 fqp6GZFKtKYOVf53/OoP4rQjKuJLVYtGrUEH8rAZJzOg9DcuH44ibiIn4GQkietdXi3N Vweg== X-Gm-Message-State: ALKqPwcB9+8a80yqO/PxiDnlHzRJmL+uJDUBzCjY0hs+8BwCxX2bFv5i UFRvwo55seWoRzXu7qru66CirRtgmNo= X-Received: by 2002:a1c:b884:: with SMTP id i126-v6mr4111475wmf.30.1527773011308; Thu, 31 May 2018 06:23:31 -0700 (PDT) Received: from localhost.localdomain (146-241-12-84.dyn.eolo.it. [146.241.12.84]) by smtp.gmail.com with ESMTPSA id e133-v6sm1759478wma.38.2018.05.31.06.23.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 May 2018 06:23:30 -0700 (PDT) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, filippo.muzzini@outlook.it, Paolo Valente Subject: [PATCH BUGFIX 0/3] three fixes for the function bfq_requests_merged Date: Thu, 31 May 2018 15:23:10 +0200 Message-Id: <20180531132313.2986-1-paolo.valente@linaro.org> X-Mailer: git-send-email 2.16.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jens, this series fixes three bugs in bfq_requests_merged. In more detail: - two linked bugs, with the first (critical: wrong lock) hidden by the second (less critical: wrong check that made the body of the function not be executed at all) - a rather minor bug: superflous code Thanks, Paolo Filippo Muzzini (2): block, bfq: remove wrong lock in bfq_requests_merged block, bfq: remove the removal of 'next' rq in bfq_requests_merged Paolo Valente (1): block, bfq: remove wrong check in bfq_requests_merged block/bfq-iosched.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) -- 2.16.1