mbox series

[BUGFIX,0/3] three fixes for the function bfq_requests_merged

Message ID 20180531132313.2986-1-paolo.valente@linaro.org
Headers show
Series three fixes for the function bfq_requests_merged | expand

Message

Paolo Valente May 31, 2018, 1:23 p.m. UTC 
Hi Jens,
this series fixes three bugs in bfq_requests_merged. In more detail:

- two linked bugs, with the first (critical: wrong lock) hidden by the
  second (less critical: wrong check that made the body of the
  function not be executed at all)
- a rather minor bug: superflous code

Thanks,
Paolo

Filippo Muzzini (2):
  block, bfq: remove wrong lock in bfq_requests_merged
  block, bfq: remove the removal of 'next' rq in bfq_requests_merged

Paolo Valente (1):
  block, bfq: remove wrong check in bfq_requests_merged

 block/bfq-iosched.c | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

--
2.16.1

Comments

Jens Axboe May 31, 2018, 2:48 p.m. UTC | #1 
On 5/31/18 7:23 AM, Paolo Valente wrote:
> Hi Jens,

> this series fixes three bugs in bfq_requests_merged. In more detail:

> 

> - two linked bugs, with the first (critical: wrong lock) hidden by the

>   second (less critical: wrong check that made the body of the

>   function not be executed at all)

> - a rather minor bug: superflous code


Patch #2 doesn't apply on for-4.18/block. I hand applied it, all
3 are queued up now.

-- 
Jens Axboe
Paolo Valente May 31, 2018, 2:50 p.m. UTC | #2 
> Il giorno 31 mag 2018, alle ore 16:48, Jens Axboe <axboe@kernel.dk> ha scritto:

> 

> On 5/31/18 7:23 AM, Paolo Valente wrote:

>> Hi Jens,

>> this series fixes three bugs in bfq_requests_merged. In more detail:

>> 

>> - two linked bugs, with the first (critical: wrong lock) hidden by the

>>  second (less critical: wrong check that made the body of the

>>  function not be executed at all)

>> - a rather minor bug: superflous code

> 

> Patch #2 doesn't apply on for-4.18/block.


Yep, it gave some problems to me too, because we happened to move this
patch around by email.

> I hand applied it, all

> 3 are queued up now.

> 


Thanks for the patience and for queueing these fixes.

Paolo

> -- 

> Jens Axboe

>