From patchwork Sun Dec 3 02:00:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Nan X-Patchwork-Id: 120439 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2903626qgn; Sat, 2 Dec 2017 18:03:19 -0800 (PST) X-Google-Smtp-Source: AGs4zMYUzoSA+UA+1EW13o8INHufgOht6vEK3pz7e1kHrx97IBug89DuhOB0VHBxFFoMrsQEBBOe X-Received: by 10.99.141.75 with SMTP id z72mr9977726pgd.73.1512266599110; Sat, 02 Dec 2017 18:03:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512266599; cv=none; d=google.com; s=arc-20160816; b=hXYGnw502tWNzqSQ7CSBs17wMp7Tw0IjgB4YH0BRLULvvTM0x9SzZzN4LXlvkS53pR peYhGZTNCobWlwDtOERS/9Qlj2KO6ccw/+J7p79TSgzRvyLt16Py8Zd+Cv5eFCjU8Qt4 EAe8nArCTkvBvVlUku+D0UiLZPCygItO/evDp+igmBezzEIimlobFFWBQVYKtWfmy/f5 fOUeo4kPtMVW9xYsWJud62beCtNKKr/MBXBI9bFbyJShsjrcc9wpcY7RFTPNC179csm5 2xhphk/wNo6h0lE8fLt8NIqM/Cj6ErbqFJCmglb6+aTHXvf9HHY3h+FSb17pJgyctrUc biCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=nOmZ9aNh/mXHmX4d1FX7IK4ZedPxgTEIsGt1djdJHHY=; b=TP1U6PtmGeNGKf9aqUUjXcY3NdFBY/OC2w4eRwLjLGX8E5FIaUVc4w9/7Mnhek7UzI vTjUIDKCfnr3aOlq/0yXhNm7sv7u1QJH0w24bzWnZY9jGCMYKCRZ+O9HivYUN4+xOGrA CdZdsbGqKbZkkpGW8FMKD+VAZKAGeKIDB7gtpaW6j2nJXeLMGizs2CC8Q1ZNVRhiYqBN aKWvC1SPNrZgsMsjBassfqENb/o1HCoWAXB8JhL1d03aTSkweRshCXSmVdTz/lJXcMGR Ixu4M95Yypyy1yK21rmzgUKW0oEzW7p9361r3fUoReNy7w5IgQ4OwM0FTbbvIG5IxUjJ Symw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w23si7279450plk.779.2017.12.02.18.03.18; Sat, 02 Dec 2017 18:03:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752615AbdLCCCx (ORCPT + 28 others); Sat, 2 Dec 2017 21:02:53 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:51626 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751856AbdLCCCv (ORCPT ); Sat, 2 Dec 2017 21:02:51 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 3A5209DB00F24; Sun, 3 Dec 2017 10:02:46 +0800 (CST) Received: from linux-4hy3.site (10.107.193.248) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.361.1; Sun, 3 Dec 2017 10:02:39 +0800 From: Wang Nan To: , , , , CC: Wang Nan , Arnaldo Carvalho de Melo , Jiri Olsa , Zhang Mengting Subject: [PATCH v2 0/8] perf tools: perf tools: Clarify overwrite and backward, bugfix Date: Sun, 3 Dec 2017 02:00:36 +0000 Message-ID: <20171203020044.81680-1-wangnan0@huawei.com> X-Mailer: git-send-email 2.10.1 MIME-Version: 1.0 X-Originating-IP: [10.107.193.248] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org THe final result of this patchset is removing the concept of 'forward/backward', merge them into the concept of 'overwrite'. Patch 1 to 5 clear arguments lists of many functions, remove the 'overwrite'. Because all callers of these functions doesn't need the overwrite be set, we can simply remove them from arguments lists and adjust code as if a 'false' is given. Patch 6 fix a bug that forget to setting readonly for overwrite ring buffers. Patch 7 is suggested by Liang Kan, prevent dumpping duplicated data if there's no so many events between two dumpping commands. Patch 8 is 's/backward/overwrite'. After patch 8, the concept of 'backward' is removed from most of the code, make it uniform with user interface ('--overwrite'). Cc: Kan Liang Cc: Arnaldo Carvalho de Melo Cc: Jiri Olsa Cc: Namhyung Kim Cc: Zhang Mengting Wang Nan (8): perf tools: Remove 'overwrite' parameter from perf_evlist__mmap perf tools: Remove 'overwrite' parameter from perf_evlist__mmap_ex perf tools: Remove evlist->overwrite perf tools: Remove overwrite from arguments list of perf_mmap__push perf tools: Remove overwrite and check_messup from mmap read perf mmap: Fix perf backward recording perf tool: Don't discard prev in backward mode perf tools: Replace 'backward' to 'overwrite' in evlist, mmap and record tools/perf/arch/x86/tests/perf-time-to-tsc.c | 2 +- tools/perf/builtin-kvm.c | 2 +- tools/perf/builtin-record.c | 16 +++--- tools/perf/builtin-top.c | 2 +- tools/perf/builtin-trace.c | 2 +- tools/perf/tests/backward-ring-buffer.c | 6 +-- tools/perf/tests/bpf.c | 2 +- tools/perf/tests/code-reading.c | 2 +- tools/perf/tests/keep-tracking.c | 2 +- tools/perf/tests/mmap-basic.c | 2 +- tools/perf/tests/openat-syscall-tp-fields.c | 2 +- tools/perf/tests/perf-record.c | 2 +- tools/perf/tests/sw-clock.c | 2 +- tools/perf/tests/switch-tracking.c | 2 +- tools/perf/tests/task-exit.c | 2 +- tools/perf/util/evlist.c | 53 ++++++++++---------- tools/perf/util/evlist.h | 8 ++- tools/perf/util/mmap.c | 73 ++++++++++------------------ tools/perf/util/mmap.h | 4 +- tools/perf/util/python.c | 2 +- 20 files changed, 81 insertions(+), 107 deletions(-) -- 2.10.1 Acked-by: Namhyung Kim