mbox series

[0/3] dtc updates for 4.12

Message ID 20170321161958.9658-1-robh@kernel.org
Headers show
Series dtc updates for 4.12 | expand

Message

Rob Herring (Arm) March 21, 2017, 4:19 p.m. UTC
This series syncs dtc with current mainline. The primary motivation is 
to pull in the new checks I've worked on. This gives lots of new 
warnings which are turned off by default.

Arm-soc folks, I've left the PCI checks enabled as they are pretty much 
all real errors and there aren't that many (about 1200, but that's lots 
of duplicates). I have a patch for some of them.

Rob

Rob Herring (3):
  scripts/dtc: automate getting dtc version and log in update script
  scripts/dtc: Update to upstream version v1.4.4-8-g756ffc4f52f6
  dtc: update warning settings for new bus and node/property name checks

 scripts/Makefile.lib                 |   9 +-
 scripts/dtc/checks.c                 | 361 +++++++++++++++++++++++++++++++----
 scripts/dtc/data.c                   |  16 +-
 scripts/dtc/dtc-lexer.l              |   3 +-
 scripts/dtc/dtc-lexer.lex.c_shipped  |  77 ++++----
 scripts/dtc/dtc-parser.tab.c_shipped |   6 +-
 scripts/dtc/dtc-parser.y             |   6 +-
 scripts/dtc/dtc.c                    |   9 +-
 scripts/dtc/dtc.h                    |  11 +-
 scripts/dtc/flattree.c               |  58 +++---
 scripts/dtc/libfdt/fdt_rw.c          |   3 +-
 scripts/dtc/libfdt/libfdt.h          |  51 ++++-
 scripts/dtc/libfdt/libfdt_env.h      |  26 +--
 scripts/dtc/livetree.c               |  22 ++-
 scripts/dtc/srcpos.c                 |   2 +-
 scripts/dtc/srcpos.h                 |  11 +-
 scripts/dtc/treesource.c             |   6 +-
 scripts/dtc/update-dtc-source.sh     |  20 +-
 scripts/dtc/util.c                   |  11 +-
 scripts/dtc/util.h                   |  24 ++-
 scripts/dtc/version_gen.h            |   2 +-
 21 files changed, 550 insertions(+), 184 deletions(-)

-- 
2.10.1

Comments

Florian Fainelli March 21, 2017, 4:49 p.m. UTC | #1
On 03/21/2017 09:19 AM, Rob Herring wrote:
> This series syncs dtc with current mainline. The primary motivation is 

> to pull in the new checks I've worked on. This gives lots of new 

> warnings which are turned off by default.

> 

> Arm-soc folks, I've left the PCI checks enabled as they are pretty much 

> all real errors and there aren't that many (about 1200, but that's lots 

> of duplicates). I have a patch for some of them.


Out of curiosity, should we think about making dtc a git submodule and
have some magic in scripts/update-dtc-source.sh to sync it to a desired
commit?

> 

> Rob

> 

> Rob Herring (3):

>   scripts/dtc: automate getting dtc version and log in update script

>   scripts/dtc: Update to upstream version v1.4.4-8-g756ffc4f52f6

>   dtc: update warning settings for new bus and node/property name checks

> 

>  scripts/Makefile.lib                 |   9 +-

>  scripts/dtc/checks.c                 | 361 +++++++++++++++++++++++++++++++----

>  scripts/dtc/data.c                   |  16 +-

>  scripts/dtc/dtc-lexer.l              |   3 +-

>  scripts/dtc/dtc-lexer.lex.c_shipped  |  77 ++++----

>  scripts/dtc/dtc-parser.tab.c_shipped |   6 +-

>  scripts/dtc/dtc-parser.y             |   6 +-

>  scripts/dtc/dtc.c                    |   9 +-

>  scripts/dtc/dtc.h                    |  11 +-

>  scripts/dtc/flattree.c               |  58 +++---

>  scripts/dtc/libfdt/fdt_rw.c          |   3 +-

>  scripts/dtc/libfdt/libfdt.h          |  51 ++++-

>  scripts/dtc/libfdt/libfdt_env.h      |  26 +--

>  scripts/dtc/livetree.c               |  22 ++-

>  scripts/dtc/srcpos.c                 |   2 +-

>  scripts/dtc/srcpos.h                 |  11 +-

>  scripts/dtc/treesource.c             |   6 +-

>  scripts/dtc/update-dtc-source.sh     |  20 +-

>  scripts/dtc/util.c                   |  11 +-

>  scripts/dtc/util.h                   |  24 ++-

>  scripts/dtc/version_gen.h            |   2 +-

>  21 files changed, 550 insertions(+), 184 deletions(-)

> 



-- 
Florian
Olof Johansson March 21, 2017, 7:15 p.m. UTC | #2
On Tue, Mar 21, 2017 at 9:19 AM, Rob Herring <robh@kernel.org> wrote:
> This series syncs dtc with current mainline. The primary motivation is

> to pull in the new checks I've worked on. This gives lots of new

> warnings which are turned off by default.

>

> Arm-soc folks, I've left the PCI checks enabled as they are pretty much

> all real errors and there aren't that many (about 1200, but that's lots

> of duplicates). I have a patch for some of them.


Yay for better warnings!

But as with all changes of this kind, when new warnings are introduced
please give people some time to remove them without turning them on by
default. We had a cycle like that already.

Main reason is that it becomes too hard to spot new warnings when they
come in if the logs are flooded with 1200 existing warnings.

How many of them do you have patches for, per chance? If we can see
them show up quickly the answer to the above might be a bit different.


-Olof
Rob Herring (Arm) March 21, 2017, 7:36 p.m. UTC | #3
On Tue, Mar 21, 2017 at 11:49 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 03/21/2017 09:19 AM, Rob Herring wrote:

>> This series syncs dtc with current mainline. The primary motivation is

>> to pull in the new checks I've worked on. This gives lots of new

>> warnings which are turned off by default.

>>

>> Arm-soc folks, I've left the PCI checks enabled as they are pretty much

>> all real errors and there aren't that many (about 1200, but that's lots

>> of duplicates). I have a patch for some of them.

>

> Out of curiosity, should we think about making dtc a git submodule and

> have some magic in scripts/update-dtc-source.sh to sync it to a desired

> commit?


I'd be fine with that though all of dtc is not imported and I don't
really want to be the first to try to add a git submodule to the
kernel. Not everyone is a fan I think.

Rob