| Message ID | 1555059478-36224-1-git-send-email-john.garry@huawei.com |
|---|---|
| Headers | show |
| Series | libsas: Some minor improvements and tidy-up | expand |
John, > This patchset introduces some minor improvements and tidy-up, including: > - fix PHY info in sysfs for PHY events > - min pathway rate programming improvement > - some other tidy-up and neatening Applied to 5.2/scsi-queue, thanks! One thing that always bugged me is the ambiguous "ex" prefix for many libsas log messages. And in a way, your patch #3 makes things worse by replacing the more descriptive "Expander" with "ex". It does make things more consistent, though. I'd really like to see all the libsas messages be cleaned up with a sensible prefix and a consistent format where possible. -- Martin K. Petersen Oracle Linux Engineering
On 16/04/2019 00:33, Martin K. Petersen wrote: > > John, > >> This patchset introduces some minor improvements and tidy-up, including: >> - fix PHY info in sysfs for PHY events >> - min pathway rate programming improvement >> - some other tidy-up and neatening > > Applied to 5.2/scsi-queue, thanks! > Hi Martin, Sorry for the slow response. > One thing that always bugged me is the ambiguous "ex" prefix for many > libsas log messages.And in a way, your patch #3 makes things worse by > replacing the more descriptive "Expander" with "ex". It does make things > more consistent, though. OK, understood. Personally I prefer the brevity of "ex". However, apart from this, adding the SAS address to the log does add value. > > I'd really like to see all the libsas messages be cleaned up with a > sensible prefix and a consistent format where possible. So all libsas messages do have the "sas: " prefix, but they still can be vague/inconsistent at times. Anyway, I'll check what can be done here. Thanks, >
This patchset introduces some minor improvements and tidy-up, including: - fix PHY info in sysfs for PHY events - min pathway rate programming improvement - some other tidy-up and neatening John Garry (6): scsi: libsas: Stop hardcoding SAS address length scsi: libsas: Try to retain programmed min linkrate for SATA min pathway unmatch fixing scsi: libsas: Improve vague log in SAS rediscovery scsi: libsas: Inject revalidate event for root port event scsi: libsas: Do discovery on empty PHY to update PHY info scsi: libsas: Print expander PHY indexes in decimal drivers/scsi/libsas/sas_ata.c | 2 +- drivers/scsi/libsas/sas_expander.c | 83 ++++++++++++++++++------------ drivers/scsi/libsas/sas_init.c | 42 ++++++++------- drivers/scsi/libsas/sas_phy.c | 7 ++- drivers/scsi/libsas/sas_port.c | 24 +++++++-- include/scsi/libsas.h | 13 +++-- 6 files changed, 108 insertions(+), 63 deletions(-) -- 2.17.1