| Message ID | 1531295145-596-1-git-send-email-leo.yan@linaro.org |
|---|---|
| Headers | show |
| Series | perf cs-etm: Fix tracing packet handling and minor refactoring | expand |
Hi Arnaldo, On Wed, Jul 11, 2018 at 03:45:39PM +0800, Leo Yan wrote: Just want to confirm, I saw the first two patches in this serise have been merged into perf/core branch [1], but the last 4 patches are missed. Could I know if you have trouble when you apply them? Or anything need me to follow up? Otherwise you might miss them :) Thanks, Leo Yan [1] https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=perf/core > Leo Yan (6): > perf cs-etm: Introduce invalid address macro > perf cs-etm: Bail out immediately for instruction sample failure > perf cs-etm: Fix start tracing packet handling > perf cs-etm: Support dummy address value for CS_ETM_TRACE_ON packet > perf cs-etm: Generate branch sample when receiving a CS_ETM_TRACE_ON > packet > perf cs-etm: Generate branch sample for CS_ETM_TRACE_ON packet > > tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 10 ++-- > tools/perf/util/cs-etm-decoder/cs-etm-decoder.h | 1 + > tools/perf/util/cs-etm.c | 71 +++++++++++++++++++++---- > 3 files changed, 68 insertions(+), 14 deletions(-) > > -- > 2.7.4 >
Em Mon, Jul 23, 2018 at 09:35:07AM +0800, leo.yan@linaro.org escreveu: > Hi Arnaldo, > > On Wed, Jul 11, 2018 at 03:45:39PM +0800, Leo Yan wrote: > > Just want to confirm, I saw the first two patches in this serise have > been merged into perf/core branch [1], but the last 4 patches are > missed. > > Could I know if you have trouble when you apply them? Or anything > need me to follow up? Otherwise you might miss them :) Just this reminder was enough, checked that it has Mathieu's reviewed-by tags, applied, will go thru my cross build containers, hopefully all will test build ok and then it'll go to Ingo's direction. Thanks, - Arnaldo
On Tue, Jul 31, 2018 at 11:24:45AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Jul 23, 2018 at 09:35:07AM +0800, leo.yan@linaro.org escreveu: > > Hi Arnaldo, > > > > On Wed, Jul 11, 2018 at 03:45:39PM +0800, Leo Yan wrote: > > > > Just want to confirm, I saw the first two patches in this serise have > > been merged into perf/core branch [1], but the last 4 patches are > > missed. > > > > Could I know if you have trouble when you apply them? Or anything > > need me to follow up? Otherwise you might miss them :) > > Just this reminder was enough, checked that it has Mathieu's reviewed-by > tags, applied, will go thru my cross build containers, hopefully all > will test build ok and then it'll go to Ingo's direction. Cool! Thanks a lot, Arnaldo.
Due the current code is missing to handle cs-etm start tracing packet and CS_ETM_TRACE_ON packet, we fail to generate branch sample for them. This patch series is to fix cs-etm tracing packet handling: Patch 0001 is to add invalid address macro for readable coding; Patch 0002 is one minor fixing to return error code for instruction sample failure; Patches 0003~0006 are fixing patches for start tracing packet and CS_ETM_TRACE_ON packet. This patch series is applied to Linus tree on 4.18-rc4 with latest commit: 1e09177acae3 ("Merge tag 'mips_fixes_4.18_3' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux"). This patch series has been verified on Hikey620 platform with below two commands: perf script --itrace=i10000il128 -F cpu,event,ip,addr,sym -k ./vmlinux perf script -F cpu,event,ip,addr,sym -k ./vmlinux [1] https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git Changes from v1: * Rebased on Linus mainline kernel 4.18-rc4; * Added Mathieu 'reviewed' tags in patches. Leo Yan (6): perf cs-etm: Introduce invalid address macro perf cs-etm: Bail out immediately for instruction sample failure perf cs-etm: Fix start tracing packet handling perf cs-etm: Support dummy address value for CS_ETM_TRACE_ON packet perf cs-etm: Generate branch sample when receiving a CS_ETM_TRACE_ON packet perf cs-etm: Generate branch sample for CS_ETM_TRACE_ON packet tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 10 ++-- tools/perf/util/cs-etm-decoder/cs-etm-decoder.h | 1 + tools/perf/util/cs-etm.c | 71 +++++++++++++++++++++---- 3 files changed, 68 insertions(+), 14 deletions(-) -- 2.7.4