mbox series

[v3,00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups

Message ID 1516206496-16612-1-git-send-email-yamada.masahiro@socionext.com
Headers show
Series mmc: tmio: another batch of TMIO MMC fixes and cleanups | expand

Message

Masahiro Yamada Jan. 17, 2018, 4:28 p.m. UTC
In the previous batch (https://lkml.org/lkml/2017/11/24/428)
I sent 22 patches for TMIO MMC.

14 patches were applied, the rest is under discussion.

This series consists of 16 patches.

Patch 1-4:  repost from v2.
            (Wolfram gave Reviewed by, so I moved them to the head)

Patch 5-11: new patches  (cleanups of WP flag)

Patch 12: updated per Wolfram

Patch 13: repost  (almost reviewed)

Patch 14: updated

Patch 15: new

Patch 16: repost (almost reviewed)


Masahiro Yamada (16):
  mmc: tmio: ioremap memory resource in tmio_mmc_host_alloc()
  mmc: tmio: move clk_enable/disable out of tmio_mmc_host_probe()
  mmc: tmio: move {tmio_}mmc_of_parse() to tmio_mmc_host_alloc()
  mmc: tmio: remove dma_ops from tmio_mmc_host_probe() argument
  mmc: slot-gpio: add a helper to check capability of GPIO WP detection
  mmc: tmio: refactor .get_ro hook
  mmc: renesas_sdhi: use MMC_CAP2_NO_WRITE_PROTECT instead of TMIO own
    flag
  sh: kfr2r09: use MMC_CAP2_NO_WRITE_PROTECT instead of TMIO own flag
  mmc: tmio: use MMC_CAP2_NO_WRITE_PROTECT instead of TMIO own flag
  mmc: tmio: remove TMIO_MMC_WRPROTECT_DISABLE
  mmc: tmio: deprecate "toshiba,mmc-wrprotect-disable" DT property
  mmc: tmio: support IP-builtin card detection logic
  mmc: tmio: fix never-detected card insertion bug
  mmc: tmio: move TMIO_MASK_{READOP,WRITEOP} handling to correct place
  mmc: tmio: clear force_pio flag before starting data transfer
  mmc: tmio: remove useless TMIO_MASK_CMD handling in
    tmio_mmc_host_probe()

 Documentation/devicetree/bindings/mmc/tmio_mmc.txt |   1 -
 arch/sh/boards/mach-kfr2r09/setup.c                |   2 +-
 drivers/mmc/core/slot-gpio.c                       |   8 ++
 drivers/mmc/host/renesas_sdhi_core.c               |  18 ++-
 drivers/mmc/host/renesas_sdhi_internal_dmac.c      |  12 +-
 drivers/mmc/host/renesas_sdhi_sys_dmac.c           |  20 ++-
 drivers/mmc/host/tmio_mmc.c                        |  11 +-
 drivers/mmc/host/tmio_mmc.h                        |   7 +-
 drivers/mmc/host/tmio_mmc_core.c                   | 139 +++++++++++----------
 include/linux/mfd/tmio.h                           |   1 -
 include/linux/mmc/slot-gpio.h                      |   1 +
 11 files changed, 120 insertions(+), 100 deletions(-)

-- 
2.7.4

Comments

Ulf Hansson Feb. 14, 2018, 9:46 a.m. UTC | #1
On 14 February 2018 at 10:43, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Hi Ulf,

>

>

> 2018-02-14 18:36 GMT+09:00 Ulf Hansson <ulf.hansson@linaro.org>:

>> On 7 February 2018 at 20:11, Wolfram Sang <wsa@the-dreams.de> wrote:

>>>

>>>> I picked patch5 and patch6, as those seemed trivial. Unless there is a

>>>> rc9, let's aim for 4.17 for the rest.

>>>

>>> I can't find the branch where you picked these patches? I wanted to use

>>> it to apply the rest of the patches. They don't seem to fit on v4.15

>>> or current linus/master. Can you share this branch?

>>

>> You need to check again. :-)

>>

>> Patches up and to patch6 is already in Linus' tree v.16rc1, those I

>> carried for quite a while on my next branch before sending them in the

>> PR to Linus.

>>

>>>

>>> I will do reviewing now "visually". But please wait until I tested them

>>> before applying.

>>

>> I am eager to apply those patches you already have reviewed (to

>> patch14), as those mostly seemed rather trivial and should be nice

>> cleanups.

>>

>> Do you mind me going ahead, then you can continue and review/test the rest?

>>

>

>

> If you move forward, please fix-up the commit log of the patch 11.

> (https://patchwork.kernel.org/patch/10170007/)

>

>

> Documentation/devicetree/bindings/mmc/tmio_mmc.txt

>

>   ->

>

> Documentation/devicetree/bindings/mmc/mmc.txt


Thanks for the reminder. Yes I can amend the patch, no worries.

Kind regards
Uffe
Ulf Hansson March 5, 2018, 12:06 p.m. UTC | #2
On 5 March 2018 at 10:34, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> Hi Ulf, Wolfram,

>

> 2018-03-05 18:22 GMT+09:00 Wolfram Sang <wsa@the-dreams.de>:

>>

>>> I have added Wolframs tags to the already applied patches and applied

>>> that last two, 15 and 16.

>>

>> Thanks. Please note that patch 14 misses my Rev tag. (I gave it

>> yesterday but the patch was accidently applied before. One round too

>> early, so to say).


Added rev. tag.

>>

>>> They are all present in my next branch. The fix that Wolfram sent on

>>> top, is added immediately after the commit it fixes.

>>

>> Could we also squash it, then?

>>

>

> If Wolfram is fine with squashing,

> that would be cleaner.

>


Done.

> In that case, can you add Tested-by

> to patch 12?


Done.

Kind regards
Uffe