mbox series

[v6,0/5] stm32 clocksource driver rework

Message ID 1508331506-23782-1-git-send-email-benjamin.gaignard@linaro.org
Headers show
Series stm32 clocksource driver rework | expand

Message

Benjamin Gaignard Oct. 18, 2017, 12:58 p.m. UTC 
version 6:
- add timer_of_deinit function in core
- rework failure cases in probe function

version 5:
- rebase on top of timer/core branch
- rework commit message of the first patch

version 4:
- split patch in 3 parts
  - convert code to timer_of
  - only use 32 bits timers
  - add clocksource support

version 3:
- fix comments done by Daniel
- use timer_of helper functions

version 2:
- fix uninitialized variable

These patches implements clocksource and clockevent by using only one hardware block.
Getting both clock source and events on the same hardware lead to change quite
a lot driver code.
It also limits usage of clocksource to 32 bits timers because 16 bits ones
aren't enough accurate.
Thanks to timer_fo helpers this series includes minor clean up in structures,
function prototypes and driver name.

Since 16 bits timers become useless it also removes them from stm32f4 and
stm32f7 devicetree.

Increase min delta value to be sure to not have too much interrupts.


Benjamin Gaignard (5):
  timer: add timer_of_deinit function
  clocksource: stm32: convert driver to timer_of
  clocksource: stm32: only use 32 bits timers
  clocksource: stm32: add clocksource support
  arm: dts: stm32: remove useless clocksource nodes

 arch/arm/boot/dts/stm32f429.dtsi  |  32 ------
 arch/arm/boot/dts/stm32f746.dtsi  |  32 ------
 drivers/clocksource/Kconfig       |   1 +
 drivers/clocksource/timer-of.c    |  12 ++
 drivers/clocksource/timer-of.h    |   3 +
 drivers/clocksource/timer-stm32.c | 232 +++++++++++++++++++-------------------
 6 files changed, 132 insertions(+), 180 deletions(-)

-- 
2.7.4

Comments

Thomas Gleixner Oct. 18, 2017, 6:31 p.m. UTC | #1 
On Wed, 18 Oct 2017, Benjamin Gaignard wrote:

> Convert driver to use timer_of helpers. This allow to remove

> custom proprietary structure.

> 

> Increase min delta value because if it is too small it could

> generate too much interrupts and the system will not be able

> to catch them all.


This does two completely independent changes at once. What the heck has
increasing min delta to do with converting it to timer_of() helpers?

Nothing at all. So please split this into two distinct patches. Each doing
ONE thing.

See Documentation/process/submitting-patches.rst:

  3) Separate your changes
  ------------------------

  Separate each **logical change** into a separate patch.

Reading, understanding and complying with that document is not optional.

Thanks,

	tglx
Benjamin Gaignard Oct. 18, 2017, 7:32 p.m. UTC | #2 
2017-10-18 20:31 GMT+02:00 Thomas Gleixner <tglx@linutronix.de>:
> On Wed, 18 Oct 2017, Benjamin Gaignard wrote:

>

>> Convert driver to use timer_of helpers. This allow to remove

>> custom proprietary structure.

>>

>> Increase min delta value because if it is too small it could

>> generate too much interrupts and the system will not be able

>> to catch them all.

>

> This does two completely independent changes at once. What the heck has

> increasing min delta to do with converting it to timer_of() helpers?

>

> Nothing at all. So please split this into two distinct patches. Each doing

> ONE thing.


I will do that.

>

> See Documentation/process/submitting-patches.rst:

>

>   3) Separate your changes

>   ------------------------

>

>   Separate each **logical change** into a separate patch.

>

> Reading, understanding and complying with that document is not optional.

>

> Thanks,

>

>         tglx




-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog