From patchwork Wed Jun 7 09:16:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ding Tianhong X-Patchwork-Id: 103224 Delivered-To: patch@linaro.org Received: by 10.140.91.77 with SMTP id y71csp1834602qgd; Wed, 7 Jun 2017 02:17:17 -0700 (PDT) X-Received: by 10.99.95.194 with SMTP id t185mr5032063pgb.19.1496827037815; Wed, 07 Jun 2017 02:17:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496827037; cv=none; d=google.com; s=arc-20160816; b=Zk0Y9uRGEuE+iRyOe4v0DDJ5AGL+y1NjE5rp46ezaf8gEhRyy30fHg3Sgcx3QRtP1H DbN5wM7RbRLrd7H805UrPHTJXKdxV6W0syWIzzts7ApITig3zu3nQDfQZgj9mBfKLtX4 MjVs61jm8cMmLyGwnbICrnsRs/FB/tQxcbvlz+e2dqf6Q2pDWJcfvyv5H9BAoUviVNiv hN2h+d1VwSGd+pg4s+JmaJgfqx21u7THtYu5C3uiCLtd9saxVjZ4kSY4KmsUKcesDT14 XyQf+PM/uFQIWaNqp2wdOM4rzyd/xeWe53/N20+G54JZ1Y/k0JY/dAuYILM45LG2YBPo AdEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=sQck4DYEBxz7mr/CtCqfQA2VJWtlx6D8fwEldhsaSwk=; b=CKYX/Wu06MXaRPwPa5y4eBtoV5UQOYq/ybOZIRASK6flIhbpqo31Ml8Duv/d5kFm/p w3npxYRN14cgO/I759kxfGPMDr/kHgcKJ2Fg7C3SI2+A2J+bDYV1yV64nahFeDG+PjQJ duSPy1kg2OABQWeqbXz3+Mn8IaD8cxBLqXfBvL3hPmmnRJVqyGb/fFRZgUiQ+K9ykqzi y0fTEh2j72PiseywwNnI4/HAJ2A5gQ0ZrYknPqCgyfrLgcEEmvJE1Y7bVZEj7BkSz1ce yW4FsgO1ttFY0XFz2A3D+DF3hEvesC6O2ic+XZXZu0fv/c1TrwCp93ogOzG7ceZ6gb1J 2biA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d7si1282964pln.460.2017.06.07.02.17.17; Wed, 07 Jun 2017 02:17:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751858AbdFGJQ4 (ORCPT + 25 others); Wed, 7 Jun 2017 05:16:56 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:6881 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbdFGJQv (ORCPT ); Wed, 7 Jun 2017 05:16:51 -0400 Received: from 172.30.72.53 (EHLO DGGEML404-HUB.china.huawei.com) ([172.30.72.53]) by dggrg02-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id AOX19734; Wed, 07 Jun 2017 17:16:26 +0800 (CST) Received: from localhost (10.177.23.32) by DGGEML404-HUB.china.huawei.com (10.3.17.39) with Microsoft SMTP Server id 14.3.301.0; Wed, 7 Jun 2017 17:16:17 +0800 From: Ding Tianhong To: , , , , , , , , , , , , , , , , , , , , , , , CC: Ding Tianhong Subject: [PATCH v3 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag Date: Wed, 7 Jun 2017 17:16:05 +0800 Message-ID: <1496826968-10152-1-git-send-email-dingtianhong@huawei.com> X-Mailer: git-send-email 1.8.5.2.msysgit.0 MIME-Version: 1.0 X-Originating-IP: [10.177.23.32] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.5937C46D.00F0, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: e1b14f1fe2eda8dd2ad3911ac833fcda Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some devices have problems with Transaction Layer Packets with the Relaxed Ordering Attribute set. This patch set adds a new PCIe Device Flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING, a set of PCI Quirks to catch some known devices with Relaxed Ordering issues, and a use of this new flag by the cxgb4 driver to avoid using Relaxed Ordering with problematic Root Complex Ports. It's been years since I've submitted kernel.org patches, I appolgise for the almost certain submission errors. v2: Alexander point out that the v1 was only a part of the whole solution, some platform which has some issues could use the new flag to indicate that it is not safe to enable relaxed ordering attribute, then we need to clear the relaxed ordering enable bits in the PCI configuration when initializing the device. So add a new second patch to modify the PCI initialization code to clear the relaxed ordering enable bit in the event that the root complex doesn't want relaxed ordering enabled. The third patch was base on the v1's second patch and only be changed to query the relaxed ordering enable bit in the PCI configuration space to allow the Chelsio NIC to send TLPs with the relaxed ordering attributes set. This version didn't plan to drop the defines for Intel Drivers to use the new checking way to enable relaxed ordering because it is not the hardest part of the moment, we could fix it in next patchset when this patches reach the goal. v3: Redesigned the logic for pci_configure_relaxed_ordering when configuration, If a PCIe device didn't enable the relaxed ordering attribute default, we should not do anything in the PCIe configuration, otherwise we should check if any of the devices above us do not support relaxed ordering by the PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag, then base on the result if we get a return that indicate that the relaxed ordering is not supported we should update our device to disable relaxed ordering in configuration space. If the device above us doesn't exist or isn't the PCIe device, we shouldn't do anything and skip updating relaxed ordering because we are probably running in a guest. Casey Leedom (2): PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING net/cxgb4: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag Ding Tianhong (1): PCI: Enable PCIe Relaxed Ordering if supported drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 17 ++++++++++ drivers/net/ethernet/chelsio/cxgb4/sge.c | 5 +-- drivers/pci/pci.c | 29 +++++++++++++++++ drivers/pci/probe.c | 43 +++++++++++++++++++++++++ drivers/pci/quirks.c | 38 ++++++++++++++++++++++ include/linux/pci.h | 4 +++ 7 files changed, 135 insertions(+), 2 deletions(-) -- 1.9.0