From patchwork Mon Mar 4 08:22:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Lo X-Patchwork-Id: 777954 Received: from mail.kevlo.org (mail.kevlo.org [220.134.220.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6931C171AF for ; Mon, 4 Mar 2024 08:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.134.220.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709540524; cv=none; b=uaM2m5+mUXsBKYJ7dGrIh7dQ4AgHlv8V4+AV132FzmIUiAxndrCtKiKNwPHxSxdq+EuJlE7ynXxgIvmRQEm1hUHCNe4MNr//qRrX9jIs92MIMcOMLWRFwodga3dJUYoZ34SHZlh968b88rBA8MhjkkLuJtqftYRPAk7xQ00/P9U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709540524; c=relaxed/simple; bh=71ZK4g1MeT75y19WsqXFQT1Zj55AUp39uYBT0Fbz4pI=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=gkNSjMr4q6FaHenEfnlDWBtUYySTzriq0Zo74ar/sGc9j7tdW3N/q7OR9jFbCRnpEvDsMlssJCSw3z4r4v9WjRpgm/CmwKVSImb6MO3bv/qVgF7PDD3qur2GokklArkZnGIDmmScH5B7C1XixL7N+Iamp2r2dEf1SGmrRRHuzVI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kevlo.org; spf=pass smtp.mailfrom=kevlo.org; arc=none smtp.client-ip=220.134.220.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kevlo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kevlo.org Received: from localhost (ns.kevlo.org [local]) by ns.kevlo.org (OpenSMTPD) with ESMTPA id 07a1ee66; Mon, 4 Mar 2024 16:22:00 +0800 (CST) Date: Mon, 4 Mar 2024 16:22:00 +0800 From: Kevin Lo To: ath11k@lists.infradead.org Cc: Jeff Johnson , Kalle Valo , linux-wireless@vger.kernel.org Subject: [PATCH v2] wifi: ath11k: adjust a comment to reflect reality Message-ID: Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline On QCA6390/QCN9074/WCN6855, MHISTATUS may still have SYSERR bit set after SOC_GLOBAL_RESET. changes for v2: - update comment about resetting MHICTRL to clear SYSERR Signed-off-by: Kevin Lo Acked-by: Jeff Johnson --- diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c index fb4ecf9a103e..956fff0d4962 100644 --- a/drivers/net/wireless/ath/ath11k/mhi.c +++ b/drivers/net/wireless/ath/ath11k/mhi.c @@ -158,9 +158,8 @@ void ath11k_mhi_set_mhictrl_reset(struct ath11k_base *ab) ath11k_dbg(ab, ATH11K_DBG_PCI, "mhistatus 0x%x\n", val); - /* Observed on QCA6390 that after SOC_GLOBAL_RESET, MHISTATUS - * has SYSERR bit set and thus need to set MHICTRL_RESET - * to clear SYSERR. + /* After SOC_GLOBAL_RESET, MHISTATUS may still have SYSERR bit set + * and thus need to set MHICTRL_RESET to clear SYSERR. */ ath11k_pcic_write32(ab, MHICTRL, MHICTRL_RESET_MASK);