From patchwork Tue May 6 11:55:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 888533 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68CE427C153; Tue, 6 May 2025 11:56:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746532612; cv=none; b=t+opY2Aehvzb6m4kmJE9YVncBgyChfz80eDWhob7tEYG+SOhdQgdPj6N7JrbPiZ4VNQ/jI2huWV+jNqYGOOiar07PN+bXgUhbglvg4up3KLPePM6mmod/mAm0BLIg+3Yn9vZd/TZLq4HnYEeOMdKsKFRUjjFU7T7fhlQPm24eDM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746532612; c=relaxed/simple; bh=wEwUv++zHwmlk3siwS63rhWQRc7vYZ9kaT/NCb8Ytcw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dGkSsaJledvNPWi4QUujO3jMLYs5d7mU/ST1awr0Qd5yWTzw98+Gx+wFhnojnmNRwpWvEGvW7epbC2GoeFlr4qbfieMBMW9bfvUSTHj0mhV8LtPkghsaD1wY6Pma5SBSEYabb1R4/36aBl8AcfeHb9Y/O6MuQ1InY1EuzNF9ZXI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=eTCfCT8f; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="eTCfCT8f" Received: from fedora.intra.ispras.ru (unknown [10.10.165.23]) by mail.ispras.ru (Postfix) with ESMTPSA id 78F8A4076186; Tue, 6 May 2025 11:56:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 78F8A4076186 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1746532600; bh=CdKhF1dz8le1BxUGeNhnXLgthKYZanVP+D2h7mGr3gs=; h=From:To:Cc:Subject:Date:From; b=eTCfCT8fjeYYEb7Sg7xO68w3ygdO+aRNtTSnkV8u9DFbD1ndgqqpYgp7Nhtln5+bS fNJo+TT+RocYX+O+0X4eUWok1gHeDxcrLGo7g9v/IKbS1q2Oz5hJBKvqgWLTOXETiE 3jjysTAqCXftL/AA08mnxqgvdICd52qpvp5JdenM= From: Fedor Pchelkin To: Felix Fietkau , Lorenzo Bianconi Cc: Fedor Pchelkin , Ryder Lee , Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Jakub Kicinski , Joe Damato , Eric Dumazet , lvc-project@linuxtesting.org, stable@vger.kernel.org Subject: [PATCH] wifi: mt76: disable napi on driver removal Date: Tue, 6 May 2025 14:55:39 +0300 Message-ID: <20250506115540.19045-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 A warning on driver removal started occurring after commit 9dd05df8403b ("net: warn if NAPI instance wasn't shut down"). Disable tx napi before deleting it in mt76_dma_cleanup(). WARNING: CPU: 4 PID: 18828 at net/core/dev.c:7288 __netif_napi_del_locked+0xf0/0x100 CPU: 4 UID: 0 PID: 18828 Comm: modprobe Not tainted 6.15.0-rc4 #4 PREEMPT(lazy) Hardware name: ASUS System Product Name/PRIME X670E-PRO WIFI, BIOS 3035 09/05/2024 RIP: 0010:__netif_napi_del_locked+0xf0/0x100 Call Trace: mt76_dma_cleanup+0x54/0x2f0 [mt76] mt7921_pci_remove+0xd5/0x190 [mt7921e] pci_device_remove+0x47/0xc0 device_release_driver_internal+0x19e/0x200 driver_detach+0x48/0x90 bus_remove_driver+0x6d/0xf0 pci_unregister_driver+0x2e/0xb0 __do_sys_delete_module.isra.0+0x197/0x2e0 do_syscall_64+0x7b/0x160 entry_SYSCALL_64_after_hwframe+0x76/0x7e Tested with mt7921e but the same pattern can be actually applied to other mt76 drivers calling mt76_dma_cleanup() during removal. Tx napi is enabled in their *_dma_init() functions and only toggled off and on again inside their suspend/resume/reset paths. So it should be okay to disable tx napi in such a generic way. Found by Linux Verification Center (linuxtesting.org). Fixes: 2ac515a5d74f ("mt76: mt76x02: use napi polling for tx cleanup") Cc: stable@vger.kernel.org Signed-off-by: Fedor Pchelkin --- drivers/net/wireless/mediatek/mt76/dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/mediatek/mt76/dma.c b/drivers/net/wireless/mediatek/mt76/dma.c index 844af16ee551..35b4ec91979e 100644 --- a/drivers/net/wireless/mediatek/mt76/dma.c +++ b/drivers/net/wireless/mediatek/mt76/dma.c @@ -1011,6 +1011,7 @@ void mt76_dma_cleanup(struct mt76_dev *dev) int i; mt76_worker_disable(&dev->tx_worker); + napi_disable(&dev->tx_napi); netif_napi_del(&dev->tx_napi); for (i = 0; i < ARRAY_SIZE(dev->phys); i++) {