diff mbox series

[1/3] wifi: rtlwifi: Remove unused rtl_usb_{resume|suspend}

Message ID 20250425235340.288340-2-linux@treblig.org
State New
Headers show
Series rtlwifi deadcoding | expand

Commit Message

Dr. David Alan Gilbert April 25, 2025, 11:53 p.m. UTC 
From: "Dr. David Alan Gilbert" <linux@treblig.org>

rtl_usb_resume() and rtl_usb_suspend() are trivial stubs that were
added in 2011's
commit 2ca20f79e0d8 ("rtlwifi: Add usb driver")
but aren't wired up anywhere (though commit 442888c706e9 ("rtlwifi:
rtl8192cu: Add routines dm, fw, led and sw")  added commented
out assignments).

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/net/wireless/realtek/rtlwifi/usb.c | 12 ------------
 drivers/net/wireless/realtek/rtlwifi/usb.h |  2 --
 2 files changed, 14 deletions(-)

Comments

Ping-Ke Shih May 5, 2025, 1:31 a.m. UTC | #1 
linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> rtl_usb_resume() and rtl_usb_suspend() are trivial stubs that were
> added in 2011's
> commit 2ca20f79e0d8 ("rtlwifi: Add usb driver")
> but aren't wired up anywhere (though commit 442888c706e9 ("rtlwifi:
> rtl8192cu: Add routines dm, fw, led and sw")  added commented
> out assignments).
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

3 patch(es) applied to rtw-next branch of rtw.git, thanks.

d559636e382a wifi: rtlwifi: Remove unused rtl_usb_{resume|suspend}
2d867b18eb93 wifi: rtlwifi: Remove uncalled stub rtl*_phy_ap_calibrate
406dac790c25 wifi: rtlwifi: Remove unused rtl_bb_delay()

---
https://github.com/pkshih/rtw.git
Dr. David Alan Gilbert May 5, 2025, 1:39 a.m. UTC | #2 
* Ping-Ke Shih (pkshih@realtek.com) wrote:
> linux@treblig.org wrote:
> 
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > rtl_usb_resume() and rtl_usb_suspend() are trivial stubs that were
> > added in 2011's
> > commit 2ca20f79e0d8 ("rtlwifi: Add usb driver")
> > but aren't wired up anywhere (though commit 442888c706e9 ("rtlwifi:
> > rtl8192cu: Add routines dm, fw, led and sw")  added commented
> > out assignments).
> > 
> > Remove them.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> 3 patch(es) applied to rtw-next branch of rtw.git, thanks.
> 
> d559636e382a wifi: rtlwifi: Remove unused rtl_usb_{resume|suspend}
> 2d867b18eb93 wifi: rtlwifi: Remove uncalled stub rtl*_phy_ap_calibrate
> 406dac790c25 wifi: rtlwifi: Remove unused rtl_bb_delay()

Thanks!
Did you see the question in the 0/3 cover letter asking why
rtl8188ee_bt_hw_init() isn't called?

Dave

> ---
> https://github.com/pkshih/rtw.git
>
Ping-Ke Shih May 5, 2025, 2:07 a.m. UTC | #3 
> Did you see the question in the 0/3 cover letter asking why
> rtl8188ee_bt_hw_init() isn't called?

Checked vendor driver. For RTL8188E, only USB interface implements this function,
but no caller. The PCI interface doesn't support Bluetooth.

I think you can find the vendor drivers in github or somewhere. That's not
too hard to address this.
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c
index f5718e570011..d35ed56d6db9 100644
--- a/drivers/net/wireless/realtek/rtlwifi/usb.c
+++ b/drivers/net/wireless/realtek/rtlwifi/usb.c
@@ -1077,15 +1077,3 @@  void rtl_usb_disconnect(struct usb_interface *intf)
 	ieee80211_free_hw(hw);
 }
 EXPORT_SYMBOL(rtl_usb_disconnect);
-
-int rtl_usb_suspend(struct usb_interface *pusb_intf, pm_message_t message)
-{
-	return 0;
-}
-EXPORT_SYMBOL(rtl_usb_suspend);
-
-int rtl_usb_resume(struct usb_interface *pusb_intf)
-{
-	return 0;
-}
-EXPORT_SYMBOL(rtl_usb_resume);
diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.h b/drivers/net/wireless/realtek/rtlwifi/usb.h
index b66d6f9ae564..b873bbc9c4c2 100644
--- a/drivers/net/wireless/realtek/rtlwifi/usb.h
+++ b/drivers/net/wireless/realtek/rtlwifi/usb.h
@@ -138,7 +138,5 @@  int rtl_usb_probe(struct usb_interface *intf,
 		  const struct usb_device_id *id,
 		  const struct rtl_hal_cfg *rtl92cu_hal_cfg);
 void rtl_usb_disconnect(struct usb_interface *intf);
-int rtl_usb_suspend(struct usb_interface *pusb_intf, pm_message_t message);
-int rtl_usb_resume(struct usb_interface *pusb_intf);
 
 #endif