From patchwork Mon Jan 27 16:26:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Wetzel X-Patchwork-Id: 860351 Received: from ns2.wdyn.eu (ns2.wdyn.eu [5.252.227.236]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 96B52156968 for ; Mon, 27 Jan 2025 16:28:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.252.227.236 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737995310; cv=none; b=RuwRyfGHqqg1KDr51oVaQ9tVFRLNVpb4ms587O950HO7ZFcgQPr+SlhhLyp+0W+vyaDIUOiVkPackNbiqFhx+twepswVDCn/13RwQHDuPvjXPP1yzJqwfJnhSmwt2O32owvtpFi53gTgzIa5zzNY9+97evw9fqQrzNsLwgzys0s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737995310; c=relaxed/simple; bh=z6mnBU3xaoXhwth5x4w3+gbUAHtCzp/KsUrD78p4jW0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qx8wkVpyHFyJ+pKH++EfpSl/e6XDcM7mlbSGiEozNGr3i/DATyPzb33EhrT0hpgFDnQcWkzKPZqwxx5RGuYerb9TeifEWRWTYnXeWPYhksF59yX6WJ+PAkdUhGC6Dr8ZpqBCoLozMVGohoy+UwCQcHQ7VRR0xAOJ0hLReZystwM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wetzel-home.de; spf=pass smtp.mailfrom=wetzel-home.de; dkim=pass (1024-bit key) header.d=wetzel-home.de header.i=@wetzel-home.de header.b=Bm4JkkRW; arc=none smtp.client-ip=5.252.227.236 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wetzel-home.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wetzel-home.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=wetzel-home.de header.i=@wetzel-home.de header.b="Bm4JkkRW" From: Alexander Wetzel DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wetzel-home.de; s=wetzel-home; t=1737995298; bh=z6mnBU3xaoXhwth5x4w3+gbUAHtCzp/KsUrD78p4jW0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Bm4JkkRWLsuS14To0WFo1D/NedtNwXiXLGtQXO98dYNcrMSMGjObrMk/rrYlV58RN EUK3LI7IxeD5z0p1Zyfm8QitWfq+u29ufZmLZ41+TxX2u4caBj20zNFg7BYVwUoeCM zKHw83gmTc/AbR1hdBLj0HA71f6yVn7YjdNXBpcs= To: linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net, Alexander Wetzel Subject: [RFC PATCH 09/13] wifi: mac80211: Rename IEEE80211_TX_INTFL_OFFCHAN_TX_OK Date: Mon, 27 Jan 2025 17:26:21 +0100 Message-ID: <20250127162625.20747-10-Alexander@wetzel-home.de> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250127162625.20747-1-Alexander@wetzel-home.de> References: <20250127162625.20747-1-Alexander@wetzel-home.de> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To make it clear that IEEE80211_TX_INTFL_OFFCHAN_TX_OK is now selecting the alternate TX path in mac80211 - which immediately sends the frame - the flag is renamed to IEEE80211_TX_INTFL_NOQUEUE_TX. Signed-off-by: Alexander Wetzel --- include/net/mac80211.h | 8 ++++---- net/mac80211/mlme.c | 2 +- net/mac80211/offchannel.c | 2 +- net/mac80211/rx.c | 2 +- net/mac80211/scan.c | 2 +- net/mac80211/tx.c | 6 +++--- net/mac80211/util.c | 2 +- 7 files changed, 12 insertions(+), 12 deletions(-) diff --git a/include/net/mac80211.h b/include/net/mac80211.h index 41d91d69d61f..bec465595d41 100644 --- a/include/net/mac80211.h +++ b/include/net/mac80211.h @@ -897,9 +897,9 @@ struct ieee80211_bss_conf { * @IEEE80211_TX_CTL_RATE_CTRL_PROBE: internal to mac80211, can be * set by rate control algorithms to indicate probe rate, will * be cleared for fragmented frames (except on the last fragment) - * @IEEE80211_TX_INTFL_OFFCHAN_TX_OK: Internal to mac80211. Used to indicate - * that a frame can be transmitted while the queues are stopped for - * off-channel operation. + * @IEEE80211_TX_INTFL_NOQUEUE_TX: Internal to mac80211. Indicates that a frame + * can't be queued and must be transmitted immediately. Frames with this + * flag ignore offchannel queue stops and bypass wake_tx_queue(). * @IEEE80211_TX_CTL_HW_80211_ENCAP: This frame uses hardware encapsulation * (header conversion) * @IEEE80211_TX_INTFL_RETRIED: completely internal to mac80211, @@ -969,7 +969,7 @@ enum mac80211_tx_info_flags { IEEE80211_TX_STAT_AMPDU = BIT(10), IEEE80211_TX_STAT_AMPDU_NO_BACK = BIT(11), IEEE80211_TX_CTL_RATE_CTRL_PROBE = BIT(12), - IEEE80211_TX_INTFL_OFFCHAN_TX_OK = BIT(13), + IEEE80211_TX_INTFL_NOQUEUE_TX = BIT(13), IEEE80211_TX_CTL_HW_80211_ENCAP = BIT(14), IEEE80211_TX_INTFL_RETRIED = BIT(15), IEEE80211_TX_INTFL_DONT_ENCRYPT = BIT(16), diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 61c318f5239f..757df176c678 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -2033,7 +2033,7 @@ void ieee80211_send_nullfunc(struct ieee80211_local *local, nullfunc->frame_control |= cpu_to_le16(IEEE80211_FCTL_PM); IEEE80211_SKB_CB(skb)->flags |= IEEE80211_TX_INTFL_DONT_ENCRYPT | - IEEE80211_TX_INTFL_OFFCHAN_TX_OK; + IEEE80211_TX_INTFL_NOQUEUE_TX; if (ieee80211_hw_check(&local->hw, REPORTS_TX_ACK_STATUS)) IEEE80211_SKB_CB(skb)->flags |= IEEE80211_TX_CTL_REQ_TX_STATUS; diff --git a/net/mac80211/offchannel.c b/net/mac80211/offchannel.c index 29fab7ae47b4..85c27df0f423 100644 --- a/net/mac80211/offchannel.c +++ b/net/mac80211/offchannel.c @@ -1026,7 +1026,7 @@ int ieee80211_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev, } IEEE80211_SKB_CB(skb)->flags |= IEEE80211_TX_CTL_TX_OFFCHAN | - IEEE80211_TX_INTFL_OFFCHAN_TX_OK; + IEEE80211_TX_INTFL_NOQUEUE_TX; if (ieee80211_hw_check(&local->hw, QUEUE_CONTROL)) IEEE80211_SKB_CB(skb)->hw_queue = local->hw.offchannel_tx_hw_queue; diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 58c1b9a4e8b5..fa4d9a270de9 100644 --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c @@ -3970,7 +3970,7 @@ ieee80211_rx_h_action_return(struct ieee80211_rx_data *rx) struct ieee80211_tx_info *info = IEEE80211_SKB_CB(nskb); info->flags = IEEE80211_TX_CTL_TX_OFFCHAN | - IEEE80211_TX_INTFL_OFFCHAN_TX_OK | + IEEE80211_TX_INTFL_NOQUEUE_TX | IEEE80211_TX_CTL_NO_CCK_RATE; if (ieee80211_hw_check(&local->hw, QUEUE_CONTROL)) info->hw_queue = diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c index 4eb0cf5f73ca..ff81bf3d2781 100644 --- a/net/mac80211/scan.c +++ b/net/mac80211/scan.c @@ -668,7 +668,7 @@ static void ieee80211_scan_state_send_probe(struct ieee80211_local *local, scan_req = rcu_dereference_protected(local->scan_req, lockdep_is_held(&local->hw.wiphy->mtx)); - tx_flags = IEEE80211_TX_INTFL_OFFCHAN_TX_OK; + tx_flags = IEEE80211_TX_INTFL_NOQUEUE_TX; if (scan_req->no_cck) tx_flags |= IEEE80211_TX_CTL_NO_CCK_RATE; if (scan_req->flags & NL80211_SCAN_FLAG_MIN_PREQ_CONTENT) diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index 748edc3dc63a..065c139eca92 100644 --- a/net/mac80211/tx.c +++ b/net/mac80211/tx.c @@ -230,7 +230,7 @@ ieee80211_tx_h_dynamic_ps(struct ieee80211_tx_data *tx) if (tx->sdata->vif.type != NL80211_IFTYPE_STATION) return TX_CONTINUE; - if (unlikely(info->flags & IEEE80211_TX_INTFL_OFFCHAN_TX_OK)) + if (unlikely(info->flags & IEEE80211_TX_INTFL_NOQUEUE_TX)) return TX_CONTINUE; ifmgd = &tx->sdata->u.mgd; @@ -1300,7 +1300,7 @@ static struct txq_info *ieee80211_get_txq(struct ieee80211_local *local, struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb); struct ieee80211_txq *txq = NULL; - if (unlikely(info->flags & IEEE80211_TX_INTFL_OFFCHAN_TX_OK)) { + if (unlikely(info->flags & IEEE80211_TX_INTFL_NOQUEUE_TX)) { if (sta) txq = sta->sta.txq[IEEE80211_TXQ_NOQUEUE]; else @@ -1817,7 +1817,7 @@ static void ieee80211_tx(struct ieee80211_sub_if_data *sdata, struct ieee80211_tx_data tx; ieee80211_tx_result res_prepare; struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb); - bool noqueue = info->flags & IEEE80211_TX_INTFL_OFFCHAN_TX_OK; + bool noqueue = info->flags & IEEE80211_TX_INTFL_NOQUEUE_TX; struct ieee80211_tx_control control; struct txq_info *txqi; diff --git a/net/mac80211/util.c b/net/mac80211/util.c index 811448c096a6..ef7d482d1984 100644 --- a/net/mac80211/util.c +++ b/net/mac80211/util.c @@ -1183,7 +1183,7 @@ void ieee80211_send_deauth_disassoc(struct ieee80211_sub_if_data *sdata, */ IEEE80211_SKB_CB(skb)->flags |= IEEE80211_TX_INTFL_DONT_ENCRYPT | - IEEE80211_TX_INTFL_OFFCHAN_TX_OK; + IEEE80211_TX_INTFL_NOQUEUE_TX; ieee80211_tx_skb(sdata, skb); }