From patchwork Mon Nov 4 17:24:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Issam Hamdi X-Patchwork-Id: 840751 Received: from mail.simonwunderlich.de (mail.simonwunderlich.de [23.88.38.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1FBA17583 for ; Mon, 4 Nov 2024 17:24:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.38.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730741065; cv=none; b=Wt0IXU8yRbk1JMTwnKyGioQPsHl2qcFmG+SymIyu5CEREC7USxoFkjg/eBK25cLj8u4NpzdZrgbPMX1yAr97PDVlbrr5iq7jxy4PDfjtyjbuXH1gj9B/1E4jTzHEzhjQ2rRYkFIlLkojIzxZd09hfIfOgBGvwsuHG1pzByjLvwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730741065; c=relaxed/simple; bh=oNGMLLSQaPNVDdjqNc6zEqsZMo+vRclvAHVF/R4eaeU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=BEcVbEe9y8+hav48zVPOBjVYh5n8D+ZzYOXBNdsSKRT1qgfyP6bN3JTSBq1jnhmHdXo2LLvQGkFtPw3a5pUTT19cxvFhPYZcghSy+O/J8O5MvCENB6GHnLLoPSCKganHBKs4S5p+go7Zl3e20hlqTQJmKKRJnadduB/qixevCLc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=simonwunderlich.de; spf=pass smtp.mailfrom=simonwunderlich.de; arc=none smtp.client-ip=23.88.38.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=simonwunderlich.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=simonwunderlich.de Received: from localhost (p200300C59740c190000000000000032B.dip0.t-ipconnect.de [IPv6:2003:c5:9740:c190::32b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.simonwunderlich.de (Postfix) with ESMTPSA id D587CFAA33; Mon, 4 Nov 2024 18:24:19 +0100 (CET) From: Issam Hamdi To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, sw@simonwunderlich.de, Issam Hamdi , Kretschmer Mathias Subject: [PATCH] wifi: mac80211: fix mbss changed flags corruption on 32 bit systems Date: Mon, 4 Nov 2024 18:24:15 +0100 Message-Id: <20241104172415.3790038-1-ih@simonwunderlich.de> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On 32-bit systems, the size of an unsigned long is 4 bytes, while a u64 is 8 bytes. Therefore, when using or_each_set_bit(bit, &bits, sizeof(changed) * BITS_PER_BYTE), the code is incorrectly searching for a bit in a 32-bit variable that is expected to be 64 bits in size, leading to incorrect bit finding. Solution: Ensure that the size of the bits variable is correctly adjusted for each architecture. Call Trace: ? show_regs+0x54/0x58 ? __warn+0x6b/0xd4 ? ieee80211_link_info_change_notify+0xcc/0xd4 [mac80211] ? report_bug+0x113/0x150 ? exc_overflow+0x30/0x30 ? handle_bug+0x27/0x44 ? exc_invalid_op+0x18/0x50 ? handle_exception+0xf6/0xf6 ? exc_overflow+0x30/0x30 ? ieee80211_link_info_change_notify+0xcc/0xd4 [mac80211] ? exc_overflow+0x30/0x30 ? ieee80211_link_info_change_notify+0xcc/0xd4 [mac80211] ? ieee80211_mesh_work+0xff/0x260 [mac80211] ? cfg80211_wiphy_work+0x72/0x98 [cfg80211] ? process_one_work+0xf1/0x1fc ? worker_thread+0x2c0/0x3b4 ? kthread+0xc7/0xf0 ? mod_delayed_work_on+0x4c/0x4c ? kthread_complete_and_exit+0x14/0x14 ? ret_from_fork+0x24/0x38 ? kthread_complete_and_exit+0x14/0x14 ? ret_from_fork_asm+0xf/0x14 ? entry_INT80_32+0xf0/0xf0 Reported-by: Kretschmer Mathias Signed-off-by: Issam Hamdi --- net/mac80211/mesh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 2b94751626a6d49bbe42a19cc1503bd391016bd5 diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c index cb5f16366b9c..39cdbc11f540 100644 --- a/net/mac80211/mesh.c +++ b/net/mac80211/mesh.c @@ -1164,7 +1164,7 @@ void ieee80211_mbss_info_change_notify(struct ieee80211_sub_if_data *sdata, return; /* if we race with running work, worst case this work becomes a noop */ - for_each_set_bit(bit, &bits, sizeof(changed) * BITS_PER_BYTE) + for_each_set_bit(bit, &bits, sizeof(bits) * BITS_PER_BYTE) set_bit(bit, ifmsh->mbss_changed); set_bit(MESH_WORK_MBSS_CHANGED, &ifmsh->wrkq_flags); wiphy_work_queue(sdata->local->hw.wiphy, &sdata->work);