From patchwork Wed Aug 21 15:37:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 821313 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E591014E2C9 for ; Wed, 21 Aug 2024 15:37:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724254655; cv=none; b=reSx5iO/Ws2NJ+1gVb6qVSX5W1jH8UiHnUQtBql6q0cZKWtba1FhxhYhYJo/d34iJY/fOIxPJoe65FueRr4j/bOo9e1eqzbYWVUT5YMBExLGsb15CNwDg+3PoRgYPKa7Hx+1PrFB9Q/wiEulKPnEYs5laVe175fKJAjleOC9dn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724254655; c=relaxed/simple; bh=yI+XTxfRTeCU0R+EJ6nKBT0kQiUN1oBcf83r56C2ztE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=l/KsjGYbzuiVD1rMPMOLmQzOYQCp6AXNpT3fYH+o4WgzbgYxICvpiRDaYww1LJO8IeUktu/zzYGD4+gxOrOHDtFmvr789k+dVS/4v4qF9QfC8QMFyXrvxOeQAlIORz7XlSGi1UueqE+2z78HoW86Bw0qrcBfBwFAneCKc3qKtG0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EPPTfZ2l; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EPPTfZ2l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 309F1C4AF09; Wed, 21 Aug 2024 15:37:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724254654; bh=yI+XTxfRTeCU0R+EJ6nKBT0kQiUN1oBcf83r56C2ztE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EPPTfZ2lbMdeQ3aX+X0dWZ81vrJTa3VmJLWFUaQDvyj/5IUqnj8bU/9eI9No0OeSe cmMrBSijO6pEnqzgJkljPGuyh0ou0eoJf2rL21CgKKqyPNgdk9HHHPWFFcJLiL2MId r1JABW3GOk2rkOakuQqDguRSUuV0kCUFFVaYh2c3Iy7axzUoJxC2kYwqtniyVnotTL VuaP2FFH9CqYkv6UjQKC511jNZOvlV0oCDic89O6MYj/9pcplotlKF1kmKspw5BQfN ne1VMbtg3r8Dg0i/f6QVEl+fCzDCkSez+oAUoX5Pdls0BOn1gB+dB0BVhGwePjipLf l9bspKnstX5Rw== From: Kalle Valo To: ath12k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: [PATCH RFC 3/4] wifi: ath12k: ath12k_mac_op_set_key(): remove exit label Date: Wed, 21 Aug 2024 18:37:27 +0300 Message-Id: <20240821153728.2121600-4-kvalo@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240821153728.2121600-1-kvalo@kernel.org> References: <20240821153728.2121600-1-kvalo@kernel.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Kalle Valo In ath12k_mac_op_set_key() removing the exit label was a bit more complex as checkpatch complained about the unnecessary else branch after a return. So remove the else branch and remove now the unncessary ret initialisation. Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath12k/mac.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index a9d37a59a8c2..80db9004cdd7 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -3942,7 +3942,7 @@ static int ath12k_mac_set_key(struct ath12k *ar, enum set_key_cmd cmd, struct ath12k_peer *peer; struct ath12k_sta *arsta; const u8 *peer_addr; - int ret = 0; + int ret; u32 flags = 0; lockdep_assert_wiphy(ath12k_ar_to_hw(ar)->wiphy); @@ -3970,14 +3970,13 @@ static int ath12k_mac_set_key(struct ath12k *ar, enum set_key_cmd cmd, if (cmd == SET_KEY) { ath12k_warn(ab, "cannot install key for non-existent peer %pM\n", peer_addr); - ret = -EOPNOTSUPP; - goto exit; - } else { - /* if the peer doesn't exist there is no key to disable - * anymore - */ - goto exit; + return -EOPNOTSUPP; } + + /* if the peer doesn't exist there is no key to disable + * anymore + */ + return 0; } if (key->flags & IEEE80211_KEY_FLAG_PAIRWISE) @@ -3988,13 +3987,13 @@ static int ath12k_mac_set_key(struct ath12k *ar, enum set_key_cmd cmd, ret = ath12k_install_key(arvif, key, cmd, peer_addr, flags); if (ret) { ath12k_warn(ab, "ath12k_install_key failed (%d)\n", ret); - goto exit; + return ret; } ret = ath12k_dp_rx_peer_pn_replay_config(arvif, peer_addr, cmd, key); if (ret) { ath12k_warn(ab, "failed to offload PN replay detection %d\n", ret); - goto exit; + return ret; } spin_lock_bh(&ab->base_lock); @@ -4040,8 +4039,7 @@ static int ath12k_mac_set_key(struct ath12k *ar, enum set_key_cmd cmd, spin_unlock_bh(&ab->base_lock); -exit: - return ret; + return 0; } static int ath12k_mac_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,