From patchwork Fri Nov 4 16:42:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 621695 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C518C433FE for ; Fri, 4 Nov 2022 16:43:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbiKDQmb (ORCPT ); Fri, 4 Nov 2022 12:42:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231670AbiKDQm3 (ORCPT ); Fri, 4 Nov 2022 12:42:29 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D1392BB0A for ; Fri, 4 Nov 2022 09:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=DpHIi5tZ6MwSVeJOrc7HmVv8DL/h3HPhxiYwS/vIpdU=; t=1667580147; x=1668789747; b=kMcIIy/hVzwG+oFgp6a/swiLvIt4RnXvhlUcu4X1TRHBycd UPlge8F30WXVlrMZ4o/yPQSFwWFixCroZyZAZGePW1oxpYnWxTqsKbRN9mms25s3DvBaqa7h1nPZa H6VZOvohjpWqpOVR0j5mGj9i8Wrjgf3SbtWkYECnqb0p4gk9DgfjjlNLL8yugdpRhM7YyRrLlmjZ4 VNwmEPyJFdljQHucmGuvJYJ6pnDokFcYDTNebXYge59ZQXQMxqxqswrRv2kpemaWijVvntybMbdh1 hUp8xUJIgYqyywdUrYbGQSIIvCZtJaSHZwR6TpJlg+PIOf1Ca0xcnW5OVBgKM0xQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1oqzlw-008v9Z-2X; Fri, 04 Nov 2022 17:42:24 +0100 From: Johannes Berg To: linux-wireless@vger.kernel.org Cc: Johannes Berg Subject: [RFC PATCH 2/2] wifi: wireless: deny wireless extensions on MLO-capable devices Date: Fri, 4 Nov 2022 17:42:21 +0100 Message-Id: <20221104174218.7817a3abaf39.Ib9eabc2ec5bf6b0244e4d973e93baaa3d8c91bd8@changeid> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221104174218.26f9541c0bfa.Ifcf30eeeb8fc7019e4dcf2782b04515254d165e1@changeid> References: <20221104174218.26f9541c0bfa.Ifcf30eeeb8fc7019e4dcf2782b04515254d165e1@changeid> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg These are new devices that will be introduced into the market in 2023, with new drivers. Wireless extensions haven't been in real development since 2006. Since wireless has evolved a lot, and continues to evolve significantly with MLO, there's really no good way to still support wireless extensions for devices that do MLO. Stop supporting wireless extensions for new devices. We don't consider this a regression since no such devices (apart from hwsim) exist yet. Signed-off-by: Johannes Berg --- net/wireless/wext-core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/wireless/wext-core.c b/net/wireless/wext-core.c index cbeb8be214a8..d3b5cf02690c 100644 --- a/net/wireless/wext-core.c +++ b/net/wireless/wext-core.c @@ -662,6 +662,8 @@ struct iw_statistics *get_wireless_stats(struct net_device *dev) dev->ieee80211_ptr->wiphy->wext && dev->ieee80211_ptr->wiphy->wext->get_wireless_stats) { wireless_warn_cfg80211_wext(); + if (dev->ieee80211_ptr->wiphy->flags & WIPHY_FLAG_SUPPORTS_MLO) + return NULL; return dev->ieee80211_ptr->wiphy->wext->get_wireless_stats(dev); } #endif @@ -702,6 +704,8 @@ static iw_handler get_handler(struct net_device *dev, unsigned int cmd) #ifdef CONFIG_CFG80211_WEXT if (dev->ieee80211_ptr && dev->ieee80211_ptr->wiphy) { wireless_warn_cfg80211_wext(); + if (dev->ieee80211_ptr->wiphy->flags & WIPHY_FLAG_SUPPORTS_MLO) + return NULL; handlers = dev->ieee80211_ptr->wiphy->wext; } #endif