From patchwork Mon Oct 25 09:30:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 516152 Delivered-To: patch@linaro.org Received: by 2002:ad5:4292:0:0:0:0:0 with SMTP id z18csp41441imn; Mon, 25 Oct 2021 02:29:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz30FvUyTm9Je/sZIAJHX736324duExoJiNBRQbz/oV2rTqHzqjvNzyBeJfPQ+E+1dAqaAr X-Received: by 2002:a54:488c:: with SMTP id r12mr12014352oic.88.1635154174196; Mon, 25 Oct 2021 02:29:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635154174; cv=none; d=google.com; s=arc-20160816; b=BZgCYs9rdQE7W8sYaKEYAsti9dWLvjiks8Sf3gjxIl437AXwUBHlG8tqdVToprZEUQ F5v3aBH1huAlFhbnNPd+ZdehF0kZ9Yx/GW8HlY+aHQW16RuaTdIZWhpLMDPXdyVA2UaP PuRAM7L8o3ahgI3WrCGOhcClV4ZjeuAMlzsupkWuyoywHbLs9vtwrICIU6pOmFDKjBHQ PMybq7EpOG9odk+eEk5kzVBOX0WoESP0c0Y+g30reBM7FopVnGaxRMHItQvH4gPyXQAO 7Bib8bS5gnMgSU+7wXYu6wStwtYoxyfl0xv4pnbYzM4wYSb8eYJG7K6yE5tksWL5vHzd hAvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature; bh=PHXc0aK9VfHULGui4pf+XrqEWB04MWygKAVqEGEJmug=; b=HX6jX+iWsWLFxIyJMjyNivdMhyc7GUA8Q0IWOWaaynnaZMJUqpjnNpdh6dY0sWppju 3dmyxV80bhKZmGP4dWHaCNPxmy0dMausz5AHMof7qFbJ8A9M1qAhC++7rc+0bby+arTX oYRDrKHtxVE66BBK0EvDi6RKIq6fYgB6Loim+HIMIpgG/GuL3ME4ltF+VDsbsZsumY+y 6BqWKjOxumQeFsu25EdaHJ0oSh46wjzRqeiUREmbXUM2848sEAkOHXagW3R3dunvPWQs jFehlLnlDDbRB0Ve/khbnUmJ6wPIKWBYG2F2Utn3PuDEzzcZvn18UeufIPLiFxAtJo/q 0QxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b=Nm9yWmwe; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=J3nZxcvX; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id 12si16348039oth.75.2021.10.25.02.29.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 02:29:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b=Nm9yWmwe; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=J3nZxcvX; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PHXc0aK9VfHULGui4pf+XrqEWB04MWygKAVqEGEJmug=; b=Nm9yWmwezk1pMP 8eLHp3R0ZMVboBLcssrqeU6QTqXsvaGkooiyzOn6mHeFbtERoAlmN8zTmrn0mByTXjL0r8LAydpGL ehk8zxUF6yeqaVadr2Hyh6OTpimLEiBk0o7blGwgrPZswUQkQZVJgGr+nDBuTAqZNEFVz8wLQ2/pM 25/yH5gVMqx2s5iobGd6wCk1juaDgBADHJk0nJ0ZwGWnZwjz59lCEd/kkcfXzvdqyNBO22m1jWjEV ef7HIP7kX8xpedcdhW1WGgrGnCx5Vv7T0EWDJZO8UQCWHdAI73MeUfxbzoZg6rwctoBt2selIMtKT CKFXS9fa7ewZwSLLBVaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mewIO-00FvpJ-Ek; Mon, 25 Oct 2021 09:29:32 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mewHi-00FvZx-MI for wcn36xx@lists.infradead.org; Mon, 25 Oct 2021 09:28:52 +0000 Received: by mail-wm1-x335.google.com with SMTP id 83-20020a1c0456000000b0032cb02544aaso580180wme.5 for ; Mon, 25 Oct 2021 02:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+rQNWlf4wNQOqVerP6U4kFygwmmwAyb6RoFKtfexlzQ=; b=J3nZxcvXvGlij6iSelsEoadjVyySCb028xHESl/j2SV/muVSTw+B+P/7vuVbMejU+k tIqB+QIZJ2rmzRWgpWV6drpFY/DOVNrvVXJ2pkv1+1MBMGPx6YP+WPt5QvE/YrYbPjY0 w4tMHkYZYovxPry0s/8we8fpkwk1AiOSNicJfDYHtuw0ru7FWyDlnfSOftzadEiN9XGj n6NYN+mDp97vooQ4CD5QNacEXtMBguhmIrB/fIyaaPuR2P3bpZcKa6DerQSR8cxWj6Xe SBhU7wvSH9Vo3qXWlgTPVhplMLjHoBAxEyKMLAxnXY1k8DdpHjQjJmaWNHnrlKw/H5uZ 0fFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+rQNWlf4wNQOqVerP6U4kFygwmmwAyb6RoFKtfexlzQ=; b=75X+/nuU140jsKXQvbTDFBfU4dXOwaINaYOlWtwLBDUj3XnFFrnUxHyq/iiQVyFlPt SxJ4Qcu5Evw05WS1uralbzS8/b3ADdVIc6fDri/0vnVB3Q+IZcFjmhALGMUtluzCrSSE hv+dC+WRP/ZJTff8fY1D/pcozzCQQLTb1MthCKvhI5DBcE10MgAbJWudkGhLSfJ47K6Q c43atjBxW0NjQ9eRD1SiqDr6EhZXvO/+Nmub3qqIwvxOP2o6sBgJkbYVaM7dO9Y1zFLd Ubz+3hxMzkaOf1E3G0lBjizeKvbzApQ8k6OBn9g5X6dwcd3uMHiwHFZW+xUuHCf8T6J+ uk8w== X-Gm-Message-State: AOAM532sDq4q34bgoyJcrRULNz/EGMrZGIGHrqy9NfBQyIYmepmCCI9W 3howdd5AVguUvvABumi+6Vmu0Q== X-Received: by 2002:a05:600c:3581:: with SMTP id p1mr1629440wmq.34.1635154125688; Mon, 25 Oct 2021 02:28:45 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id z135sm20858853wmc.45.2021.10.25.02.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 02:28:45 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org Cc: loic.poulain@linaro.org, benl@squareup.com, daniel.thompson@linaro.org, bryan.odonoghue@linaro.org Subject: [PATCH v3 1/1] Revert "wcn36xx: Enable firmware link monitoring" Date: Mon, 25 Oct 2021 10:30:37 +0100 Message-Id: <20211025093037.3966022-2-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211025093037.3966022-1-bryan.odonoghue@linaro.org> References: <20211025093037.3966022-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_022850_765165_20284E74 X-CRM114-Status: GOOD ( 10.43 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Firmware link offload monitoring can be made to work in 3/4 cases by switching on firmware feature bit WLANACTIVE_OFFLOAD - Secure power-save on - Secure power-save off - Open power-save on However, with an open AP if we switch off power-saving - thus never entering Beacon Mode Power Save - BMPS, firmware never forwards loss of beacon upwards. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:335 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org Firmware link offload monitoring can be made to work in 3/4 cases by switching on firmware feature bit WLANACTIVE_OFFLOAD - Secure power-save on - Secure power-save off - Open power-save on However, with an open AP if we switch off power-saving - thus never entering Beacon Mode Power Save - BMPS, firmware never forwards loss of beacon upwards. We had hoped that WLANACTIVE_OFFLOAD and some fixes for sequence numbers would unblock this but, it hasn't and further investigation is required. Its possible to have a complete set of Secure power-save on/off and Open power-save on/off provided we use Linux' link monitoring mechanism. While we debug the Open AP failure we need to fix upstream. This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1. Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/main.c | 1 - 1 file changed, 1 deletion(-) -- 2.33.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index dd8810fd76a3d..fd8b2753da7dd 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -1334,7 +1334,6 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn) ieee80211_hw_set(wcn->hw, HAS_RATE_CONTROL); ieee80211_hw_set(wcn->hw, SINGLE_SCAN_ON_ALL_BANDS); ieee80211_hw_set(wcn->hw, REPORTS_TX_ACK_STATUS); - ieee80211_hw_set(wcn->hw, CONNECTION_MONITOR); wcn->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) | BIT(NL80211_IFTYPE_AP) |