From patchwork Mon Oct 18 23:17:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 515930 Delivered-To: patch@linaro.org Received: by 2002:ac0:cd8c:0:0:0:0:0 with SMTP id d12csp32671imp; Mon, 18 Oct 2021 16:15:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxu3/bQx1bqXXFfX/4yp/n6UMqqHbr8WW6A5Jaj26c7AU+xkFlwyTC6BW2Zx+3KlNgbYZms X-Received: by 2002:a9d:609b:: with SMTP id m27mr2280335otj.51.1634598933646; Mon, 18 Oct 2021 16:15:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634598933; cv=none; d=google.com; s=arc-20160816; b=Ot0joIJhcSaNOACkA8vMRf7gzZBJgzHWqYZqFcwXb9zZAFshuCcaFTWhfvaPPE64yJ i+70O7WlB/yWMbURiiWXthS1CWcWdOcjw65VCZiVvd0B88WAC1vTlgLIfQ+edUKqsGN1 ydIv2oV7WxVvTCwIzna1WR56wcVvF04qX0XqOzOMBsYW8Uh2z63apwwVCmhB6fhlise9 nw2dQx8HD3MmyVLbPhjiiouLJs35cPcpa4098Ki3tT8qhiCmpjK9ejLOvBMuonGXo8ie 0Z3qvfnbqWuH3/7N22yLpd1hfssPwqwpDwFi3wOenowptB6mpwY9zsP36sqnP8x9AGpb GHrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature; bh=Z2EhmtitNFkcrMvN/Vk7L7tappMnXEQJrmVPcBHgSDQ=; b=tX2Qo7ckruPnawJILzQItOBL/1tzKdjMJwG4/kVHdHTVrPBEZLVzCIL2JFl/BSWT2+ k6pV9/9mkLKo3DEDoOq6mWGHCC+NA+/zeDoCfqhBh6IojiakzVStmF2wbAf01KiA8TlV uYLepbBOFoqvoTmiwKOcIiFk5yiIFa6lgU8EJ7s7tIQZqrrFJE3nMMkeQ+Sb16PKRJwS +FEcVlpQ73cjhnM02Vrkq8feYpG1Z7Uf5i8vThJSoW2ODWn4Pnr+36rnBI6/Tc0Pe5pd RjrYZQAJlwLvQOnJKyFNt8hcu0j2/34tqvwH6nr58oB1dl0ZxjcA3KODpNwa7NpFNFMO LbnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b=5AsRKWuw; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HPfHLoDq; spf=neutral (google.com: 2607:7c80:54:e::133 is neither permitted nor denied by best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by mx.google.com with ESMTPS id c125si13573060oif.249.2021.10.18.16.15.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 16:15:33 -0700 (PDT) Received-SPF: neutral (google.com: 2607:7c80:54:e::133 is neither permitted nor denied by best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b=5AsRKWuw; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HPfHLoDq; spf=neutral (google.com: 2607:7c80:54:e::133 is neither permitted nor denied by best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z2EhmtitNFkcrMvN/Vk7L7tappMnXEQJrmVPcBHgSDQ=; b=5AsRKWuw+tFEeC IL4gevw40DiwfVycha8IWAyr4ViNCjVhseGvcSPteYcDtNM+1zxJwtOLnfM1c4LQJkFErk8L2C1Hy krKynhNVoD1HrNcQ+zOSepHab/WoVY0KhL9iIFWFB+QojYwzszSAP98ad0FuiLjvIHr0RdgEqDVyU g8czvcPHP/ccwbFvIXfXo8LBlNlCXd2xib7Q2/XHN/6FLhU80DMpC4H/KVhQ1bOMG/xyh8Ic+szvs 0M9TSwmzrMiP48xt+HHBumsk9wZRkevXl2jdbrlwth7teYjQXhH60QoTSWySf9ISVb7mPPKegmWIR TEODLJpK41yc26f+fxgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcbqu-00HRBx-9U; Mon, 18 Oct 2021 23:15:32 +0000 Received: from mail-wr1-f43.google.com ([209.85.221.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcbqs-00HR9Z-2B for wcn36xx@lists.infradead.org; Mon, 18 Oct 2021 23:15:31 +0000 Received: by mail-wr1-f43.google.com with SMTP id m22so44363870wrb.0 for ; Mon, 18 Oct 2021 16:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ums5lH5A6tPRuZbLiAY6nRVNCSm8UQRGQFhKC352/Xs=; b=HPfHLoDquM7RwcND+vgWYueLkNiO7PWgpgDB78EfJZCLRozaCjUGgUBe+L0EkWBs8D oe6kjBNWVhYB9ZQfRQ63pxsrtBbEB94++LbfWizDhOHCG0Dbp1oCzZfIAOtiwSNR2jJX o99ktNMwHwoiVNlLuFNxqqoZPzqN43TfVTv6ckG3PiPXFcALOxxMVkTmoyx8g3ay2at1 Ogqqd8wsWOJg5RKDO1SdNR27TcQFlKJHdlvjGfFFuCSzYQ1go/ImvAT8OE53nt5thYL2 h3GHSNxkMmuQ2LBA9X09Fji001m00w2y9n0tJUv/irXZeEvGYOPT7RhsiDW5I7dQpeWr rgqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ums5lH5A6tPRuZbLiAY6nRVNCSm8UQRGQFhKC352/Xs=; b=m50OgynRv1W2SI0cHVzqPWPOR1HYw8EAo06NUYt4UAe2xO52NtpLK/wacfwJqD1swf oDIFz97O0R+lDL4x/F/XW7llBCCoB/AjpBXZ8vneKsZGJoxW4YE8N/lLF71sNLeG5bLE bae8LvWuQPaKPr99jE/8YSYHv9IQihPCkWtBS+xQ109eQA77hr1YWB1VUvws+4/Gwgm9 yZaCGKq8+eBh1FvdROb2pnim1kuDFzvJRtyleHNv8kHKxtQOeNi85SEiByz0cAB4fQUH N9j46crm+DVkEYa2xfiagruaeQQ2PYqPCjd9Z5Z3h817ZrPpjn7uKuJRXVocgwkLkTTV Zb+w== X-Gm-Message-State: AOAM532zYr9uGhOzRDIcE0YYYJvmGXHbRPJW7HxWKXMgNB8hCWT0cWlj Vb/eEimNuHiVkrxmW8FOCqcq4w== X-Received: by 2002:a05:6000:1563:: with SMTP id 3mr39029542wrz.20.1634598928262; Mon, 18 Oct 2021 16:15:28 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id s8sm3685379wrr.15.2021.10.18.16.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 16:15:27 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org Cc: loic.poulain@linaro.org, benl@squareup.com, daniel.thompson@linaro.org, johannes@sipsolutions.net, bryan.odonoghue@linaro.org Subject: [PATCH v2 4/5] wcn36xx: Functionally decompose DXE reset Date: Tue, 19 Oct 2021 00:17:21 +0100 Message-Id: <20211018231722.873525-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211018231722.873525-1-bryan.odonoghue@linaro.org> References: <20211018231722.873525-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211018_161530_143780_88564769 X-CRM114-Status: GOOD ( 10.12 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: A follow-on patch will reset the DXE block in dxe_deinit. Prepare the way by first functionally decomposing the reset. Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware") Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/dxe.c | 11 ++++ [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.43 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.43 listed in wl.mailspike.net] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org A follow-on patch will reset the DXE block in dxe_deinit. Prepare the way by first functionally decomposing the reset. Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware") Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/dxe.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) -- 2.33.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/dxe.c b/drivers/net/wireless/ath/wcn36xx/dxe.c index 30f4484b336c3..d4f5746d9b10a 100644 --- a/drivers/net/wireless/ath/wcn36xx/dxe.c +++ b/drivers/net/wireless/ath/wcn36xx/dxe.c @@ -919,12 +919,19 @@ void wcn36xx_dxe_unset_tx_ack_skb(struct wcn36xx *wcn) spin_unlock_irqrestore(&wcn->dxe_lock, flags); } -int wcn36xx_dxe_init(struct wcn36xx *wcn) +static void wcn36xx_dxe_reset(struct wcn36xx *wcn) { - int reg_data = 0, ret; + int reg_data = 0; reg_data = WCN36XX_DXE_REG_RESET; wcn36xx_dxe_write_register(wcn, WCN36XX_DXE_REG_CSR_RESET, reg_data); +} + +int wcn36xx_dxe_init(struct wcn36xx *wcn) +{ + int reg_data = 0, ret; + + wcn36xx_dxe_reset(wcn); /* Select channels for rx avail and xfer done interrupts... */ reg_data = (WCN36XX_DXE_INT_CH3_MASK | WCN36XX_DXE_INT_CH1_MASK) << 16 |