From patchwork Mon Oct 18 23:17:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 515929 Delivered-To: patch@linaro.org Received: by 2002:ac0:cd8c:0:0:0:0:0 with SMTP id d12csp32662imp; Mon, 18 Oct 2021 16:15:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzh4aNJ2sQWyWdQQi1db3ohljlsNiPET2gUhrqFPfOVOeHUS2W7FJOJrqsx8ajhzBnlpmHd X-Received: by 2002:a05:6830:1e08:: with SMTP id s8mr2297933otr.305.1634598932623; Mon, 18 Oct 2021 16:15:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634598932; cv=none; d=google.com; s=arc-20160816; b=EbqpAJjwDM/csKg5zC2NuVF1h9bCxdCkAnpreerd4aWQwOPsVWY6jrPEz0sg9vzMpA IMub75gwJ8zqDnOGatWwIIWdn7K0w3CDo9+xfcvyeNf8Pydtd7ufnXTa/Wkx3VRBUBuW 1UVA8qhYiTVxBoCySM+g2WySsSeOgsiMxlS/LzhEICEIfUgQPXf/7b9Mpzz0QE89rjM/ 8B/6mHRmdeXkh4mXPnD7SoK0H2fTwiPgpgwVl1z4g3XVypnFD184gz2pUNV7Rc4OrQVD WVVj9kk+mUpZbrCSXBd3AcLwl7rQSjuP9c7pWzLM7VMv8B1EbL5pzHwALW38Aey/Cxio aZFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature; bh=FqUPKgj5yHYE3zJUvTHVrOHiS93X5SG0Q9vpCstQOE8=; b=luY5q1/MqMSiG/aSXvENTf+H+ykkusdklcNd/ChdyvoLrpTMUZQMjsNDbGGcggQ0+a dn/2Lfp4R22z7WuI+AEdII8TEoi2qvY54z6KdFqBGmQMHnlrQhoB/NcAldK4kiG3N4Hb Eb25vqZF6kd+5g9LKWn6s8tuMz5ezF0cfdx9pEbCjPev68p4pR+KI2mrhr+7whMoY48D 1BpgmeUhdkdLIZEU/pxZbrw4JuZtRUGw7x2tL7u/hWxTX5H3n8joIylbSvaVArDdldRW DpSw5vt0z0MifBWE1A1wwmDWzpkZB6AXQP8vbzmzGIDAViskJAnK59PYJHBi+jis9pPC ZqQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b=fhh6L8SU; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=aFg91Sh9; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id 92si16390533oth.115.2021.10.18.16.15.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 16:15:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b=fhh6L8SU; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=aFg91Sh9; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FqUPKgj5yHYE3zJUvTHVrOHiS93X5SG0Q9vpCstQOE8=; b=fhh6L8SUqUva7p 3Mf9SBY6SeC1sHtsBBaeFKg1wUHy9o3Rx+x+7F/NahdVj6AWmVRQSBsgDoOdu8V+F1oJnKjtpNYxs GVFP2trMUizhZ0E+y5JaVEw/7VD5wHYp5yZ5k4Dnh0hsT1ItEm8siiNhHwfo4Or6ZesL3bNoxx4hi CHM8zu0tM6HGiRm1WSmsGGpETPEPW2kcwPg+F5JCUBWztrv08ACg+OstiLwiihIXL0C5kY5hvzzBX nK0iVleaJg8PYF8YqcAr0e40Y/eOctetqveCz30HQbeeTQVfcaX0mQ/5iqxk1cAGDf79bIPq5Rq0d 1Zn0QSBjzNSPXW5Fhtbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcbqt-00HRBC-5W; Mon, 18 Oct 2021 23:15:31 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcbqq-00HR91-M9 for wcn36xx@lists.infradead.org; Mon, 18 Oct 2021 23:15:29 +0000 Received: by mail-wm1-x32f.google.com with SMTP id n40-20020a05600c3ba800b0030da2439b21so777151wms.0 for ; Mon, 18 Oct 2021 16:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QBnRHV9rerfqg5IbeiF/8rK0T34zBtjkpRvTdqdQUlc=; b=aFg91Sh9YmPW83M7zi+C8pWgz62P6/sn5LKCIc9U7zuatO2d5tXhdcNnFqrVmF5+kD MqFLmWBOxaq4QZLDqitIM+SY+FSUnT9wMdAADtwfMpVcJ69bTwjVWZMek+sw/yUTsUe3 y7NIksZ2WyGbJxBQmmkvIUTjLA17fNheH9OKFf0j28dprpaGdNkEdFUJJntMlRASQlMz OnvIfli9ErvH5YbHqmnM2pXqY3sLMgJ6QRC9j+BLygiz8XxaVkc2riPJIX2EjYVdIe55 SgXLXHiY173sCqYAWfUiZFZAdjiXyvbPfwlTRo1e0zuwRGqb5Wi1fTMlhKt/9+9Dof+t fgvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QBnRHV9rerfqg5IbeiF/8rK0T34zBtjkpRvTdqdQUlc=; b=lh9ypgKeBH/Ikc0sG8+ncuqzdUf3gKY1V4DO0I68IgWQSf6PQ5XuSoUm7HoyLEu5D5 yDC54m0cbk3JYZQNpAEp3O+Sj2U4fRtYK3CRBqayTgsUDs9BzzNeVLbMO8VePJCd0tND rEN+QXvksXrIbfs+JOPSvAkrbdJc/IJcLm+i9akCyHdxciGtIcb+vuyl7LY5a6oGPrue 5f+VYa+xqd2aBuw9gXnSL1Wlf6woLTbPsExqL4eCMGG5aCmgQ/OiIFwALyJdpDPAycU0 PZucO77i5ZCkWo76lhyI0izoN9BacQ6gT6weK4fXfxCnv1UXEQWgLMGwJ9hVl/8wAeNc 7FtA== X-Gm-Message-State: AOAM5323YAXfWnQsD32sxiV1OEY+T7uomJS3q2PHEM32g0lhXRzqdu6C TrayHRVs7LeifPhmfN0v+KPZcQ== X-Received: by 2002:a1c:5417:: with SMTP id i23mr2014312wmb.17.1634598927213; Mon, 18 Oct 2021 16:15:27 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id s8sm3685379wrr.15.2021.10.18.16.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 16:15:26 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org Cc: loic.poulain@linaro.org, benl@squareup.com, daniel.thompson@linaro.org, johannes@sipsolutions.net, bryan.odonoghue@linaro.org Subject: [PATCH v2 3/5] wcn36xx: Release DMA channel descriptor allocations Date: Tue, 19 Oct 2021 00:17:20 +0100 Message-Id: <20211018231722.873525-4-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211018231722.873525-1-bryan.odonoghue@linaro.org> References: <20211018231722.873525-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211018_161528_759606_50F0D85F X-CRM114-Status: UNSURE ( 8.37 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: When unloading the driver we are not releasing the DMA descriptors which we previously allocated. Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware") Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/dxe.c | 5 +++++ [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:32f listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org When unloading the driver we are not releasing the DMA descriptors which we previously allocated. Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware") Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/dxe.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.33.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/dxe.c b/drivers/net/wireless/ath/wcn36xx/dxe.c index b832afedde76a..30f4484b336c3 100644 --- a/drivers/net/wireless/ath/wcn36xx/dxe.c +++ b/drivers/net/wireless/ath/wcn36xx/dxe.c @@ -1084,4 +1084,9 @@ void wcn36xx_dxe_deinit(struct wcn36xx *wcn) wcn36xx_dxe_ch_free_skbs(wcn, &wcn->dxe_rx_l_ch); wcn36xx_dxe_ch_free_skbs(wcn, &wcn->dxe_rx_h_ch); + + wcn36xx_dxe_deinit_descs(wcn->dev, &wcn->dxe_tx_l_ch); + wcn36xx_dxe_deinit_descs(wcn->dev, &wcn->dxe_tx_h_ch); + wcn36xx_dxe_deinit_descs(wcn->dev, &wcn->dxe_rx_l_ch); + wcn36xx_dxe_deinit_descs(wcn->dev, &wcn->dxe_rx_h_ch); }