From patchwork Mon Sep 13 08:30:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 510252 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3D78C433F5 for ; Mon, 13 Sep 2021 08:33:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EC7F6103B for ; Mon, 13 Sep 2021 08:33:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238609AbhIMIfG (ORCPT ); Mon, 13 Sep 2021 04:35:06 -0400 Received: from mail-dm6nam12on2050.outbound.protection.outlook.com ([40.107.243.50]:38689 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238591AbhIMIee (ORCPT ); Mon, 13 Sep 2021 04:34:34 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nZq3n0lO0Fw7ai2oYzJ48xxXpAeR1AIzJFMnBMlVj6JjblX2bF6g3OEs4iXtsDSkon6z581CBXG0j/HnxVQxefCnox2ZZjPUavd8yGX/34IHEzlZEBtPCgwFFhVS4/bYh/hiI69nOgmRQJQy2C+dTlQkVeV5PVQWOwAzc4oEnpPRPw1xPA+U44QvcEmriwy3rjF8oLz/KGfE0lMy+mvIFm25pkDNCFhtXTlhv7Bi/qBZiPg+9tBJXvnWAKhcsnnd5spMB/ECDcxjXaJ0npcJ6HLjZaOW2EFRSwzxugWDlf4DOfJ7kDFzOqUyk7B3lqX3xAASWYqYr9B9UZX/6AwVvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=D2RF/Y6vM+Lj63470xCmRdZGPoY4c0kiDfF+JTD4zDA=; b=bZDxxidLZXheAYUlpH+bC6X8z8+MkHZTIlrLURTmgsJOYeUtWEJe2B8HvPAxhdeEcCm3xYCVSIX73Dk28X8OGF9HyDujAFZeftbsVGWuKZnXhR/Jw9yaSWfin8B3gD4wH2s/UOGKPG1emn162VBwKXudOVDXL4+08YjPQNU3l+I4n1+oRvJBzyntHaPTECOo+WeWnHtVvKc7RTaPKiPdQMmQnlDnARLKa0XRDdhezN2G4o9sTLbjV+YWenjk6K0gAEQh5S43Yayr8trgOwnRFPvuD8R72QsD113sg/oTTF6Nlrmyy3fk6I3fFU6O1YWWrQRwvKwyvvDM5K1Ohrt2Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D2RF/Y6vM+Lj63470xCmRdZGPoY4c0kiDfF+JTD4zDA=; b=ACCQEBzXWCszHiTjNq9W1SOMZP8guPpVHTtIOPrTcs2CrMxLQCUaW7EWf0oOdVYEDdNLD+ETnVel05jwTMxyLhxyW251e/hgK6mRkwLQ0IFEaPETAySKLo9h45CXTA30utas7lZKQVfMtDoU8XNa5lP0u2N7l2N78fqI4YpAE70= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none; driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (52.135.97.18) by SN6PR11MB3263.namprd11.prod.outlook.com (52.135.109.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.18; Mon, 13 Sep 2021 08:31:56 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd%7]) with mapi id 15.20.4500.017; Mon, 13 Sep 2021 08:31:56 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v2 18/33] staging: wfx: reorder function for slightly better eye candy Date: Mon, 13 Sep 2021 10:30:30 +0200 Message-Id: <20210913083045.1881321-19-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913083045.1881321-1-Jerome.Pouiller@silabs.com> References: <20210913083045.1881321-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PAZP264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fd::10) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 Received: from pc-42.silabs.com (37.71.187.125) by PAZP264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Mon, 13 Sep 2021 08:31:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a530b546-4bd0-4ca4-20ba-08d97690e668 X-MS-TrafficTypeDiagnostic: SN6PR11MB3263: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:483; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O8dvUi2QX+uQC+iECkKK2bmXX/er2kAcYIjH/r9XlR/JvLaDrDzS+HG2UZuqvA7DQsoXKiww+rYimtSt5rhiRWHYd0Rc4VPh42P+1hq0lzgm40t5RSKNtPUThPklImYs/VlfwwHpjD8rzOcO6JNO4Aqm2qwJz4C4cs4EpvSJgF1ywaHwlaAK0CHjhvrdi5oPh/quKyBbqMlGaE5tw6dm4ERwt1oas/1UkR2Ja2+WiVDr2LzalLvAf93+ZG7xO4tSTn0KNWosNmWRhZ3R/XUDkZ62roHayYTxMldkCs8rl7ihXQaS7mCahT1Dpd3KnZk97iIpCaLjYAmhgh8pV4+PNKznu9IEX1lDBEPSLj7AWupksdR0kvJ5Jr+CRtx0zUxK4+V7bRXJZ5uj2Bm8C385aDhQD/su/612ay7fCcoxEnaJ63sn43Z5oFGrtdSXAkCWeKpaTS8d3fHIgFlJgsYhQwl6jP9ZLqVb84/Fw7eOfe3Aq2T8Piw2NFnIfkKTeGnE1Qp55dZ41YnG41LHR5TfLZzW2jAnB7B53nAxcRwEYz6kTRcGcgrPeh5cF1cQk0Ykxyhf0BtGu60Z8fYl0YTP8MIF9ihhUYASjbTQgcfn4rFiMf6FosuqunKRUymQh6j4D3soqcPDCDeZ9BJjhbvAnPKenYhzm8U49aHTSDwoN0BsoM3fLvxaMtn1hmiwYph7/HtPZvREPwg2UQqwJTuP1Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2718.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(83380400001)(107886003)(956004)(2616005)(5660300002)(54906003)(38350700002)(4326008)(6666004)(316002)(38100700002)(66946007)(26005)(66476007)(66556008)(186003)(8676002)(36756003)(8936002)(86362001)(508600001)(52116002)(7696005)(6486002)(1076003)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?v9FtgUrTNX74PNwMnXfbZRHSb?= =?utf-8?q?LH2y18EoS/Ob7CmnSTplRlWG5bNqtBwKFoSU25UdJHd6GB8qRtv6eYpQ?= =?utf-8?q?XwtULceaCQSNLK/Aqsl46TkEnU9uQ3E/l8bf2QI1C11j3HaAa3gColBW?= =?utf-8?q?eyx54eIwA3H0230w8wYnB7hshP5xkIexVEkpQZZVdmSKNFwRsWTA2ksU?= =?utf-8?q?iJRbw5q4gzIbGhOarvCwWpXAk0YdfcREhY7ffCjXB+hOQb2SSnhicPPh?= =?utf-8?q?QZGhi2083TktRkXPog+MWocvP/1puueoJj93NVBYpZYhLMPdFaj/I+Xn?= =?utf-8?q?FNGIYoCab6EWslKbjBeFqfIQRvDJTvPwucnQ45VfTcEGew5zyiGMR8u6?= =?utf-8?q?uqw33aDsFBvzVw5IW3068C7Kgee9D547BSKSG3lplwsWcRPx6Ov9PAfL?= =?utf-8?q?IvgxyjHlmXyCIRy0A+qiVdv11p119E4JLXBkydcWMxVuR7J5uCzSRfEw?= =?utf-8?q?5BFG5dKUmO8o8+9jAqgHhnONdB6cMxA7Th7F6/ZpQYamNoZVRMpbFnBN?= =?utf-8?q?3hkN9jHZ2xcYCFZ4un3UyzWd+pgj9UeBe2cJUjf0FbE4QAwGKIyofYnH?= =?utf-8?q?MB8THtIq8skJuJ8iIDMeh9Uhn2lJYqhntVlXHkuIh920gu6Mn9T6PGqi?= =?utf-8?q?pXvnsEPw5kiLzdbbnbA3VGs/eVvJOiCjNGk0eyVS7/PW56jJfu2rECBZ?= =?utf-8?q?+1o3RgPiZOOuOIrulexkQNVCvS+PI/pys0LWZSh0JwjuOpbM2azV6kf1?= =?utf-8?q?dJdKPOMosFCFYMC99uy/j+2zQ8VJe/K0NUY47IKXXTnJ9Exiue5t8YKn?= =?utf-8?q?RVsQhI4jkvvXZefv9N0TeAaIlHpk5hKHfnKuDn94cmpq8TczHKBXRq+O?= =?utf-8?q?WIXbYph94f1rSTcQORGxuLpAye0OIYJ8pWuU137eZ/ZVanjWeU9XVyOy?= =?utf-8?q?cD/fKA5/m1NQTqByJ8orMLAX5vmzcDNBQdE2lKgGppmU2VR7amDqzlkA?= =?utf-8?q?P/1Bc4P1Q5Ym+Z6/2Mxc8TzfEocufhkCs0aw+4A1a7CTxyDgF7uM1p70?= =?utf-8?q?QM9QADbdHMD2qDQlRRDi7Eswy4aDtLjDnBdqpCpY6LekaDkzX2vz026M?= =?utf-8?q?rDTVZTLOfOm0nwOX+uLLn6LNIuIlXQpwaw/QxoRVQSd3c86+U/z1dbCL?= =?utf-8?q?im3iuEq5bv4qz/wO/WR3Ggdc6Fxl2JMXwqusKmULYSRwjJr0d7v2aZEs?= =?utf-8?q?1wat05Sk6r76tsRRjexetKNepZzrN7wfDrpwKn+PHtLhc9udsqhfGSNa?= =?utf-8?q?mgdarbOBJVNdib2KceOIxQa3Q0jMF3dxF0VPp2etU3bhxSQFn0VuKxqm?= =?utf-8?q?9jYIYfuZfXNSmrCf6Mm0VHjOj+ZzXft?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: a530b546-4bd0-4ca4-20ba-08d97690e668 X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 08:31:36.4286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oeItaCF/q4GGMJ15KhR2iRz/GNRbiejme+D4Vjvo8LBU0M3E05cSNkY1A3jbyCuJFkwUVPpS9b9OzapPFK10wA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3263 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller For a code more eye candy, group all the unconditional assignments together. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index 00c305f192bb..77d69ed73e28 100644 --- a/drivers/staging/wfx/data_tx.c +++ b/drivers/staging/wfx/data_tx.c @@ -376,15 +376,15 @@ static int wfx_tx_inner(struct wfx_vif *wvif, struct ieee80211_sta *sta, req->packet_id |= queue_id << 28; req->fc_offset = offset; - if (tx_info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) - req->after_dtim = 1; - req->peer_sta_id = wfx_tx_get_link_id(wvif, sta, hdr); // Queue index are inverted between firmware and Linux req->queue_id = 3 - queue_id; + req->peer_sta_id = wfx_tx_get_link_id(wvif, sta, hdr); req->retry_policy_index = wfx_tx_get_retry_policy_id(wvif, tx_info); req->frame_format = wfx_tx_get_frame_format(tx_info); if (tx_info->driver_rates[0].flags & IEEE80211_TX_RC_SHORT_GI) req->short_gi = 1; + if (tx_info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) + req->after_dtim = 1; // Auxiliary operations wfx_tx_queues_put(wvif, skb);