From patchwork Fri Sep 10 16:04:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 509047 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAAAFC433F5 for ; Fri, 10 Sep 2021 16:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92F21611F2 for ; Fri, 10 Sep 2021 16:07:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229485AbhIJQIp (ORCPT ); Fri, 10 Sep 2021 12:08:45 -0400 Received: from mail-co1nam11on2063.outbound.protection.outlook.com ([40.107.220.63]:2016 "EHLO NAM11-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229477AbhIJQHx (ORCPT ); Fri, 10 Sep 2021 12:07:53 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Icf1AXE3DlHc/1pQeEd1GP4m4XcXYHEoiN8K9IijZz9ZrQP9dA+BS7lpmu7JXeu/bF+vckCObKBnujQw679mttFC5zJYzLQaQ7aThCfukrrm7K0ghq1SUaT19hPcUe7kNelum+HwF0ftxteWDT5COsSX4nGdwvejKntrq7jtFsyqx7EvrVoFQ7SvFJ8pi4rkWpUJK5MDAMKglcdLD5jijxwNvsT6DyNhXUk1OtXhBY7m+Oh2UcW98fJeLo2gksrcD0TI6y8nTa4I4GOovZHlIfaLrldubwl12/xQxPKdX+hokXI963CsdQV/gOO9U8WzvzHHjZjuZo4f4ywYYQj0oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=D2RF/Y6vM+Lj63470xCmRdZGPoY4c0kiDfF+JTD4zDA=; b=aNh6eV3UlKxpOssD/6lfX66jnwUpfkM5crp/yjEdfv6c1tZnsOwLlYbll3bGPcz8IPwTOsbYBzXK0s0Rsh/VBqSTecyKhTeimw/H7SYb6jIU/N5mDHWdiP6lZi9kw8f++oWb2vnvAnPu7pC8IOQAxQekWZRnYEc7obXRf8+LbrOOFZsbKVWcfnnvKJl6o2DaYnmQdhbuSJNWIF1A8TpyWn7cf8iTekEh2wIgWHKMk+AnbxPKnV2mLa3Lh2R7zt88RK3pKvD/0zsVWihB4+RYK33NRQqqJx7moNHlgsy+hFCYnW3UiS7JHmhNvIAZ+RB6j3luYSrisZhFv1qS9FpxQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D2RF/Y6vM+Lj63470xCmRdZGPoY4c0kiDfF+JTD4zDA=; b=md+pdWCvXTbadGJaANDVSL8V74RFPUx9KuBDvIlGKnylTpCit8fIN034o6oBaykZMHFHjjlF/m8lHOSsIYR7G8il5AuNYnnj6ZVuPAV1O8yyclsmwks5ca6gw8TIY+FZhdEDjkOfdRhuI7H1qJ1Qjdo3+RUqES9OkYvmZceqK+M= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none; driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) by SA0PR11MB4592.namprd11.prod.outlook.com (2603:10b6:806:98::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Fri, 10 Sep 2021 16:06:07 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd%7]) with mapi id 15.20.4500.017; Fri, 10 Sep 2021 16:06:07 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 18/31] staging: wfx: reorder function for slightly better eye candy Date: Fri, 10 Sep 2021 18:04:51 +0200 Message-Id: <20210910160504.1794332-19-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210910160504.1794332-1-Jerome.Pouiller@silabs.com> References: <20210910160504.1794332-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: SN4PR0601CA0006.namprd06.prod.outlook.com (2603:10b6:803:2f::16) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 Received: from pc-42.silabs.com (2a01:e34:ecb5:66a0:9876:e1d7:65be:d294) by SN4PR0601CA0006.namprd06.prod.outlook.com (2603:10b6:803:2f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.15 via Frontend Transport; Fri, 10 Sep 2021 16:06:05 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ea30b75f-3db9-434e-50f5-08d97474e59e X-MS-TrafficTypeDiagnostic: SA0PR11MB4592: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:483; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M604ZMDTbZzQoR4+okgpQpHe9Z/r18qV3bvyOcwvQHPNpqLTaG3itl6wbIUTJ0ricgOYDy18KiAUVFGT+ZYgKpIeUiqi8WjM+QQ37i+7UcKGzhpkUWpO9wRdAzIME2c5CRQRQzts5l60YtwJ6RWILivlk18OuSR8/cfFD2jvJa/R6OXEtVkmP7eeetk97vBg6DVuUH+bmJJk9tzwS3+AN3QE0kK25yPTBtM2i+KfSZRM37XujBklufRd1zOIne89XO/9Do7J16ef6xGTSI0lNknKaCNgO19I5XkzZumL0rNRFp+MFbDOxyOyzeBoa/rcdSmYlvnWwU0/I7NAH/WbVqxucl9NWLn5pdXWD3cnKYTkEsvMySHO86/RwJfxQQFGNala4ZTGr7xzFGK1w9i43mvCBGUO4iBF5jp3uQe+c9AHzEUhrfQmoicv7E9EK2/SfYGhiQ3NaAN+Z+4Y5cCU2o2lL61pRQ7259Cnvy98eiMhw98+YNPdvd81IzSas7C9KdZBbDA5eQt0mTFi6clPa4NiUeXCHLIIg6ae6FaoU62t8A/9VW4i081EC8fsYS18YHvUlhT8rWOZAvNa0fytF12+GRgfTIIsH9z0KZMBwAKADgwYv4NQw1QBCMQQJAMlkO7wu7b8awagOYXBuLpT/w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2718.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(508600001)(2906002)(66556008)(6666004)(66476007)(316002)(66946007)(83380400001)(8676002)(8936002)(36756003)(86362001)(6486002)(107886003)(7696005)(52116002)(54906003)(2616005)(5660300002)(4326008)(38100700002)(1076003)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?4dS2U36TcbkrMj6PNUfLPhnKJ?= =?utf-8?q?0zUkNTGo7bT2Fyo8HSqqG9DKXjHHP20HrbUyN0Mu9mAuIMxbdfEMhcKM?= =?utf-8?q?DMDLcwgjxGs8sKwIo86oyOniwMfyEivud9Q0WCSR8pj3KCRxCmpprASs?= =?utf-8?q?iMGAf6mwkcKZHMA7/b62rxCYw/L/hE8e7xHCk8quHJHhdSqX6usQD5we?= =?utf-8?q?qkx2VtSrJsHm5NRudcVwsxKsGAEiJWgIar7lmaU8Y3ruHFpc63N0iVYq?= =?utf-8?q?YMqTGBY6Xk5IR64xRePzI2ic4z1MmQF+H6kUdD9cUNNaRNpeMR3+kUMV?= =?utf-8?q?fe4QcPGrcwFu/1NLKwYjILwSqkzIrNur8Agwf6s2ZtEXKkth6BMvq2dB?= =?utf-8?q?lfJxFceTRZgF4uSLb3Wl4ZsIiY/POuiyLYMBjbtPLksNX0FbrPwHWN64?= =?utf-8?q?IY3F/cdusvk9yZXJH9hKjvln3YRLwK/QvOFYcHZueANN+DvhLVpBNtbn?= =?utf-8?q?hSPKBhD60mAqBh7wbYbo9Jiig8iJTF72bG6K4jhkydnWLKKHL8/zdBk3?= =?utf-8?q?/wP0ra0AeKoDQPMGPigTphNBW2jXoS9n+vvbznERZEGC5fW8CgsLvWsR?= =?utf-8?q?dj5QWaymBPBF1e2Bl2moGqbHWeh7KQgxvRbBFGNcfbG+tQfZZ1DIYI2c?= =?utf-8?q?zj4LZ4fk1Lw54bZyA7NyjvWhzUDM7dY2m6TfhGXoVWg0FWT94EgKTSWM?= =?utf-8?q?k6wXWc5aJCjck+nIpIQEjaJvogQLPK7PT65XXedrCc4NIKZTC1wqR2bT?= =?utf-8?q?SmBNmx0Iw0N7vJ9ptlPS9HQgVjZQ4YAG27ExTDjdv+X/+ZOVeeNnIj/f?= =?utf-8?q?/BulsvhIL8W90N5h/kzZ9NMlGJd8ocNyLx8Lg1fApOywZrKyCTgKBQUr?= =?utf-8?q?klMEjDPJm0+yqmhpODh+K3whZO1b0SuGUgSnNgo6+ckYXqJpCatyJK43?= =?utf-8?q?vlvxJERPaHGjCT2YMmFNOuEEHoGF08SkBe6W73ZjikY3Bhw2YD8I3d/u?= =?utf-8?q?GWfRbAn7q4vgHfmRFxbs4a4MnQ/fv09ctg/yzbrXsW+SeIaR6DCZk5A/?= =?utf-8?q?iytY4YYNulddQaEac2Hj37IzHQzKJSAfdzErBHmroArDPxs0HxoBL81g?= =?utf-8?q?FXVftzhnPFN2y++prUL2nrkOptUOzuGHfj2boZFaC61k/w7ipQK8ynJl?= =?utf-8?q?J8lHlu6n5Rr1Z34yWu9ICprR3b/04Tt7nB8u9BtcFviQtLbRkFu74/mZ?= =?utf-8?q?YZ8MA9cW2zblImGz7HLnlCBME7D+uPMf9BdnKEEVsOyU57SN07NhNY2+?= =?utf-8?q?+NC9gYSx+fuwBfMdpoXYU0pI9cnjcbLhUxhF/4liIgh2QCOmCrymIaVC?= =?utf-8?q?1pQATR1eM0uGcxFMJeplGq9iPsnLgh5PyAyQhzQpbw4veGy29QsKJXmA?= =?utf-8?q?gXEQnMOeHEdFI+S9JA/z2ItyvMjQnjeJPHMNz7G?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea30b75f-3db9-434e-50f5-08d97474e59e X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2021 16:06:06.9410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3uWbEVRdG2UCksarqFQLQsPVZ9dQDfy9uunTP1Pzl0GviYKzyOj2utlh2cZTtz/jWFG3xe0lr/OtwWbRqwuZ+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4592 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller For a code more eye candy, group all the unconditional assignments together. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index 00c305f192bb..77d69ed73e28 100644 --- a/drivers/staging/wfx/data_tx.c +++ b/drivers/staging/wfx/data_tx.c @@ -376,15 +376,15 @@ static int wfx_tx_inner(struct wfx_vif *wvif, struct ieee80211_sta *sta, req->packet_id |= queue_id << 28; req->fc_offset = offset; - if (tx_info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) - req->after_dtim = 1; - req->peer_sta_id = wfx_tx_get_link_id(wvif, sta, hdr); // Queue index are inverted between firmware and Linux req->queue_id = 3 - queue_id; + req->peer_sta_id = wfx_tx_get_link_id(wvif, sta, hdr); req->retry_policy_index = wfx_tx_get_retry_policy_id(wvif, tx_info); req->frame_format = wfx_tx_get_frame_format(tx_info); if (tx_info->driver_rates[0].flags & IEEE80211_TX_RC_SHORT_GI) req->short_gi = 1; + if (tx_info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) + req->after_dtim = 1; // Auxiliary operations wfx_tx_queues_put(wvif, skb);