From patchwork Mon May 10 14:51:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 433160 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp2917998jao; Mon, 10 May 2021 07:54:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzqN3djuTFsJuAxxjjWktBPEvVYYSfb+DzxWDXcxwJgMTxksCg03YRV81G0eaRiVyblSYYm X-Received: by 2002:a17:906:15c7:: with SMTP id l7mr4216088ejd.167.1620658456053; Mon, 10 May 2021 07:54:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620658456; cv=none; d=google.com; s=arc-20160816; b=n4ABKQbbNDlZZEZIpNkoBc2yxDQAm/NULxenId7OUVKEbHInbCTFBifi9M3wX0MYyY FW/AwV4c6kEyh2rM5FcQjq5AdrCtkv7TX/Ju5L3VsT2trnp4Sn4BYgqA84Xl2OItZ34L 7SaOOcpPrfGlkDPFRsu/0Mvr9I3PRak+2gnNMoWmsvPO+Dq4us7XXJFTmgckUjPr7oWh JhpoHV9fjjSzwSWivwCBxDbAQYoDo7zaX6Keipm83p0sMhnb8gdw/O4e0nNOoZYU9jcZ laU6WsmKDHLz8HHxC7jeTIYBIdiqXPPh7AFasguBiRZCTNTgvsl84YDPCH6oF9vepnes Az7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Yde8xYpjNkPm5Nn/Y1h9e3kAMl95TUwYN5kOAHH1R4k=; b=QX7g3+q2Vrcgreddr0Y+fjkBpE0xfz9pKakNvagm40W+2L5/Ajpq9egHHLbaa67ZFH VrxcU0j9mf4LAvMhdYti84FE1UD/7m18nl4HK9vJ0TCP6rBSS111XgEXjqSG9PT4uSXt iy9ULEtX8DrVjwkKQgiLuL8hUbyRXUC8Fc9fHkRp5a4uU4dljfosNFegBvviJCE4fyLd /xMYHN3IhKzURjSJ9zy8vQ8Po9azL2Felx/0LtEnyRVftQ8CdkryyPoYJ0N4u9fOFDIK tBBQB5yXDXKK4IisLcP5tevvDhamb1XnMQDCM/TyYfNFnWVgUzS5laStRfuOPj04EPbM k8Rg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gu21si14059394ejb.12.2021.05.10.07.54.15; Mon, 10 May 2021 07:54:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232417AbhEJOzR (ORCPT + 2 others); Mon, 10 May 2021 10:55:17 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:2618 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236670AbhEJOxG (ORCPT ); Mon, 10 May 2021 10:53:06 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Ff3qZ58kQzmVRp; Mon, 10 May 2021 22:49:46 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.498.0; Mon, 10 May 2021 22:51:49 +0800 From: Zhen Lei To: Kalle Valo , "David S . Miller" , Jakub Kicinski , linux-wireless , b43-dev , netdev CC: Zhen Lei Subject: [PATCH 1/1] b43: phy_n: Delete some useless empty code Date: Mon, 10 May 2021 22:51:17 +0800 Message-ID: <20210510145117.4066-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org These TODO empty code are added by commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's been more than a decade now. I don't think anyone who wants to perfect this workaround can follow this TODO tip exactly. Instead, it limits them to new thinking. Remove it will be better. No functional change. Signed-off-by: Zhen Lei --- drivers/net/wireless/broadcom/b43/phy_n.c | 16 ---------------- 1 file changed, 16 deletions(-) -- 2.26.0.106.g9fadedd Reported-by: kernel test robot diff --git a/drivers/net/wireless/broadcom/b43/phy_n.c b/drivers/net/wireless/broadcom/b43/phy_n.c index 665b737fbb0d820..13cc62695f4cc93 100644 --- a/drivers/net/wireless/broadcom/b43/phy_n.c +++ b/drivers/net/wireless/broadcom/b43/phy_n.c @@ -4601,16 +4601,6 @@ static void b43_nphy_spur_workaround(struct b43_wldev *dev) if (nphy->hang_avoid) b43_nphy_stay_in_carrier_search(dev, 1); - if (nphy->gband_spurwar_en) { - /* TODO: N PHY Adjust Analog Pfbw (7) */ - if (channel == 11 && b43_is_40mhz(dev)) { - ; /* TODO: N PHY Adjust Min Noise Var(2, tone, noise)*/ - } else { - ; /* TODO: N PHY Adjust Min Noise Var(0, NULL, NULL)*/ - } - /* TODO: N PHY Adjust CRS Min Power (0x1E) */ - } - if (nphy->aband_spurwar_en) { if (channel == 54) { tone[0] = 0x20; @@ -4636,12 +4626,6 @@ static void b43_nphy_spur_workaround(struct b43_wldev *dev) tone[0] = 0; noise[0] = 0; } - - if (!tone[0] && !noise[0]) { - ; /* TODO: N PHY Adjust Min Noise Var(1, tone, noise)*/ - } else { - ; /* TODO: N PHY Adjust Min Noise Var(0, NULL, NULL)*/ - } } if (nphy->hang_avoid)