From patchwork Mon Nov 2 11:24:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320215 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp3643546ilc; Mon, 2 Nov 2020 03:25:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJx8myZUbjmLujOSO8P+doSVubdSRmGj73PI8o7gz2Mu8J7RRzvhbZsmFafeamRA8wap/GhK X-Received: by 2002:a17:906:158e:: with SMTP id k14mr14379859ejd.496.1604316305513; Mon, 02 Nov 2020 03:25:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604316305; cv=none; d=google.com; s=arc-20160816; b=HGpBKI7PMasDSMkwhXdb7hnybPSJf1+0tUXui/VmU85QLKFgmtBG/nBOsvo1JjVanj jFyEi4JxSbOMDknfwFCulgugSLDxXQU2Y+etUX4S8+LuqAXaYIkoxmOxsTsMryfOriMF MKDfNOKa5ACHnpr6zzHIooBPlgtFf0N+x/UOlQgfBWnFAiMNF0LIvrzycPPzfH3ALkMl IOe2cco+dgsbQyKXwvvnAkvmSDQ8s97Kc6EdgwD/sidOEC3rTccPXK/CHed7t4h0rUKO lLhxSaCqjOkfp1RvzUecpmtfusevGxZ0FhV+HsZApCal/TbDFcFVBVUYleC/U/YPyDye jfkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gRH/26yT2dAaI3IpvhAVivatnrNzkpcErFlaxyXb8UQ=; b=NVUBdUr50CECLRNRjwGPxrC+o9udaIuW2nceeS+vu+mpHi+gBinFvWJGwA2ZrMCZw8 Ytmidmtmwr+bsXjUv+BzepHOyvdjlAFO+fcZ3QMC5uFwaZ2DFeHeD4iK0eukozLM/tro ZqBXcG6ir0Z5s9coLgJLsXDlk7e+nxSbDNNa9ofUXzsRMDaKGAev4hbT1EMwEAQnsOAe I4FZa6onZcarVg/S6ZGQYvpLpqfs9Z4gH7LLJuGQvdJTF9NJKB8LFEqfF/hiDrR4mBZ0 rAOOaq8Y9hUBs2ejrM0GWk2iUc4Q8yaknB2A0G7x+izwBP3ybrSEzg+lyva+yJP81SzS QV7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ltQ789qF; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a5si10151697ejk.741.2020.11.02.03.25.05; Mon, 02 Nov 2020 03:25:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ltQ789qF; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728851AbgKBLZC (ORCPT + 2 others); Mon, 2 Nov 2020 06:25:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728813AbgKBLZB (ORCPT ); Mon, 2 Nov 2020 06:25:01 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1849FC0617A6 for ; Mon, 2 Nov 2020 03:25:01 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id b8so14175370wrn.0 for ; Mon, 02 Nov 2020 03:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gRH/26yT2dAaI3IpvhAVivatnrNzkpcErFlaxyXb8UQ=; b=ltQ789qFyVUG0DnMpeIBcHyp11aLEjc0FGrAhnTv1HyvyDlz68ox27lpz56pRgP5dr GN24aKpcLw9GxLT5KfWn5X3E+MFEN5tC3rcIHc0HNIDR4+EfpVmTtLbhllceTVp63poY Dqra9dlmKW2qmU58r9knHxsIC3Y94KZYdfy5KdOpIj5y9x/a9Aa1kAEcKLlteVa+vaSC 3NsmBenF7kWNadUuFK5ZCy5lkzBA4qf/aM6Y4LfQaCsQ5OwkFKgjsvwPFYxro/5B+K+5 N+KcSjtJgHhF470t1KKy6b4S/WpsuH0o2UnpNtg/kZXZufZehfcd5F4dTCqKfuEzlAua XiRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gRH/26yT2dAaI3IpvhAVivatnrNzkpcErFlaxyXb8UQ=; b=V79qPv+L1U+sOVgzG6oXIWG4MDp65w/v7w1y5y5sm++/cqs0Cqad6MqUxjt1P6QfOa jyW37Nm9PjPNQMWmzlZVcOj5k/pvPQpLZDyISCKMt7df2poX/qGVRTW0IiisLbH7w5HT Se4+LZCt86SHmlKnh+liaBWhRugQnFSvc86j/eNm9p8HmQWg+ukjt4GPHHcTYX7lxwKD jVu2JMj/av0XZEqD+47wRYcYZ/H8aGwcE8jycHzLZgpn7QEVJ6H4cCAviBMUKPh6YetV wKmt1GWNiORkkCoJH0nOGPex/WB3/4GALtn9HoYbcglDv5xtNb1F+bsIvUZ5w9EL42q7 141w== X-Gm-Message-State: AOAM532hxQzWFxUsyr5i58lvElkqchhD1oTOhCcBlrbTwXdCjkS8mbgl ks5FPmuB62ZUbDXDZJdXsrep14o1z0vDpw== X-Received: by 2002:a5d:534d:: with SMTP id t13mr18886940wrv.69.1604316299868; Mon, 02 Nov 2020 03:24:59 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id m14sm21867354wro.43.2020.11.02.03.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:24:59 -0800 (PST) From: Lee Jones To: kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 31/41] mwifiex: pcie: Remove a couple of unchecked 'ret's Date: Mon, 2 Nov 2020 11:24:00 +0000 Message-Id: <20201102112410.1049272-32-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102112410.1049272-1-lee.jones@linaro.org> References: <20201102112410.1049272-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/marvell/mwifiex/pcie.c: In function ‘mwifiex_pcie_remove’: drivers/net/wireless/marvell/mwifiex/pcie.c:432:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/marvell/mwifiex/pcie.c: In function ‘mwifiex_cleanup_pcie’: drivers/net/wireless/marvell/mwifiex/pcie.c:3142:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Amitkumar Karwar Cc: Ganapathi Bhat Cc: Xinming Hu Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/marvell/mwifiex/pcie.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c index 6a10ff0377a24..67e0247ebaa65 100644 --- a/drivers/net/wireless/marvell/mwifiex/pcie.c +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c @@ -429,7 +429,6 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev) struct mwifiex_private *priv; const struct mwifiex_pcie_card_reg *reg; u32 fw_status; - int ret; card = pci_get_drvdata(pdev); @@ -441,7 +440,7 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev) reg = card->pcie.reg; if (reg) - ret = mwifiex_read_reg(adapter, reg->fw_status, &fw_status); + mwifiex_read_reg(adapter, reg->fw_status, &fw_status); else fw_status = -1; @@ -3139,12 +3138,11 @@ static void mwifiex_cleanup_pcie(struct mwifiex_adapter *adapter) struct pcie_service_card *card = adapter->card; struct pci_dev *pdev = card->dev; const struct mwifiex_pcie_card_reg *reg = card->pcie.reg; - int ret; u32 fw_status; cancel_work_sync(&card->work); - ret = mwifiex_read_reg(adapter, reg->fw_status, &fw_status); + mwifiex_read_reg(adapter, reg->fw_status, &fw_status); if (fw_status == FIRMWARE_READY_PCIE) { mwifiex_dbg(adapter, INFO, "Clearing driver ready signature\n");