From patchwork Thu Sep 10 06:54:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249563 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp476903ilk; Thu, 10 Sep 2020 00:14:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVYVx6CJgkHJp/TLPqpMhJ1WKSyGPQP4mJKrmR30MrNhSi6flIT5kuiKV6NfYcY0RjblOp X-Received: by 2002:a17:906:d94:: with SMTP id m20mr7802182eji.133.1599722051982; Thu, 10 Sep 2020 00:14:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599722051; cv=none; d=google.com; s=arc-20160816; b=L9abt4P7veGvjhEDcuc/sXNlOs+wCnQfAiXjvQNpEICnm9y2z6E7USeScF7BRQZZ8q Efrv00XTrGe8UT0wviQwZbTfXqe89ta0U+mYKhNSTy5vLam8wP1SmtOSbYHEHzHW8vd6 r9GG4WfCvAcsO1nX5idkmh/UzU8VNKYxcoWCRehlmIWBZTdCwKfgX7E+G3e/rFbmT7RF 6Uj6PGhgIWXxlF38f6h5EuPlERSbO89RrrOsyRggpBoLzZixp9gU/LndYKZAz04OTW9/ R+37vWbfiZukhUEaSXYwl1cKJdqucDcRT3PyUbf/UeIF5FOJovUIcEHQyEqAMJHXp46V 4Yyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=y3aNmNMSAAKySSaB5bb9ahC7IKT1fIK3BKBDgaZqfos=; b=jNEtwXnDMTZAkFV6Iv5JgZZxCHZeOsCP5Lka3K16dQDSJYvxIAW0rz9H9et4PJNGbu 90Q6sx3j9ddTpbb33ZyOfLOFdvdXHhNbFXdyPJm6hoG5ag3XQ6s3CwiLJfBwQ801S9n0 +gwXJw0lOA72Wc1rsDbFat2kiyvg3o9jogPPwmYpfD4F+1VPANJOraZvO4+2e7PPsdXX H9MYBMWpzq/RwwiBGPizGHBNhxzYm9Adj3UNwlh65eBF50TFTozotzwm5VZM2a6g07xL ibUFlpluYtMSh6w9ZL9ilpPewaIDohkSenG6ysSQFmV2q1vgCW2TCVGLdRrDRgpG+wvy RLYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=j0p5N0Io; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q25si3168212edb.467.2020.09.10.00.14.11; Thu, 10 Sep 2020 00:14:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=j0p5N0Io; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730353AbgIJHOG (ORCPT + 2 others); Thu, 10 Sep 2020 03:14:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730257AbgIJG6d (ORCPT ); Thu, 10 Sep 2020 02:58:33 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE6D0C061358 for ; Wed, 9 Sep 2020 23:55:16 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id e16so5448015wrm.2 for ; Wed, 09 Sep 2020 23:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y3aNmNMSAAKySSaB5bb9ahC7IKT1fIK3BKBDgaZqfos=; b=j0p5N0IoFnkC0jPzzxrex1C4xZe5aqi7g6j7/iQDrX3ZY1pp2W9F2bfHuZYIRNydrj KlOKCcnfhmEoNdCXqyyG17AKOphxep4Vd4sIUaMX3x4JDf0n45cBzPGc1pVDmxZYVkcT DdK4cwwSNEQcSQRQtDfbjaFUSWibF+0u30DoOXwBI2pDXDPy+CzzOl7TqK1vjMACZOsd ajwsR0fa5ZIQjHWY8iMNVui88rI0EiJLA7avrXk9qYWqQ8PDHmNnFAJzShdUAyRXW3Ab O1rF88b8mqzTArTf4DnuTfbti2t432HCpO/IXwpbSS0+sYI+MaiDSo+lcirO860FBW6Y DL/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y3aNmNMSAAKySSaB5bb9ahC7IKT1fIK3BKBDgaZqfos=; b=KKgYVpgaYF5+jbsDQCMuah6imqOKBZxn6MMkQ6brdGZb9mWFrp2xVHpCeR/oMCFt58 wP26leczS46bZhIFo9e2tyVlEcmVfnCTazDRKAD5KL8SWJlsX/Hh7inAttO8WD9AYXEc PF6xGUei3SHZfeqEBDRw8DtqCwUpTogyQYMAoggblYKcJImlMpHYJiaVZ8bkc2UiHH83 /025NXNMuwPYFOWd8G3UIW336JerdDcZrIVFphOPAeTannuXlvg1noOXnJLvanwY1vlM 40GP8GY5oxjOqlwNqKtKkJE8AhdGUN6Cr3l0xtxFtG3BVPjaZ9yEwtztZbSt6lDImvsd o/+g== X-Gm-Message-State: AOAM531GIAbJWIaam/JLEinEhY5qBRp5+8DcN/4VqROPgEcPWF8GDW/U bXrZK91xvsJC4Lq+xf5eAwTknfRCk9xGKA== X-Received: by 2002:a5d:40c7:: with SMTP id b7mr7393943wrq.300.1599720915498; Wed, 09 Sep 2020 23:55:15 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:14 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Maya Erez , wil6210@qti.qualcomm.com Subject: [PATCH 19/29] wil6210: txrx_edma: Demote comments which are clearly not kernel-doc Date: Thu, 10 Sep 2020 07:54:21 +0100 Message-Id: <20200910065431.657636-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/txrx_edma.c:155: warning: Function parameter or member 'wil' not described in 'wil_ring_alloc_skb_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:155: warning: Function parameter or member 'ring' not described in 'wil_ring_alloc_skb_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:155: warning: Function parameter or member 'i' not described in 'wil_ring_alloc_skb_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1161: warning: Function parameter or member 'wil' not described in 'wil_tx_sring_handler' drivers/net/wireless/ath/wil6210/txrx_edma.c:1161: warning: Function parameter or member 'sring' not described in 'wil_tx_sring_handler' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'd' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'tso_desc_type' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'is_ipv4' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'tcp_hdr_len' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'skb_net_hdr_len' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'mss' not described in 'wil_tx_desc_offload_setup_tso_edma' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/txrx_edma.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/wil6210/txrx_edma.c b/drivers/net/wireless/ath/wil6210/txrx_edma.c index 7bfe867c7509e..8ca2ce51c83ef 100644 --- a/drivers/net/wireless/ath/wil6210/txrx_edma.c +++ b/drivers/net/wireless/ath/wil6210/txrx_edma.c @@ -147,9 +147,7 @@ static int wil_tx_init_edma(struct wil6210_priv *wil) return rc; } -/** - * Allocate one skb for Rx descriptor RING - */ +/* Allocate one skb for Rx descriptor RING */ static int wil_ring_alloc_skb_edma(struct wil6210_priv *wil, struct wil_ring *ring, u32 i) { @@ -1152,8 +1150,7 @@ wil_get_next_tx_status_msg(struct wil_status_ring *sring, u8 *dr_bit, *msg = *_msg; } -/** - * Clean up transmitted skb's from the Tx descriptor RING. +/* Clean up transmitted skb's from the Tx descriptor RING. * Return number of descriptors cleared. */ int wil_tx_sring_handler(struct wil6210_priv *wil, @@ -1314,8 +1311,7 @@ int wil_tx_sring_handler(struct wil6210_priv *wil, return desc_cnt; } -/** - * Sets the descriptor @d up for csum and/or TSO offloading. The corresponding +/* Sets the descriptor @d up for csum and/or TSO offloading. The corresponding * @skb is used to obtain the protocol and headers length. * @tso_desc_type is a descriptor type for TSO: 0 - a header, 1 - first data, * 2 - middle, 3 - last descriptor.