From patchwork Thu Aug 27 07:35:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248427 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp193643ils; Thu, 27 Aug 2020 00:35:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlTi5UB1TCCN85VrYYwvD9jl3Kj2YTPHc0mZOFjAVptc3XZsuxps52JDvul4RWALGxqKC/ X-Received: by 2002:a17:907:40bf:: with SMTP id nu23mr16995804ejb.47.1598513754333; Thu, 27 Aug 2020 00:35:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598513754; cv=none; d=google.com; s=arc-20160816; b=NXesNkrb6Vc1gVlTV1NCtVLwI8Qu0T5l9grjQKAutwpvOEW+GdINBB+CwluiP2g7Ul aa0/ZNUOzI12nX7dXaqX4Xh2Jk3L1+3xnqdDJgicdx/38EhTGJF4uMFKdqAjxP4r7n8I M7Nli6zAAm0E9CVYlm9UqPU9rCH1uDWLp9kfz/6pMLgPM7Ga0rNHCM77zILEAkubH6Ul XBjqyTOsGiY5fPPGNqufBKJbaSashoGYmj75YtfTR+NXl8RVDRvUnr2cm2GP1Y+11/Lo ljvPr/cvNQfoiOOmIh7585BKgCXouiY1D6MVYMfpSiTYQ8lQg2Nzia7YRuL+WB7JjQOP 48hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=y3aNmNMSAAKySSaB5bb9ahC7IKT1fIK3BKBDgaZqfos=; b=ij0EY/O7p1FEb55/AAbVTrFfVY+dr3Ystiekq6NiceUevH/IjGdWisU/Qseunq05g2 frmSpER+iutID9YsKcGrp8joK4Oa5sWCWe8AHGEDiOVM+d+ssJV6NbF1F0nHGhRKEKjm 4QJLZg9rS2zQKrQZ54mtxB8qkkKXQdGRTNevs36V2YwZIFEgLO5dLlsZIacewa5v/UC1 MidaqOkLkpEFPw5h+z/QJ1+bxnZ85H3amYsTryVOmghxjQgo8fYXC9s/roDkDFqgTevp czGyMcb9eN/Ej9G7/cGhXbpRH1qg9HjaQOQIlNJ17lv9McZLuw6kpmtpiS22Ev+ZvVVk vq4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MhOhwnPk; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b23si830905ejb.465.2020.08.27.00.35.54; Thu, 27 Aug 2020 00:35:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MhOhwnPk; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728202AbgH0Hfu (ORCPT + 2 others); Thu, 27 Aug 2020 03:35:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728105AbgH0Hft (ORCPT ); Thu, 27 Aug 2020 03:35:49 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F348C06121A for ; Thu, 27 Aug 2020 00:35:49 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id r15so4309093wrp.13 for ; Thu, 27 Aug 2020 00:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=y3aNmNMSAAKySSaB5bb9ahC7IKT1fIK3BKBDgaZqfos=; b=MhOhwnPkn/mXHk29S0aVGPJU+5pGzM00XUyRGPLOZAnJUjsvfY0rCUKwzWzrzdKk8B FTmXKFB6z7GR7R/M1UEGZAUnMVK3c7iUB2d6ME0A74idDUUTr8FnttE4PzyNoRn1dDaN 4Fe7Pq9ZXuzFK6T2K/MTj6iemQynffo8dufGq8IT78d+oGaKz/KejTRqiLTf/xnEEQBi slzHFZ6xWq0nv16ud1WN92MQgBuot96gRpLkxkpjddXr3H7lVTHaK9DQ3Y58m2wrCNem F/U3wCjoehqArOBRwez7CFZ4tkLH02bmDlPa9zjB6s6mR2KjUjVFBlpcKguHz9+0lymL g7jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y3aNmNMSAAKySSaB5bb9ahC7IKT1fIK3BKBDgaZqfos=; b=HmQAyK69/zkUB6IYCCZnL/PSVDYN3D3dlu1c2hg39r8PFu5iQwsnx5glkTEeOeuO2b Qywr5wtoxh7kL7iyyeEZPaQg87+D9WwVnrIBHNggd+N9ogQ4dcriTUxI9SaKKRcp23Xa fjEzlwHhnnkHyMeVek5ulDxEukz7BDzUqPnlPAcOAnmuKlhQ7vUzI6uuFY3xWaYQ8mDE MktP0fu+Zz7Iav422/6xnDlC5Rx3SEp8umGQWkHwrZf7Mv0wu/IGZ3YaypsNW+zsJcoO VKUkKxIyalb90KPjruaC0qJutk9NIHCs7izpblZzuvJnwLZQvGVPhyRU22IYcjs5hybA /u5w== X-Gm-Message-State: AOAM531GgI0TDG1bDZoLlunhIOyX3OmpAxVCSWBHgudIEFU2G4xGOO/o pys9BZPjyQ20G4EkkD1EqOgMcQ== X-Received: by 2002:adf:ee4a:: with SMTP id w10mr18352605wro.197.1598513747908; Thu, 27 Aug 2020 00:35:47 -0700 (PDT) Received: from dell ([91.110.221.141]) by smtp.gmail.com with ESMTPSA id a8sm3868108wrh.86.2020.08.27.00.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2020 00:35:47 -0700 (PDT) Date: Thu, 27 Aug 2020 08:35:45 +0100 From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Maya Erez , wil6210@qti.qualcomm.com Subject: [PATCH v2 28/32] wireless: ath: wil6210: txrx_edma: Demote comments which are clearly not kernel-doc Message-ID: <20200827073545.GU3248864@dell> References: <20200821071644.109970-1-lee.jones@linaro.org> <20200821071644.109970-29-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200821071644.109970-29-lee.jones@linaro.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/txrx_edma.c:155: warning: Function parameter or member 'wil' not described in 'wil_ring_alloc_skb_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:155: warning: Function parameter or member 'ring' not described in 'wil_ring_alloc_skb_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:155: warning: Function parameter or member 'i' not described in 'wil_ring_alloc_skb_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1161: warning: Function parameter or member 'wil' not described in 'wil_tx_sring_handler' drivers/net/wireless/ath/wil6210/txrx_edma.c:1161: warning: Function parameter or member 'sring' not described in 'wil_tx_sring_handler' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'd' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'tso_desc_type' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'is_ipv4' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'tcp_hdr_len' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'skb_net_hdr_len' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'mss' not described in 'wil_tx_desc_offload_setup_tso_edma' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/txrx_edma.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/wil6210/txrx_edma.c b/drivers/net/wireless/ath/wil6210/txrx_edma.c index 7bfe867c7509e..8ca2ce51c83ef 100644 --- a/drivers/net/wireless/ath/wil6210/txrx_edma.c +++ b/drivers/net/wireless/ath/wil6210/txrx_edma.c @@ -147,9 +147,7 @@ static int wil_tx_init_edma(struct wil6210_priv *wil) return rc; } -/** - * Allocate one skb for Rx descriptor RING - */ +/* Allocate one skb for Rx descriptor RING */ static int wil_ring_alloc_skb_edma(struct wil6210_priv *wil, struct wil_ring *ring, u32 i) { @@ -1152,8 +1150,7 @@ wil_get_next_tx_status_msg(struct wil_status_ring *sring, u8 *dr_bit, *msg = *_msg; } -/** - * Clean up transmitted skb's from the Tx descriptor RING. +/* Clean up transmitted skb's from the Tx descriptor RING. * Return number of descriptors cleared. */ int wil_tx_sring_handler(struct wil6210_priv *wil, @@ -1314,8 +1311,7 @@ int wil_tx_sring_handler(struct wil6210_priv *wil, return desc_cnt; } -/** - * Sets the descriptor @d up for csum and/or TSO offloading. The corresponding +/* Sets the descriptor @d up for csum and/or TSO offloading. The corresponding * @skb is used to obtain the protocol and headers length. * @tso_desc_type is a descriptor type for TSO: 0 - a header, 1 - first data, * 2 - middle, 3 - last descriptor.