From patchwork Wed Aug 19 07:23:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 247931 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp243402ils; Wed, 19 Aug 2020 00:28:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgaly2EylBGKG0kKsACYaChw5yjB3Qj8DspiBNLYKSzV1uWtIx6Un2Ouei+I46RONFw7dV X-Received: by 2002:aa7:da8c:: with SMTP id q12mr23967054eds.126.1597822138410; Wed, 19 Aug 2020 00:28:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597822138; cv=none; d=google.com; s=arc-20160816; b=hxly5Pwzb3VCMdA8BxSpFsNcponILxCtc+pdfFMnZMuy6whNcgguFDl0IEkvmypCJc lLy4baAoim8CWZU+gBuZopGhEjR6yevTaoSZgtWGlZWq9Hc44InkvX63UKiE/C3XLS7n v7mnpZSyOHWDTJHPasHpaWr25R/py26AYSyHlfd6hphVpu05jGQkz1pQVYfnyexKnA17 3gwJs3gpAM5icqfTp3A3Yk9+MnPDHgt3zub0w0DB6jkZKaOyOsmNXOcJQ9XxvwRFQkG8 D20veSYgyF4yhxPDgRbafOIjYM/Et77xObmt9v0a30TwR1Fsb8s5Vs/wl/HhcoBay11n KJpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=OmSKHzIzkJi68F2fKwgFCX3ILOuvM+7+kNq4/3nmwoQ=; b=VsS9OPd+DpcyIeC0unYDr63Nm0DzdLuZTwvDLTla7ysJPfiODS17TYJxsuhVJ5XDun l8ivYr7RBm6Tam1hu3M0lyHNm5Spfhs/wcNrGLq0lGn1owxdoVmugW5nHrntK2NrGeme nGeyBTBqf1nWSucb9s9ZjeVMK8y4aK1e1AWwBRGxCwP/Gfy/f2OqT2mH0ByXVJULA9gf 1rGYf1s9/EM9aE/6EOrQFL7LbmllNmBdORxFBkHmch95LYyB1D1Duh6hKn7ulkgaLvLc 0/nLh0K+hEEwBMYg6HFQ5CteJS9eRB7l37I2c6Sd4WVodKaQK0n/5ChLLArAltdA6i9k nKbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vBNBtXIZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v5si15174975ejg.368.2020.08.19.00.28.58; Wed, 19 Aug 2020 00:28:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vBNBtXIZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726835AbgHSH25 (ORCPT + 2 others); Wed, 19 Aug 2020 03:28:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727944AbgHSHZS (ORCPT ); Wed, 19 Aug 2020 03:25:18 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2103C061372 for ; Wed, 19 Aug 2020 00:24:28 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z18so20436805wrm.12 for ; Wed, 19 Aug 2020 00:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OmSKHzIzkJi68F2fKwgFCX3ILOuvM+7+kNq4/3nmwoQ=; b=vBNBtXIZSWF7g27W+eeXxr7ZjwuIqe6jFQIMTyxVridWuKQOwrbwEeyB835OdGK1AZ YT4VAcdYpQggD5sWVnsFlZ3avb1db8mOMmF8paflWmNkkgqPxXA9hbLBcZ0BIYkvg9UD qQO+NOvhJzOqGHQt4uQN9s7e3YYfPsAqQTx0Z7RDCa0UTH2zWeonkDJRquXo9hy1UwKd Lxx1sR70MKCwaXOKz6IpLk0t/RGVWverH5HLZBP8OfBp48NlmwWSjOTjLFI8jVWj/SH8 Jo9WrdBRUL4n7pAyKcYPMcTro9QmpVtXoctyEetp/61ed1wBlqkFW/h5UgnQMS+jVulL qIQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OmSKHzIzkJi68F2fKwgFCX3ILOuvM+7+kNq4/3nmwoQ=; b=cWuhya4sj8agQ9GQ7aK0fhGILDyJjTk0GR692lJ77HWEHi2BhKpEA4njWzs7XjtXZ5 YcSJ0wQWXGF5K1A5gnxH7iklxGVcESEjZLogNgKsSt3D+6xxqyiaw3Y73CRCAKpZt9/U EcCtZINX+aTots15M3JR7WGa9cSeGO81IDkTg4ak6pXQ2cNbvza//lcc1i1VzDb6drQa rwlxrIConHtZMaj9YGe+b7RtBx12BHRHox9E8FwmG/vlYXdbw0Nij6/fTwQrrcuEle3y aovUZZ25pZaFj+rENDNudMWIjLld3+VuMx6NBtZZvUldVtgnh/C5t74VKyAh003VeblL ve1Q== X-Gm-Message-State: AOAM531GFvrV+lB8tS583uXvsDUUHyBh/3adl4AklMTG4kwh+3Zzrq4k PpUH4fVulIo/HtlucBWgPkch0A== X-Received: by 2002:adf:c981:: with SMTP id f1mr23428625wrh.14.1597821867580; Wed, 19 Aug 2020 00:24:27 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id c145sm3795808wmd.7.2020.08.19.00.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 00:24:26 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Amitkumar Karwar , Siva Rebbagondla Subject: [PATCH 18/28] wireless: rsi: rsi_91x_mac80211: Fix a few kerneldoc misdemeanours Date: Wed, 19 Aug 2020 08:23:52 +0100 Message-Id: <20200819072402.3085022-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200819072402.3085022-1-lee.jones@linaro.org> References: <20200819072402.3085022-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org - File headers should not be kernel-doc - Misnaming issues - Missing function parameter documentation Fixes the following W=1 kernel build warning(s): drivers/net/wireless/rsi/rsi_91x_mac80211.c:24: warning: cannot understand function prototype: 'const struct ieee80211_channel rsi_2ghz_channels[] = ' drivers/net/wireless/rsi/rsi_91x_mac80211.c:739: warning: Function parameter or member 'vif' not described in 'rsi_get_connected_channel' drivers/net/wireless/rsi/rsi_91x_mac80211.c:739: warning: Excess function parameter 'adapter' description in 'rsi_get_connected_channel' drivers/net/wireless/rsi/rsi_91x_mac80211.c:868: warning: Function parameter or member 'changed_flags' not described in 'rsi_mac80211_conf_filter' drivers/net/wireless/rsi/rsi_91x_mac80211.c:868: warning: Excess function parameter 'changed' description in 'rsi_mac80211_conf_filter' drivers/net/wireless/rsi/rsi_91x_mac80211.c:946: warning: Function parameter or member 'sta' not described in 'rsi_hal_key_config' drivers/net/wireless/rsi/rsi_91x_mac80211.c:1245: warning: Function parameter or member 'vif' not described in 'rsi_perform_cqm' Cc: Amitkumar Karwar Cc: Siva Rebbagondla Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c index 5c0adb0efc5d6..ce223e680cba6 100644 --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c @@ -1,4 +1,4 @@ -/** +/* * Copyright (c) 2014 Redpine Signals Inc. * * Permission to use, copy, modify, and/or distribute this software for any @@ -731,7 +731,7 @@ static int rsi_mac80211_config(struct ieee80211_hw *hw, /** * rsi_get_connected_channel() - This function is used to get the current * connected channel number. - * @adapter: Pointer to the adapter structure. + * @vif: Pointer to the ieee80211_vif structure. * * Return: Current connected AP's channel number is returned. */ @@ -855,7 +855,7 @@ static void rsi_mac80211_bss_info_changed(struct ieee80211_hw *hw, /** * rsi_mac80211_conf_filter() - This function configure the device's RX filter. * @hw: Pointer to the ieee80211_hw structure. - * @changed: Changed flags set. + * @changed_flags: Changed flags set. * @total_flags: Total initial flags set. * @multicast: Multicast. * @@ -936,6 +936,7 @@ static int rsi_mac80211_conf_tx(struct ieee80211_hw *hw, * @hw: Pointer to the ieee80211_hw structure. * @vif: Pointer to the ieee80211_vif structure. * @key: Pointer to the ieee80211_key_conf structure. + * @sta: Pointer to the ieee80211_sta structure. * * Return: status: 0 on success, negative error codes on failure. */ @@ -1008,7 +1009,6 @@ static int rsi_hal_key_config(struct ieee80211_hw *hw, * @hw: Pointer to the ieee80211_hw structure. * @cmd: enum set_key_cmd. * @vif: Pointer to the ieee80211_vif structure. - * @sta: Pointer to the ieee80211_sta structure. * @key: Pointer to the ieee80211_key_conf structure. * * Return: status: 0 on success, negative error code on failure. @@ -1237,6 +1237,7 @@ static int rsi_mac80211_set_rate_mask(struct ieee80211_hw *hw, * @common: Pointer to the driver private structure. * @bssid: pointer to the bssid. * @rssi: RSSI value. + * @vif: Pointer to the ieee80211_vif structure. */ static void rsi_perform_cqm(struct rsi_common *common, u8 *bssid,