From patchwork Fri May 15 08:33:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215603 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63098C433DF for ; Fri, 15 May 2020 08:34:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D28E206F4 for ; Fri, 15 May 2020 08:34:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="fK2cOhFH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728371AbgEOIej (ORCPT ); Fri, 15 May 2020 04:34:39 -0400 Received: from mail-dm6nam11on2086.outbound.protection.outlook.com ([40.107.223.86]:6138 "EHLO NAM11-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728329AbgEOIeh (ORCPT ); Fri, 15 May 2020 04:34:37 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hWtqyw7OvG5ftZl1C0XP4XTKLOHDiLvz0CuBcAfu3DzRKN4LImU6AS5eE+naT+1NNwW11RFehVCE9v7bJcxVOxp9q9AGfjic1xUaT5cE3M4CuLIlfhCcMda9DdFqv9lgK/Ob75audjfv9UJOW2luuvIrX1ilK3JtcuMPkQ+snxU2VD+4pZqZ+5TeppOC1KQoYCSckoVemw/lzdKh9yn1wyKzvwUe8Nq6hH+t/LoyXz8n4JUAKwlUPYBjryk1woWz/jpqFV0ILg55QOBAzxRrScmPi+p3gjllhOMDfvUPIxTXt6LfqN2tfdrfp8IwPZd8TvHgJA3swJR9LdPKatvqWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gA6OR2oUdWaDAB+nq0jkFBd0As9cc8QT1KEc72rsWyI=; b=MXDflFDbTZYSKFTtxQ455I/NoPena4MJvhW9fWddVaqsI1BtFztnpEBYa5+22AnWAfzt6ZxeEvzrdafiAlEcuBTec9vSUhI9fs3YlWoVd5eAtsASjGIDkTRhxbqNEDpbUQZPq4sBc++7CTdrg2QV51Pp2QbV/GoINB/DomOtSU5SllhpHv2xJNp2bk0O60efOsZ0p/P1fvbvlJRmtfUdhVx51t+C7/OQNs8R4w7QMkzplyylmcvrdUG7emZ1Jktyg9vBMQBhDUhtFY9MHw3TQ3vVKzeG+zA+zJ6Fq1I+leFC6+oPPLgUCDNIZvnjKszyMB43Tr2p4Qh22Yebae4tUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gA6OR2oUdWaDAB+nq0jkFBd0As9cc8QT1KEc72rsWyI=; b=fK2cOhFHvMI/w+md359s94GT4tK6+C/GDcFNUzWDXjLSVrbpAEffxY3pmnLlmvMcaZ2AKpE24fc5z7cwO21CyKZvPvZtxY2HFE0YNqc6+CpuOgTH6+rlArBtpaKbDWemIvLuoJ6bI1pCxIlY6mmQ3dzNHFyIAU6Uu4unqP40t0U= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none; driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1310.namprd11.prod.outlook.com (2603:10b6:300:28::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Fri, 15 May 2020 08:34:20 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da%5]) with mapi id 15.20.3000.022; Fri, 15 May 2020 08:34:20 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 17/19] staging: wfx: remove false-positive WARN() Date: Fri, 15 May 2020 10:33:23 +0200 Message-Id: <20200515083325.378539-18-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200515083325.378539-1-Jerome.Pouiller@silabs.com> References: <20200515083325.378539-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0076.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::16) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (82.67.86.106) by PR0P264CA0076.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Fri, 15 May 2020 08:34:19 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [82.67.86.106] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fca40e28-9172-474d-31d1-08d7f8aac3a4 X-MS-TrafficTypeDiagnostic: MWHPR11MB1310: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 04041A2886 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kxc2GBEh10E5AJW0iZM2sKa/aAboNACW5nEFI7ZU541QOQas0dJxZr2MVqnwmoMl+33iwg2InHhTUNCEzIiQ3mjrzZxozg0A1WiaOEfjLvZzfevxSYE++jbes1SLh7eEXxUzly4buSnOvKyY/Cr74j6t31PG1uaxNhEGwsonIAG2NGAGNEIIk65HFyMFGBO5GjYBuDWYUHbuoGGddasi9VQau4EX+GQl2Ppp/s73/S0XmBgl0cUwstKE2jBpkIEaFX3AihlxiXV1MqccRNBXEAheQX+ka9VGKW8mAtovGK3pQrA1d0vfqtCiRZThk7C+mWw558C1ZZYoFhON8L/urW2grE0+hP2OSRvyHPVY9nXKcuGbNiYig/OlYBuBhza7GXQWXWMUqP3o6BfGvqhJR4igY6UW/dW9I1PQILE78Yie1bZ13gmM9w/jHnNPvSDS X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(136003)(376002)(366004)(39850400004)(396003)(8886007)(66556008)(186003)(6512007)(66946007)(6506007)(36756003)(316002)(66476007)(26005)(52116002)(16526019)(6666004)(54906003)(2906002)(2616005)(478600001)(66574014)(107886003)(956004)(8936002)(86362001)(8676002)(6486002)(5660300002)(4326008)(1076003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: bWwi66Q7D7gg5SHogjpjj51ZFAbIHFjzY7yjT4Bd7ydF66bOBFnQTqeD5NXDPw9foPRVpPvuXqe4HwBndo5mBdKKycgD+2ne9czKwNkhOMicx3Ij8EZE5J5Fyk1tgh0C26y+g9k19mSrCmBKi4ih/io2amd2Ol3SUqTBFr5KsIvy8l8KjsBLHSIidZIFnzhe0Z4RrOF69xoYsha0bazGQSrO2oGy9PEQAFt+gnyhh4Vqs+0JLQqhZmLr3vsuUe5BM8StCpYukZMjP+kPUlqSPuZLb4v6kzNdky3yZtpJSiyLe1axOW9XGxioaLdKbJGxZKHBPmIs19cTRS+7VoxTgm0be2bBCx76PBZFJxjtwMMpTPzXlmamBI+Qdlgekq+PcJ8bW1HPbuqSIBgCYFXDkIZcn3k723J+DH6T5YX01XLiRF0jGQobdI/4j00MzrjIXfQm5RZ7gQZJwMqpPCATQXhy0LovPTHYPUysLR/5SxI= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: fca40e28-9172-474d-31d1-08d7f8aac3a4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2020 08:34:20.7670 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gBFOxPy+qeww3kRKJnJBRhsyotDZp5GaMNTJ6aNuwNUO3W0tkPSmKC3nTUoPkgICeXWTfy+HF1GJtvZklA3Gww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1310 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller The function wfx_tx_flush() wait for there is no more queued frames in hardware queue. Then, for the sanity, it checks that there is no more pending frame on any AC queue. However, there is a race here. It may happens that hardware queues are empty, but the counters of the AC queues are not yet updated. So, it may produce false-positive warning. The easiest way to solve the problem is just to remove the sanity check. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/queue.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c index 0c799cedd101..26b141cbd303 100644 --- a/drivers/staging/wfx/queue.c +++ b/drivers/staging/wfx/queue.c @@ -30,7 +30,6 @@ void wfx_tx_unlock(struct wfx_dev *wdev) void wfx_tx_flush(struct wfx_dev *wdev) { int ret; - int i; // Do not wait for any reply if chip is frozen if (wdev->chip_frozen) @@ -41,12 +40,6 @@ void wfx_tx_flush(struct wfx_dev *wdev) ret = wait_event_timeout(wdev->hif.tx_buffers_empty, !wdev->hif.tx_buffers_used, msecs_to_jiffies(3000)); - if (ret) { - for (i = 0; i < IEEE80211_NUM_ACS; i++) - WARN(atomic_read(&wdev->tx_queue[i].pending_frames), - "there are still %d pending frames on queue %d", - atomic_read(&wdev->tx_queue[i].pending_frames), i); - } if (!ret) { dev_warn(wdev->dev, "cannot flush tx buffers (%d still busy)\n", wdev->hif.tx_buffers_used);