From patchwork Wed Apr 15 16:11:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 215997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 439E0C2BA19 for ; Wed, 15 Apr 2020 16:15:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17EED20656 for ; Wed, 15 Apr 2020 16:15:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="Okii4WV7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415445AbgDOQPZ (ORCPT ); Wed, 15 Apr 2020 12:15:25 -0400 Received: from mail-bn7nam10on2054.outbound.protection.outlook.com ([40.107.92.54]:6037 "EHLO NAM10-BN7-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2410244AbgDOQMl (ORCPT ); Wed, 15 Apr 2020 12:12:41 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jqDm9owojMYMX/hrwgy1cVgcCMS/sSUvFuqP4b0TW4NeJnH4N0at0GfOYBYd6PMpiUQemeU13+3crqOQ0svIRRj+rqmj1xBJT6pkTW2tLcCul/UtAxOIIf9atIRe6MouPx7x0hyWN9tb5VKeksGUrvYUu663vVhBsT0j/w5urNdUeFvBqdFfADlW8Rn89gFTKZ1Y40NVTZK+hOlmQanS9iXTIyID7Zz4XTsRuHXgQeh0v5G7mnKoU3N7smv4i2s97EyMo3kbwF6kAnLjrczcFGjs7Fm5mK/8wnI2Tgd7ju2PRJc/LCnejn2zNwdjOsdC5vcZLxAt6RAe7hDq2neD6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9nxtLj7G7XHMe7btmeHWLVBb66C5a5GyMZEEY3gGfKc=; b=mH6HMefeS1tOTD2aSLSd1fkGnbhp0Gvd72kskPwOUF/DPq+FQVo+g8oii6AugniOXJnbWfbUlv0G/36lgmGAkb1uSCaMny1/ROzKKQi6Rtdw623nJbF2O29mBzp+0bS2b0txEgAoD+pRVPa1ujCbWvXOWv87V6HhZ9jVMHeJM8HOves4gXIw3E6cNyW0pO5uBQYooijOtQaPSdauxOo29p9dXy6r338GJ0r67pOjoffZZ+O6wzbXAeG9fpccTre5d09EIT2Vzx6QGomWL3lZqZZsrLPtyWLekhNJUriZ3b/v3os4D1MloGmUoCbbpdaIYuKEItNLLlK0MlRFkOWJlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9nxtLj7G7XHMe7btmeHWLVBb66C5a5GyMZEEY3gGfKc=; b=Okii4WV7JRTVtHBhesSpJe8YDH8sID9P2F+3mt9RDb1POYzxjPcBV2tSWOh9C5rqglphQEJbLz89SRwhBwN0AG/0XMzThbNpSb6qyNogdZEpMQFlYeLRrdAVwNJP6VkRzOWgQDqCXZd94MeZr+waN/WBz201VYPkdPvP7god4ls= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1599.namprd11.prod.outlook.com (2603:10b6:301:e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.28; Wed, 15 Apr 2020 16:12:37 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:37 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 10/20] staging: wfx: ensure that probe requests are filtered when AP Date: Wed, 15 Apr 2020 18:11:37 +0200 Message-Id: <20200415161147.69738-11-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:35 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e33c508f-29e6-44ae-d460-08d7e157d0b4 X-MS-TrafficTypeDiagnostic: MWHPR11MB1599: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(376002)(396003)(346002)(366004)(39850400004)(136003)(4326008)(66476007)(107886003)(81156014)(86362001)(8936002)(2616005)(6512007)(6486002)(316002)(52116002)(66556008)(66946007)(6506007)(8886007)(2906002)(1076003)(36756003)(66574012)(5660300002)(54906003)(478600001)(16526019)(8676002)(186003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B/cicagr4l+JnqMyR1SA353fr7oCh+XlYbeD/hRppwtTjt2jEjpUpMwLK6i1zsBWLON/sJS0s0HNyuYXsjCFxJSFa3qIcBg9hxvkBRs2Dl7uX4DalitJGUualO9oHLtCkJTDDJGsMTPP8KWnPNaSF3d+5cVGzhtvFjvy2jTmpkNBO+I8SfkDz7aFuHWrB+z/goZcmlspDQ+PP5/z6E5zAWirXDfELbExW+YpbAks7FCDyAyC49PfR9+qe8FzvTjT6kgEuZfAaSyQbfnsjooQiaTWJlqSW0E2F/xk+U5Ja4m8wWjvFncr9rKI1NOb88zCPJ9vEAeKcMadOV7ODsumeDrCkor2JHPLoAQXkudiM8JQ3fGdMr1hZYsLZLC/2kXbc2bzrzGpSs3JYyaRGiT5/WcCsB7x0UjkzEVXac/DqkWTxJXLkkE3h9c8RaHrNkmL X-MS-Exchange-AntiSpam-MessageData: /73MTPv8s1zrdRgheHZ8ScoJ0oZxze/PFaHSe7Vuu9k9Xj/MCC8QEj2BLuQvEPJe8RFB4vq27b1s+t702GpNtpsIEmNN+7rLfQXAEk9cGjLS9cYw5ZnOg7gSc/H7Y96H3cOSWhxb7Kb703B9tUyItbVsfq5sSewaOOsOldTX/fUvz7Mn66T0tdJD/8w+tdSE7oJQUwmP9E9vH91CWjKPqA== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: e33c508f-29e6-44ae-d460-08d7e157d0b4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:37.7110 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8D7tuwZ9TNJugDx5tNPj/mqnH1E7w4KUOsoLQ1e/AzbX0BsAUoYJ5wjjGTV8+qpVxWuSrjv3L6gvd4x3/NzuYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1599 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Device is able to automatically reply to probe request (therefore, the probe requests are not forwarded to host). This feature is enabled by wfx_start_ap(). However, further calls to wfx_configure_filter() can disable it. So, relocate the handling of probe request filtering in wfx_configure_filter(). Note that wfx_configure_filter() is always called by mac80211 when an AP start. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 0b2ef2d3023b..b785b1b7d583 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -241,6 +241,13 @@ void wfx_configure_filter(struct ieee80211_hw *hw, else wvif->filter_bssid = true; + // In AP mode, chip can reply to probe request itself + if (*total_flags & FIF_PROBE_REQ && + wvif->vif->type == NL80211_IFTYPE_AP) { + dev_dbg(wdev->dev, "do not forward probe request in AP mode\n"); + *total_flags &= ~FIF_PROBE_REQ; + } + if (*total_flags & FIF_PROBE_REQ) wfx_fwd_probe_req(wvif, true); else @@ -577,7 +584,6 @@ int wfx_start_ap(struct ieee80211_hw *hw, struct ieee80211_vif *vif) wvif->state = WFX_STATE_AP; wfx_update_filtering(wvif); wfx_upload_ap_templates(wvif); - wfx_fwd_probe_req(wvif, false); hif_start(wvif, &vif->bss_conf, wvif->channel); return 0; }