From patchwork Mon Oct 18 12:33:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loic Poulain X-Patchwork-Id: 515922 Delivered-To: patch@linaro.org Received: by 2002:adf:a11e:0:0:0:0:0 with SMTP id o30csp3416433wro; Mon, 18 Oct 2021 05:22:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8xfmKLkNA/plRIhDHTNM8oaUkoGv1/ldezwpyCnP3b7acMBVjLtNneEUiK5b/L62dLV6I X-Received: by 2002:a9d:701a:: with SMTP id k26mr22810839otj.109.1634559727052; Mon, 18 Oct 2021 05:22:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634559727; cv=none; d=google.com; s=arc-20160816; b=h/oty12hcVILlUghTt7Tp+prldkLZeThXia9ZJUBVeDcCiCd47Zh/6+U235X2h7UYS YgYMPNSsi88Y343fXV1ReInnsy2jJZPsCcnmQ16OtL8QLDne9hE7eEwh1zkjioVUA3QP Naw1X4QFBA5pyDePnybLbDW+aj4aZ2BJjC0TjY6ABDhFk+wGk2BNUzdKe6sJrGGjsEN6 bmF1VYP8Fldo4A3KvgoEMXycyI/MeoY85q5cCLHTPSohXh5J8fLOt3WIHorMqgy8pUyi sh8nUU8qvu+/aIxlYZRVk4mkXhnFRSvGGGGwbLtk1KGu8hD1t/ifiGHv0mEJhKB1ooWc dpdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=SMIbUAfQTFU43rmQBCVjZo2PmcHEvZb4gSDDxo3uXD8=; b=Nzq3e2837n8tkBzhMxtA0XwvVhgxxQVOMleYmYiG4iAsnKGvXD6XCRHlt99jHnRN25 NOZzToqCVpKGZG+y0PBMw+G1PE2Dv3Z+zFMIW37JbQHMWP7X7npZlUFjjLItyypUpRUa rYZE3/gFWPOHoFkOIqPf6FChurvhmRP6FjbudNX1V6umWhpNS/PGz9JHTt9ShxdvTjWf nsD2zqSwccyodlV5uK6u1bOuj7lPKwNt4QlO7Z1yvUsFZ4UQMWvk3yKfuTOtXTnynor7 RmVKvK+tNcmBfNSZuYr4HKGDFat0Esto3WBzG+w7I5O9ZEAniEdAp/x5/Z8sndm9L1ba i3oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b="lO/+WmEg"; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=tL4VHalK; spf=neutral (google.com: 2607:7c80:54:e::133 is neither permitted nor denied by best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by mx.google.com with ESMTPS id c84si14960357oif.121.2021.10.18.05.22.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 05:22:07 -0700 (PDT) Received-SPF: neutral (google.com: 2607:7c80:54:e::133 is neither permitted nor denied by best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b="lO/+WmEg"; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=tL4VHalK; spf=neutral (google.com: 2607:7c80:54:e::133 is neither permitted nor denied by best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=SMIbUAfQTFU43rmQBCVjZo2PmcHEvZb4gSDDxo3uXD8=; b=lO/+WmEgHS8N5K roctYEB3V5ZsGrq2J1HtLvI2uAreOG8bgbb4Nfe8IltqQoM6kTHh3Hj/HSqyKyaDunuTDv57GuTF7 i3Mr/k1wlDAqEJJ1QwK1l47iEWJGxm0/CKbMjG6NWl2wDCBut29zGR/NUNurti6rZJiM7eUHPWuBR vqLxl14g6CU+dW5WEO/8hbFxUhuPKTCRL1SG7ZqlJ/S0bys/n1q8+3a23ncQeVdYKDfwdSvWEvP/v gzUZ156A/ZPWoRxpwchWQPrYKjUpDgczXY/rKDYUCBLgjIR1GQl7qiqU0rYS6Yb7lJf4G703+eMG2 LQ3YERTpbYHV2ZGnU1vA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcReX-00FcvB-Hm; Mon, 18 Oct 2021 12:22:05 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcReV-00FcuY-5C for wcn36xx@lists.infradead.org; Mon, 18 Oct 2021 12:22:04 +0000 Received: by mail-wr1-x433.google.com with SMTP id r18so41032098wrg.6 for ; Mon, 18 Oct 2021 05:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Tsy0ou00jA9sgdD3QEDwwcOaq6zikEvYydKUg/U2lOI=; b=tL4VHalKBtDnJmE/VJ+Mhf0hiohhiXU/SvdITVRh47oKKhPg6qptsGcIfSyxZYnb6h Yu9Lxv4hXlNmEzDzvgiPJZVccK/oLo9uFgp/t3tdR6o/NRVl0nNE2Cr1CHmJbEPD0ntG pxdasCLszZ2eCwKDACJTEUhMi2Zf5eqd4SVnzDnziRh3LHRTzFXQKKn/LHfz4srVphxI c2Jx4jfuDHQbDJqwCFQ3EJUyZOtWP3+fpt5DIEndHdpH2OWGlooM532MEezKve1F5CTF WNHIsN0wz9U4N+2PutWxEIHpdgIMTQyl2yk4milADMbGvOLvO0QCCFysb3Jf+sP0vR9c hlXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Tsy0ou00jA9sgdD3QEDwwcOaq6zikEvYydKUg/U2lOI=; b=CD7zC8dU9O6AwfuZh1MrXu23aLOg1jjBefYdCu8cvLPrH1M1VPJ2Vulo6ph7Z8bSeQ vOxrS/qzN7VhRpPN7CJdDyyU30k82o3Jvd5KxL4VC1Dh6Rlq8jUX5GfCwp3Vm/deJ1fB 4Uo+DylWRWQPvBLTFHyItZpXS7n5+I8Lb/7/5sl/XAJCspDeB+qrsByKmBQ18x7QuH7+ tBRdgnsWGXkHhynuo3XU4nMhg/orxhyiligGjeuxfZkjLNnmrs0xVRiDkRTm8JxaK0mD X5COJpHX6aIer9+065Abihc/2d2MhJkoRTK9SuK9+w9KVyRyniev7AJH7ENlRKJlh0Gb pWWg== X-Gm-Message-State: AOAM531FF/4MG3K2SqRkcsNE0yUSA+lpHJpQBtekVzM6J+xPKLUY2VxX NzkAN04pcMNxoEOFZon2Y8hUTA== X-Received: by 2002:adf:ab58:: with SMTP id r24mr34816657wrc.200.1634559721105; Mon, 18 Oct 2021 05:22:01 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:82c:5f0:9df5:c752:530b:345b]) by smtp.gmail.com with ESMTPSA id s3sm12327725wrm.40.2021.10.18.05.22.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Oct 2021 05:22:00 -0700 (PDT) From: Loic Poulain To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org, bryan.odonoghue@linaro.org, Loic Poulain , stable@vger.kernel.org Subject: [PATCH] wcn36xx: Fix (QoS) null data frame bitrate/modulation Date: Mon, 18 Oct 2021 14:33:19 +0200 Message-Id: <1634560399-15290-1-git-send-email-loic.poulain@linaro.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211018_052203_233376_DE6BEFBC X-CRM114-Status: GOOD ( 11.19 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: We observe unexpected connection drops with some APs due to non-acked mac80211 generated null data frames (keep-alive). After debugging and capture, we noticed that null frames are submitted at standa [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:433 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org We observe unexpected connection drops with some APs due to non-acked mac80211 generated null data frames (keep-alive). After debugging and capture, we noticed that null frames are submitted at standard data bitrate and that the given APs are in trouble with that. After setting the null frame bitrate to control bitrate, all null frames are acked as expected and connection is maintained. Not sure if it's a requirement of the specification, but it seems the right thing to do anyway, null frames are mostly used for control purpose (power-saving, keep-alive...), and submitting them with a slower/simpler bitrate/modulation is more robust. Cc: stable@vger.kernel.org Fixes: 512b191d9652 ("wcn36xx: Fix TX data path") Signed-off-by: Loic Poulain --- drivers/net/wireless/ath/wcn36xx/txrx.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/txrx.c b/drivers/net/wireless/ath/wcn36xx/txrx.c index ef1b133..ce4f631 100644 --- a/drivers/net/wireless/ath/wcn36xx/txrx.c +++ b/drivers/net/wireless/ath/wcn36xx/txrx.c @@ -535,6 +535,7 @@ static void wcn36xx_set_tx_data(struct wcn36xx_tx_bd *bd, if (ieee80211_is_any_nullfunc(hdr->frame_control)) { /* Don't use a regular queue for null packet (no ampdu) */ bd->queue_id = WCN36XX_TX_U_WQ_ID; + bd->bd_rate = WCN36XX_BD_RATE_CTRL; } if (bcast) {