From patchwork Thu May 3 05:56:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 134879 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp1516869lji; Wed, 2 May 2018 22:56:29 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpwd8ATUkFoCxT5WpvaB/6Zw3PcrLcYdwLNw+IKAwwam/nm5V4PU4ZD3hTR2hpRYufBmISo X-Received: by 2002:a17:902:780d:: with SMTP id p13-v6mr22839841pll.281.1525326989831; Wed, 02 May 2018 22:56:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525326989; cv=none; d=google.com; s=arc-20160816; b=QIHT0JDXz4+09e7E1xVcqB6218SDxyaPQJn/BqqmXNLnkI/e0hi8RI0Viz0GwoKzOx BLx0JOAGSKQIiZs4SnYcxnYoNWDNLnNhE7HryxKiHeyQBDBDSNBdz91+xQMRGNkO+eF8 x9/GTFtloakzOlUFhC03C+Q643CshH9xxTiDkbUdIzJ4I6Pa3a5WTciGL6Rs4DRDkf8n nGKqtLWpsZTjzQhk5KaUSmVc3PRpU4wIjB+Qnlxxle4K13y4Vdr0o129kami/kFk0sBM 6NC+/GLgM+bJ4Yylh/IcKOeZ4GEMjT/SFsu5QQCJhYLu8VmuL7EcUD0PTkpjAzukoYPL oxtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=4FhPgOtFbhiexgn4BT+gCIUjkqiM1Ja0BNHe0H45OXY=; b=feMN56scI0qt0H5vRS1elRSgPttOmy7yNjZaQlaiYryva+ZDApI6V0iCeCNcfWdiBj rlimvFy7rUFzja1DOncIiBv2CJP0nsXneOnHfg8B0cdwiBJqcYYeahIXIchHmnhuhykU /fT+cwqHvFypOAXilV1LCx/RDROnRQklV9sRO1KCnb3bRPOoil0kXjwFRmmcsK/24XQr ZmApnaNqZlgkufPoL/G6Tzqr3NVyOKTNwXpgdVR7uCJFlLbmOQ99IhvS3XDtMeqcLgOA dr7/yTp+r0stE6eZA53oOV13KL8XIE4qiDWGnV9uymQrilqYpcdYCW/Ew/Df5D5Tf0Fz gnuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UoUZngCZ; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7-v6si12961028plk.397.2018.05.02.22.56.29; Wed, 02 May 2018 22:56:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UoUZngCZ; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751977AbeECF41 (ORCPT + 3 others); Thu, 3 May 2018 01:56:27 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:39282 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbeECF4Z (ORCPT ); Thu, 3 May 2018 01:56:25 -0400 Received: by mail-pg0-f68.google.com with SMTP id e1-v6so992911pga.6 for ; Wed, 02 May 2018 22:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=4FhPgOtFbhiexgn4BT+gCIUjkqiM1Ja0BNHe0H45OXY=; b=UoUZngCZ6o96Mtcjekkw6WGiM2HssYtS5t5w4DogrEC3+03yl1hPIAYcQkNWTPaHqH 41yH4gz8k84QW179N0uSYd5IHVOBELeXvCmzPSWFBTfJ5YrfLu/I6eJ31YYTUhpiZ6/R YFsYxRk235XyngEiJXbxLLxSofaVGpUKqfAL0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4FhPgOtFbhiexgn4BT+gCIUjkqiM1Ja0BNHe0H45OXY=; b=GfEME08M8sFmasXBghGDz/Pfs2tjraW+/qv2YV6T0bKnogIkObKrAxiwquGoCENaA/ d/6bFhf2VRzshPa+McYK49a5zaU8D6VYVPGeaRsTyqaJXKNbL8lrfJL33i/a90961fA0 xSJOHZ9nhwwoyc+cEzOpDTdVsVyJBmV8X4gc25swYebclurrq15s0KrVdVQrHgWS6uW0 h8jW3Hsg+3pZF8E8SOc1N3LCVWdNc1OSzuyhZxdswoD4SxevWu4+KfnbR5S5R5fe4VTA suZG06TVapsKuNZo0jLFpgTqSiK16qtp2YRie5bO2llMww+sFbvBgouH/whe5uP/CCRn 8oLw== X-Gm-Message-State: ALQs6tCkB2iJJWhnSgdZpnk6SIcKAXGUqRRcrsRvXdB0jjPj8hEHmrQ3 OT9Hwez0pLwyyfw6AM5blJDbPw== X-Received: by 2002:a17:902:bd84:: with SMTP id q4-v6mr23214474pls.254.1525326984583; Wed, 02 May 2018 22:56:24 -0700 (PDT) Received: from localhost.localdomain ([106.51.17.226]) by smtp.gmail.com with ESMTPSA id p5-v6sm20199552pgv.90.2018.05.02.22.56.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 May 2018 22:56:23 -0700 (PDT) From: Amit Pundir To: lkml , linux-wireless@vger.kernel.org Cc: Samuel Ortiz , Christophe Ricard , Andy Shevchenko , Greg KH , John Stultz Subject: [PATCH v2] NFC: fdp: Remove __func__ from dev_dbg() Date: Thu, 3 May 2018 11:26:19 +0530 Message-Id: <1525326979-16897-1-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Remove redundant __func__ parameter from dev_dgb() calls. v2: Deleted empty dev_dbg() trace calls, which are redundant if function tracer is enabled. Signed-off-by: Amit Pundir --- drivers/nfc/fdp/fdp.c | 18 +++--------------- drivers/nfc/fdp/i2c.c | 17 ++++------------- 2 files changed, 7 insertions(+), 28 deletions(-) -- 2.7.4 Reviewed-by: Andy Shevchenko diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c index d5784a4..f64a6fd 100644 --- a/drivers/nfc/fdp/fdp.c +++ b/drivers/nfc/fdp/fdp.c @@ -249,8 +249,6 @@ static int fdp_nci_open(struct nci_dev *ndev) struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); - r = info->phy_ops->enable(info->phy); return r; @@ -261,7 +259,6 @@ static int fdp_nci_close(struct nci_dev *ndev) struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); return 0; } @@ -270,8 +267,6 @@ static int fdp_nci_send(struct nci_dev *ndev, struct sk_buff *skb) struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); - if (atomic_dec_and_test(&info->data_pkt_counter)) info->data_pkt_counter_cb(ndev); @@ -283,7 +278,6 @@ int fdp_nci_recv_frame(struct nci_dev *ndev, struct sk_buff *skb) struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); return nci_recv_frame(ndev, skb); } EXPORT_SYMBOL(fdp_nci_recv_frame); @@ -498,8 +492,6 @@ static int fdp_nci_setup(struct nci_dev *ndev) int r; u8 patched = 0; - dev_dbg(dev, "%s\n", __func__); - r = nci_core_init(ndev); if (r) goto error; @@ -609,7 +601,6 @@ static int fdp_nci_core_reset_ntf_packet(struct nci_dev *ndev, struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); info->setup_reset_ntf = 1; wake_up(&info->setup_wq); @@ -622,7 +613,6 @@ static int fdp_nci_prop_patch_ntf_packet(struct nci_dev *ndev, struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); info->setup_patch_ntf = 1; info->setup_patch_status = skb->data[0]; wake_up(&info->setup_wq); @@ -637,7 +627,7 @@ static int fdp_nci_prop_patch_rsp_packet(struct nci_dev *ndev, struct device *dev = &info->phy->i2c_dev->dev; u8 status = skb->data[0]; - dev_dbg(dev, "%s: status 0x%x\n", __func__, status); + dev_dbg(dev, "status 0x%x\n", status); nci_req_complete(ndev, status); return 0; @@ -650,7 +640,7 @@ static int fdp_nci_prop_set_production_data_rsp_packet(struct nci_dev *ndev, struct device *dev = &info->phy->i2c_dev->dev; u8 status = skb->data[0]; - dev_dbg(dev, "%s: status 0x%x\n", __func__, status); + dev_dbg(dev, "status 0x%x\n", status); nci_req_complete(ndev, status); return 0; @@ -695,7 +685,7 @@ static int fdp_nci_core_get_config_rsp_packet(struct nci_dev *ndev, dev_dbg(dev, "OTP version %d\n", info->otp_version); dev_dbg(dev, "RAM version %d\n", info->ram_version); dev_dbg(dev, "key index %d\n", info->key_index); - dev_dbg(dev, "%s: status 0x%x\n", __func__, rsp->status); + dev_dbg(dev, "status 0x%x\n", rsp->status); nci_req_complete(ndev, rsp->status); @@ -798,8 +788,6 @@ void fdp_nci_remove(struct nci_dev *ndev) struct fdp_nci_info *info = nci_get_drvdata(ndev); struct device *dev = &info->phy->i2c_dev->dev; - dev_dbg(dev, "%s\n", __func__); - nci_unregister_device(ndev); nci_free_device(ndev); } diff --git a/drivers/nfc/fdp/i2c.c b/drivers/nfc/fdp/i2c.c index c4da50e..f355ab2 100644 --- a/drivers/nfc/fdp/i2c.c +++ b/drivers/nfc/fdp/i2c.c @@ -57,7 +57,6 @@ static int fdp_nci_i2c_enable(void *phy_id) { struct fdp_i2c_phy *phy = phy_id; - dev_dbg(&phy->i2c_dev->dev, "%s\n", __func__); fdp_nci_i2c_reset(phy); return 0; @@ -67,7 +66,6 @@ static void fdp_nci_i2c_disable(void *phy_id) { struct fdp_i2c_phy *phy = phy_id; - dev_dbg(&phy->i2c_dev->dev, "%s\n", __func__); fdp_nci_i2c_reset(phy); } @@ -113,8 +111,8 @@ static int fdp_nci_i2c_write(void *phy_id, struct sk_buff *skb) } if (r < 0 || r != skb->len) - dev_dbg(&client->dev, "%s: error err=%d len=%d\n", - __func__, r, skb->len); + dev_dbg(&client->dev, "error err=%d len=%d\n", + r, skb->len); if (r >= 0) { if (r != skb->len) { @@ -152,8 +150,7 @@ static int fdp_nci_i2c_read(struct fdp_i2c_phy *phy, struct sk_buff **skb) r = i2c_master_recv(client, tmp, len); if (r != len) { - dev_dbg(&client->dev, "%s: i2c recv err: %d\n", - __func__, r); + dev_dbg(&client->dev, "i2c recv err: %d\n", r); goto flush; } @@ -167,8 +164,7 @@ static int fdp_nci_i2c_read(struct fdp_i2c_phy *phy, struct sk_buff **skb) * and force resynchronization */ if (lrc) { - dev_dbg(&client->dev, "%s: corrupted packet\n", - __func__); + dev_dbg(&client->dev, "corrupted packet\n"); phy->next_read_size = 5; goto flush; } @@ -215,7 +211,6 @@ static irqreturn_t fdp_nci_i2c_irq_thread_fn(int irq, void *phy_id) } client = phy->i2c_dev; - dev_dbg(&client->dev, "%s\n", __func__); r = fdp_nci_i2c_read(phy, &skb); @@ -296,8 +291,6 @@ static int fdp_nci_i2c_probe(struct i2c_client *client) u32 clock_freq; int r = 0; - dev_dbg(dev, "%s\n", __func__); - if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { nfc_err(dev, "No I2C_FUNC_I2C support\n"); return -ENODEV; @@ -359,8 +352,6 @@ static int fdp_nci_i2c_remove(struct i2c_client *client) { struct fdp_i2c_phy *phy = i2c_get_clientdata(client); - dev_dbg(&client->dev, "%s\n", __func__); - fdp_nci_remove(phy->ndev); fdp_nci_i2c_disable(phy);